[GitHub] [pulsar] eolivelli commented on a change in pull request #11931: [pulsar-client]Add a optional params scope for pulsar oauth2 client

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11931:
URL: https://github.com/apache/pulsar/pull/11931#discussion_r703209752



##########
File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/auth/oauth2/AuthenticationOAuth2Test.java
##########
@@ -86,6 +86,7 @@ public void testConfigure() throws Exception {
         params.put("privateKey", "data:base64,e30=");
         params.put("issuerUrl", "http://localhost");
         params.put("audience", "http://localhost");
+        params.put("scope", "test-scope");

Review comment:
       can you please add more testing about this value ?
   I see this only added here and there is not follow up verification




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org