[GitHub] [spark] LuciferYang commented on a diff in pull request #40319: [SPARK-42692][CONNECT] Implement `Dataset.toJSON`

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #40319:
URL: https://github.com/apache/spark/pull/40319#discussion_r1128042664


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2777,7 +2778,11 @@ class Dataset[T] private[sql] (
   }
 
   def toJSON: Dataset[String] = {
-    throw new UnsupportedOperationException("toJSON is not implemented.")
+    sparkSession.newDataset(StringEncoder) { builder =>

Review Comment:
   Sorry ... what is project?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org