You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/05/14 19:30:53 UTC
[GitHub] [cxf] reta opened a new pull request, #950: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
reta opened a new pull request, #950:
URL: https://github.com/apache/cxf/pull/950
RFC-2392 (https://datatracker.ietf.org/doc/html/rfc2392) says:
content-id = url-addr-spec
url-addr-spec = addr-spec ; URL encoding of RFC 822 addr-spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] mash-sap commented on pull request #950: CXF-8698: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
Posted by GitBox <gi...@apache.org>.
mash-sap commented on PR #950:
URL: https://github.com/apache/cxf/pull/950#issuecomment-1171296652
Eaxctly @reta.
Outgoing Content-ID is encoded, but incoming message Content-ID is not decoded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] mash-sap commented on pull request #950: CXF-8698: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
Posted by GitBox <gi...@apache.org>.
mash-sap commented on PR #950:
URL: https://github.com/apache/cxf/pull/950#issuecomment-1171172489
Yes, this change is causing outgoing content-ids to be ENCODED. But unfortunately it also breaks the DECODE of incoming message. Content-ID headers do not contain "cid:-prefix as assumed here:
https://github.com/apache/cxf/pull/950/commits/221456aa5a515589b3bcda07a879de1b6e5e458c#diff-e3efb80d0a98bbbd7f6eddd3c021c5fb5ab05ea2ee8d97dc68026f6345e5a509R227
So after picking this change, I can see that outgoing headers are encoded but incoming messages are not decoded anymore. So I think there has to be a different condition to decide between en/decoding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta merged pull request #950: CXF-8698: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
Posted by GitBox <gi...@apache.org>.
reta merged PR #950:
URL: https://github.com/apache/cxf/pull/950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #950: CXF-8698: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
Posted by GitBox <gi...@apache.org>.
reta commented on PR #950:
URL: https://github.com/apache/cxf/pull/950#issuecomment-1147599141
> To me the change looks good but we don't have that many testcases covering all the use-cases.
Thanks @deki , I added a few but still the coverage indeed could be improved
> I noticed there is another issue related to cid: https://issues.apache.org/jira/browse/CXF-8706
Yes, I saw this one, I will take care of it once we this fix gets in, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #950: CXF-8698: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
Posted by GitBox <gi...@apache.org>.
reta commented on PR #950:
URL: https://github.com/apache/cxf/pull/950#issuecomment-1171421880
@mash-sap thanks for heads up, I will take a look shortly, we may fix that by properly decoding in the deserializer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #950: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
Posted by GitBox <gi...@apache.org>.
reta commented on PR #950:
URL: https://github.com/apache/cxf/pull/950#issuecomment-1139618144
@deki @ffang @dkulp guys may I ask you please to take a look? Attempt to make Content-ID behavior more compliant to the specification (+ fixing some bug reports), thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #950: CXF-8698: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
Posted by GitBox <gi...@apache.org>.
reta commented on PR #950:
URL: https://github.com/apache/cxf/pull/950#issuecomment-1171253412
Thanks @mash-sap , may I ask you please for to confirm, I am trying to understand the case: with this change non-`cid:` prefixed `Content-ID` header is encoded on serializer side and **is not** decoded on deserializer side (when header extraction happens), correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] deki commented on pull request #950: CXF-8698: Content-ID of attachments for outgoing requests are URL-decoded instead of URL-encoded
Posted by GitBox <gi...@apache.org>.
deki commented on PR #950:
URL: https://github.com/apache/cxf/pull/950#issuecomment-1147563859
Thanks for looking into that @reta. I remember I was looking into a proposed fixed a few years back and missed the errata doc for the RFC: https://www.rfc-editor.org/errata/rfc2392
To me the change looks good but we don't have that many testcases covering all the use-cases.
I noticed there is another issue related to cid: https://issues.apache.org/jira/browse/CXF-8706
We should probably fix it within the same release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org