You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:38:26 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #678: requirement: refactor error log for `manager api`
nic-chen opened a new issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678
relate to #620
- [ ] Currently only panic logs are retained, errors are just respond by apis. we need to retain error logs.
- [ ] Support custom error log level
- [ ] Support saving to a local file, and can customize the file path
- [ ] Support log rotate
we could use [zap](https://github.com/uber-go/zap) that most gophers recommend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #678: requirement: refactor error log for `manager api`
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678#issuecomment-720949059
https://github.com/cilium/cilium/blob/master/pkg/logging/logging.go
it seems a good choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #678: chore: refactor error log for `manager api`
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678#issuecomment-721107239
@membphis
it use `github.com/sirupsen/logrus`
zap is better than logrus for us, I'm sure about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis edited a comment on issue #678: chore: refactor error log for `manager api`
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678#issuecomment-721143714
nice @nic-chen ^_^
can you list some reason? We need to why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #678: chore: refactor error log for `manager api`
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678#issuecomment-721486051
Nice got it. And I check the license, it is MIT, good for us too.
Please confirm whether it will introduce new dependent libraries and their licenses are acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #678: chore: refactor error log for `manager api`
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678#issuecomment-722801763
done.
rotate should be done with `access log` feature or after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #678: chore: refactor error log for `manager api`
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678#issuecomment-721143714
nice @nic-chen ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #678: chore: refactor error log for `manager api`
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678#issuecomment-721463981
> nice @nic-chen ^_^
>
> can you list some reason? We need to why.
it has almost the same feature and much faster. and it support atomic level, sampling .. etc advanced features
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #678: chore: refactor error log for `manager api`
Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org