You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/05/26 08:57:33 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request, #4935: CQ4934-Micrometer: InstrumentedThreadPoolFactory
JiriOndrusek opened a new pull request, #4935:
URL: https://github.com/apache/camel-quarkus/pull/4935
fixes https://github.com/apache/camel-quarkus/issues/4934
PR adds property `quarkus.camel.metrics.enable-instrumented-thread-pool-factory` (with default value false -> no change in behavior), which allows initialization of the `InstrumentedThreadPoolFactory`. Basic test detecting presence of custom threadPoolFactory is added into deployment module.
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4935: Micrometer: InstrumentedThreadPoolFactory
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4935:
URL: https://github.com/apache/camel-quarkus/pull/4935#issuecomment-1564101249
>
This will be covered in https://github.com/apache/camel-quarkus/issues/4582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #4935: Micrometer: InstrumentedThreadPoolFactory
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #4935:
URL: https://github.com/apache/camel-quarkus/pull/4935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4935: Micrometer: InstrumentedThreadPoolFactory
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #4935:
URL: https://github.com/apache/camel-quarkus/pull/4935#issuecomment-1564088707
> Basic test detecting presence of custom threadPoolFactory is added into deployment module
Please can we add something into the main `Micrometer` itest module to verify it that it does work as expected. E.g check if a few known metrics are present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org