You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2023/06/21 13:21:17 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7663: KVM: fix overprovisioning memory

DaanHoogland commented on code in PR #7663:
URL: https://github.com/apache/cloudstack/pull/7663#discussion_r1236994744


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -282,7 +282,7 @@ public void setMemBalloning(boolean memoryBalloning) {
         @Override
         public String toString() {
             StringBuilder response = new StringBuilder();
-            response.append(String.format("<memory>%s</memory>\n", this.currentMemory));
+            response.append(String.format("<memory>%s</memory>\n", this.memory));

Review Comment:
   this seems to have no effect in my tests. looking for the answer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org