You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Roman Coedo <no...@github.com> on 2014/06/20 02:20:07 UTC
[jclouds-labs-aws] JCLOUDS-457: Added completeMultipartUpload and
abortMultipartUplod. (#21)
Now the Glacier client supports completeMultipartUpload and i
abortMultipartUpload operations.
You can merge this Pull Request by running:
git pull https://github.com/rcoedo/jclouds-labs-aws abcomp
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-aws/pull/21
-- Commit Summary --
* JCLOUDS-457: Added completeMultipartUpload and abortMultipartUplod.
-- File Changes --
M glacier/src/main/java/org/jclouds/glacier/GlacierAsyncClient.java (27)
M glacier/src/main/java/org/jclouds/glacier/GlacierClient.java (31)
A glacier/src/main/java/org/jclouds/glacier/binders/BindArchiveSizeToHeaders.java (41)
A glacier/src/main/java/org/jclouds/glacier/binders/BindMultipartTreeHashToHeaders.java (46)
M glacier/src/main/java/org/jclouds/glacier/reference/GlacierHeaders.java (1)
M glacier/src/test/java/org/jclouds/glacier/GlacierClientMockTest.java (34)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-aws/pull/21.patch
https://github.com/jclouds/jclouds-labs-aws/pull/21.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/21
Re: [jclouds-labs-aws] JCLOUDS-457: Added completeMultipartUpload and
abortMultipartUplod. (#21)
Posted by Andrew Gaul <no...@github.com>.
Amended commit, tested locally, and pushed to master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/21#issuecomment-46731419
Re: [jclouds-labs-aws] JCLOUDS-457: Added completeMultipartUpload and
abortMultipartUplod. (#21)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-aws #1004](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/1004/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/21#issuecomment-46633243
Re: [jclouds-labs-aws] JCLOUDS-457: Added completeMultipartUpload and
abortMultipartUplod. (#21)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-aws-pull-requests #46](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/46/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/21#issuecomment-46633354
Re: [jclouds-labs-aws] JCLOUDS-457: Added completeMultipartUpload and
abortMultipartUplod. (#21)
Posted by Andrew Gaul <no...@github.com>.
> @@ -271,4 +273,36 @@ public void testUploadPartMaxSize() throws InterruptedException {
> assertEquals(request.getHeader(HttpHeaders.CONTENT_RANGE), range.buildHeader());
> assertEquals(request.getHeader(HttpHeaders.CONTENT_LENGTH), payload.getContentMetadata().getContentLength().toString());
> }
> +
> + @Test
> + public void testCompleteMultipartUpload() throws IOException, InterruptedException {
> + MockResponse mr = buildBaseResponse(201);
> + mr.addHeader(HttpHeaders.LOCATION, ARCHIVE_LOCATION);
> + mr.addHeader(GlacierHeaders.ARCHIVE_ID, ARCHIVE_ID);
> + server.enqueue(mr);
> +
> + String partHashcode = "9bc1b2a288b26af7257a36277ae3816a7d4f16e89c1e7e77d0a5c48bad62b360";
> + ImmutableMap.Builder<Integer, HashCode> mapBuilder = ImmutableMap.builder();
> + mapBuilder.put(1, HashCode.fromString(partHashcode));
> + mapBuilder.put(2, HashCode.fromString(partHashcode));
> + mapBuilder.put(3, HashCode.fromString(partHashcode));
> + mapBuilder.put(4, HashCode.fromString(partHashcode));
I amended your commit to improve the use of `HashCode` and `ImmutableMap`.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/21/files#r14043319
Re: [jclouds-labs-aws] JCLOUDS-457: Added completeMultipartUpload and
abortMultipartUplod. (#21)
Posted by Andrew Gaul <no...@github.com>.
Closed #21.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/21#event-133715907