You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/11 22:56:18 UTC

[GitHub] [pinot] jtao15 commented on a change in pull request #7752: Handle null segment lineage ZNRecord for getSelectedSegments API

jtao15 commented on a change in pull request #7752:
URL: https://github.com/apache/pinot/pull/7752#discussion_r747869255



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -620,10 +620,14 @@ public String getCrypterClassNameFromTableConfig(String tableNameWithType) {
     // Fetch the segment lineage metadata, and filter segments based on segment lineage.
     ZNRecord segmentLineageZNRecord =
         SegmentLineageAccessHelper.getSegmentLineageZNRecord(_propertyStore, tableNameWithType);

Review comment:
       Can we reuse `SegmentLineageAccessHelper.getSegmentLineage()` instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org