You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2016/06/06 21:10:57 UTC
[jclouds/jclouds-examples] Example for updating the signed URLs key.
(#87)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-examples/pull/87
-- Commit Summary --
* Example for updating the signed URLs key.
-- File Changes --
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/GenerateTempURL.java (17)
-- Patch Links --
https://github.com/jclouds/jclouds-examples/pull/87.patch
https://github.com/jclouds/jclouds-examples/pull/87.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/87
Re: [jclouds/jclouds-examples] Example for updating the signed URLs
key. (#87)
Posted by Zack Shoylev <no...@github.com>.
> @@ -105,6 +109,19 @@ private void createContainer() throws IOException {
> }
> }
>
> + private void updatePrivateURLKey() throws IOException {
> + // The key can be changed to quickly expire all existing signed URLs.
> + AccountApi accountApi = blobStore
> + .getContext()
Thoughts?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/87/files/c55b700333641724330d35daa5121275c1c38d09#r66348704
Re: [jclouds/jclouds-examples] Example for updating the signed URLs
key. (#87)
Posted by Zack Shoylev <no...@github.com>.
> @@ -105,6 +109,19 @@ private void createContainer() throws IOException {
> }
> }
>
> + private void updatePrivateURLKey() throws IOException {
> + // The key can be changed to quickly expire all existing signed URLs.
> + AccountApi accountApi = blobStore
> + .getContext()
Yes, probably, I wanted it to be more explicit, though.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/87/files/c55b700333641724330d35daa5121275c1c38d09#r66164424
Re: [jclouds/jclouds-examples] Example for updating the signed URLs
key. (#87)
Posted by Zack Shoylev <no...@github.com>.
merged
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/87#issuecomment-224460467
Re: [jclouds/jclouds-examples] Example for updating the signed URLs
key. (#87)
Posted by Andrew Phillips <no...@github.com>.
> @@ -105,6 +109,19 @@ private void createContainer() throws IOException {
> }
> }
>
> + private void updatePrivateURLKey() throws IOException {
> + // The key can be changed to quickly expire all existing signed URLs.
> + AccountApi accountApi = blobStore
> + .getContext()
> I wanted it to be more explicit, though.
Ah, OK. In that case, would it make sense to replace the other occurrences of `blobStoreContext` in the example (e.g. `HttpRequest request = blobStoreContext.getSigner(REGION)...`) with `blobStore.getContext()`?
From a user's perspective, I wonder if it's clear whether they can/should be used interchangeably, or when to use which one..?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/87/files/c55b700333641724330d35daa5121275c1c38d09#r66234055
Re: [jclouds/jclouds-examples] Example for updating the signed URLs
key. (#87)
Posted by Zack Shoylev <no...@github.com>.
> @@ -105,6 +109,19 @@ private void createContainer() throws IOException {
> }
> }
>
> + private void updatePrivateURLKey() throws IOException {
> + // The key can be changed to quickly expire all existing signed URLs.
> + AccountApi accountApi = blobStore
> + .getContext()
Yes, the example seems confusing now that you mentioned that. Personal opinion: it would make more sense to completely remove the blobStoreContext variable and use getContext() instead, just so users have an easier time reading the code (it's a short example).
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/87/files/c55b700333641724330d35daa5121275c1c38d09#r66348637
Re: [jclouds/jclouds-examples] Example for updating the signed URLs
key. (#87)
Posted by Andrew Phillips <no...@github.com>.
> @@ -105,6 +109,19 @@ private void createContainer() throws IOException {
> }
> }
>
> + private void updatePrivateURLKey() throws IOException {
> + // The key can be changed to quickly expire all existing signed URLs.
> + AccountApi accountApi = blobStore
> + .getContext()
[minor] Would `blobStoreContext.unwrapApi` work here too?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/87/files/c55b700333641724330d35daa5121275c1c38d09#r66003255
Re: [jclouds/jclouds-examples] Example for updating the signed URLs
key. (#87)
Posted by Zack Shoylev <no...@github.com>.
Closed #87.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/87#event-685173631