[jira] [Commented] (SQOOP-890) ClassWriter Generates setField Casts Based on the Output Type, not the Input Type

["Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714728#comment-13714728 ] 

Jarek Jarcec Cecho commented on SQOOP-890:
------------------------------------------

Hi [~njw45],
would you mind consolidating both files into one single patch and uploading it to our [review board|https://reviews.apache.org/dashboard/]?
                
> ClassWriter Generates setField Casts Based on the Output Type, not the Input Type
> ---------------------------------------------------------------------------------
>
>                 Key: SQOOP-890
>                 URL: https://issues.apache.org/jira/browse/SQOOP-890
>             Project: Sqoop
>          Issue Type: Bug
>          Components: codegen
>    Affects Versions: 1.4.2
>            Reporter: Nick White
>            Assignee: Nick White
>             Fix For: 1.4.5
>
>         Attachments: SQOOP-890.patch, SQOOP-890.testcase.patch
>
>
> I've attached a testcase that exports from a Long column in an avro file to an Integer column in the database. The setField method the ClassWriter generates puts in an (Integer) cast, whereas it should be a (Long) cast. The fix isn't immediately obvious, as the generateSetField currently only has the SQL types, not the input types.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira