You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "shoothzj (via GitHub)" <gi...@apache.org> on 2024/03/04 00:54:37 UTC
[PR] IGNITE-21660 ClientQueryCursor is not closed in getAll [ignite]
shoothzj opened a new pull request, #11264:
URL: https://github.com/apache/ignite/pull/11264
https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-21660
ClientQueryCursor is not closed in `getAll()` method. According to the annotation, it should be closed.
Annotation:
Since all the results will be fetched, all the resources will be closed automatically after this call, e.g. there is no need to call {@link #close()} method in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21660 ClientQueryCursor is not closed in getAll [ignite]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on PR #11264:
URL: https://github.com/apache/ignite/pull/11264#issuecomment-1975835711
I've closed the PR and the JIRA ticket. Let me know if you think there is still something missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21660 ClientQueryCursor is not closed in getAll [ignite]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on PR #11264:
URL: https://github.com/apache/ignite/pull/11264#issuecomment-1975834606
@shoothzj there is no bug. We don't need to call `close` in `getAll`, because the server cleans up all resources automatically when it returns the last page of the query.
See `ClientCacheQueryCursor#writePage`: https://github.com/apache/ignite/blob/2fbbb676386515ea881e4e61f08864d6bc93225a/modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/cache/ClientCacheQueryCursor.java#L88-L89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21660 ClientQueryCursor is not closed in getAll [ignite]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #11264:
URL: https://github.com/apache/ignite/pull/11264#issuecomment-1975471179
@ptupitsyn cloud you please take a look? thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21660 ClientQueryCursor is not closed in getAll [ignite]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn closed pull request #11264: IGNITE-21660 ClientQueryCursor is not closed in getAll
URL: https://github.com/apache/ignite/pull/11264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org