You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/14 09:15:45 UTC
[GitHub] [kafka] jlprat opened a new pull request #10693: KAFKA-12625: Fix the NOTICE file
jlprat opened a new pull request #10693:
URL: https://github.com/apache/kafka/pull/10693
Adds new NOTICE-binary file and packages it in the binary release
This follows up the https://github.com/apache/kafka/pull/10474 pull where LICENSE was fix.
Similarly as in that PR, I do not know if this is correct, and I would add the same disclaimer @vvcephei did: "Please make no assumption that I know what I'm doing and let me know if anything seems wrong."
I went through all jar files within the distribution file and copied the content of any existing NOTICE file.
Notes:
* For the cases where several dependencies including the same NOTICE, I added it only once.
* There are cases where the jar included in Kafka's distribution file doesn't contain any NOTICE file, hence nothing was copied. These are:
* activation-1.1.1.jar
* argparse4j-0.7.0.jar
* jackson-annotations-2.10.5.jar
* jackson-dataformat-csv-2.10.5.jar
* jackson-datatype-jdk8-2.10.5.jar
* jackson-jaxrs-base-2.10.5.jar
* jackson-module-scala_2.13-2.10.5.jar
* jakarta.validation-api-2.0.2.jar
* javassist-3.27.0-GA.jar
* javax.servlet-api-3.1.0.jar
* javax.ws.rs-api-2.1.1.jar
* jaxb-api-2.3.0.jar
* jline-3.12.1.jar
* jopt-simple-5.0.4.jar
* lz4-java-1.7.1.jar
* metrics-core-2.2.0.jar
* netty-buffer-4.1.62.Final.jar
* netty-codec-4.1.62.Final.jar
* netty-common-4.1.62.Final.jar
* netty-handler-4.1.62.Final.jar
* netty-resolver-4.1.62.Final.jar
* netty-transport-4.1.62.Final.jar
* netty-transport-native-epoll-4.1.62.Final.jar
* netty-transport-native-unix-common-4.1.62.Final.jar
* reflections-0.9.12.jar
* rocksdbjni-6.19.3.jar
* scala-collection-compat_2.13-2.3.0.jar
* scala-java8-compat_2.13-0.9.1.jar
* scala-logging_2.13-3.9.2.jar
* slf4j-api-1.7.30.jar
* slf4j-log4j12-1.7.30.jar
* snappy-java-1.1.8.1.jar
* zstd-jni-1.4.9-1.jar
* For some of those _NOTICE-missing-in-jar_ dependencies, there were other dependencies from the same project that included a NOTICE file, for example, the jackson ones.
* For the Netty project, I manually copied their NOTICE file from github
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-889393251
Thanks @vvcephei for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-841197433
Failures were https://issues.apache.org/jira/browse/KAFKA-9009 and https://issues.apache.org/jira/browse/KAFKA-12629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-851831451
Thanks for looking at it @ableegoldman ,
I'll do my best explaining:
a) I added a NOTICE-binary file following the same pattern done for the LICENSE patch. The purpose of the NOTICE-binary is to be included in the distribution file only.
b) The content of our NOTICE is what Kafka declares, that I left untouched. The purpose of the NOTICE-binary is to collect all notices from all our dependencies and paste them there.
c) I'm no expert at all, but I'd say the licenses folder was merely to collect all the different texts of licences so we could reference them in our LICENSE-binary (I think licenses say their text needs to be included)
I looked at https://github.com/apache/hadoop and attempted to use the same approach.
On short, NOTICE contains Kafka's notices while NOTICE-binary contains Kafka's and its dependencies' notices so it can be packaged in our distribution files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-851732066
Hey @jlprat , can you elaborate on (a) the motivation behind adding this `NOTICE-binary` file (are we missing licenses completely? or we had them but not in the correct format? etc), (b) why you put this in a new `NOTICE-binary` file instead of the existing `NOTICE` file (do we need both? if we do add this `NOTICE-binary` then should we remove some or all of the `NOTICE` file contents?), and (c) how the `NOTICE-binary` file relates to the existing stuff under `licenses/`
I'll extend the same disclaimer, make no assumption that I know what I'm talking about 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-856457128
Thanks @ableegoldman for your comments.
As far as I can tell after reading https://issues.apache.org/jira/browse/KAFKA-12625, mostly the copyright files were worked on, but NOTICE file was still not done yet. Or at least not completely.
Let's see if @vvcephei can clarify things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a change in pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on a change in pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#discussion_r632410626
##########
File path: LICENSE-binary
##########
@@ -243,7 +243,6 @@ netty-handler-4.1.59.Final
netty-resolver-4.1.59.Final
netty-transport-4.1.59.Final
netty-transport-native-epoll-4.1.59.Final
-netty-transport-native-epoll-4.1.59.Final
Review comment:
I removed this line from LICENCE-binary as it was a duplicate one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-851594252
Hi @ableegoldman as you reviewed the last change in that area (fix license files) do you think you can review this one? Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-845817871
@vvcephei As you were the last one touching that area, would you like to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-841123185
I would highly appreciate any hint on how to proceed for the dependencies that do not include a notice file in their jar files but might include them in their source code repositories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a change in pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
jlprat commented on a change in pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#discussion_r632410626
##########
File path: LICENSE-binary
##########
@@ -243,7 +243,6 @@ netty-handler-4.1.59.Final
netty-resolver-4.1.59.Final
netty-transport-4.1.59.Final
netty-transport-native-epoll-4.1.59.Final
-netty-transport-native-epoll-4.1.59.Final
Review comment:
I removed this line from LICENSE-binary as it was a duplicate one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei merged pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #10693:
URL: https://github.com/apache/kafka/pull/10693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10693: KAFKA-12625: Fix the NOTICE file
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-856336135
Thanks. We just went through a large cleanup of the licensing and notices for the 2.8.0 release, which is how we ended up in the current state of things. It was my understanding that we had reached a place in which all the necessary pieces were being included in the correct place, which is why I was asking what the motivation for making further changes was. I'll let @vvcephei chime in from here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org