[GitHub] [spark] cloud-fan commented on a change in pull request #31403: [SPARK-34301][SQL] Use logical plan of alter table in `CatalogImpl.recoverPartitions()`

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31403:
URL: https://github.com/apache/spark/pull/31403#discussion_r567805248



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -446,9 +446,9 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {
    * @since 2.1.1
    */
   override def recoverPartitions(tableName: String): Unit = {

Review comment:
       It's probably time to figure out the public Scala API for multi-catalogs: Shall we have one single `CatalogImpl` instance, and all its methods support catalog? Or shall we have one `CatalogImpl` instance per catalog?
   
   The change here makes `recoverPartitions` to support multi-catalogs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org