You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/09/07 16:25:33 UTC
Review Request 51696: GEODE-1777 CI failure:
RestAPIsOnMembersFunctionExecutionDUnitTest.testFunctionExecutionEOnSelectedMembers[
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51696/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
Repository: geode
Description
-------
Looking through our distributedTest output I see a large number of full GCs initiated by Metaspace cleanup. Some of these GCs are taking as long as 70 seconds and cause nodes to be kicked out of the distributed system. For Java 8 it's recommended that you estimate requirements for Metaspace and set XXMetaspaceSize to avoid these full GCs. Our REST tests seem to need nearly half a gigabyte of metaspace so I've set it accordingly. An AWS precheckin run with this change showed only one GC initiated by metaspace management, in the geode-web distributedTest suite lasting 1/2 second.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java f938c1a88cfec459efe4c87b8be41a6fa5c291e4
Diff: https://reviews.apache.org/r/51696/diff/
Testing
-------
precheckin
Thanks,
Bruce Schuchardt
Re: Review Request 51696: GEODE-1777 CI failure:
RestAPIsOnMembersFunctionExecutionDUnitTest.testFunctionExecutionEOnSelectedMembers[
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51696/#review148270
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On Sept. 7, 2016, 4:25 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51696/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2016, 4:25 p.m.)
>
>
> Review request for geode, Anthony Baker, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Looking through our distributedTest output I see a large number of full GCs initiated by Metaspace cleanup. Some of these GCs are taking as long as 70 seconds and cause nodes to be kicked out of the distributed system. For Java 8 it's recommended that you estimate requirements for Metaspace and set XXMetaspaceSize to avoid these full GCs. Our REST tests seem to need nearly half a gigabyte of metaspace so I've set it accordingly. An AWS precheckin run with this change showed only one GC initiated by metaspace management, in the geode-web distributedTest suite lasting 1/2 second.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java f938c1a88cfec459efe4c87b8be41a6fa5c291e4
>
> Diff: https://reviews.apache.org/r/51696/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 51696: GEODE-1777 CI failure:
RestAPIsOnMembersFunctionExecutionDUnitTest.testFunctionExecutionEOnSelectedMembers[
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51696/#review148237
-----------------------------------------------------------
Ship it!
We might also want to change the settings in gradle/test.gradle for the constroller VM. See line "jvmArgs = ['-XX:+HeapDumpOnOutOfMemoryError', '-ea']" That affects all tests - unit tests, integration tests, and distributed tests though.
- Dan Smith
On Sept. 7, 2016, 4:25 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51696/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2016, 4:25 p.m.)
>
>
> Review request for geode, Anthony Baker, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Looking through our distributedTest output I see a large number of full GCs initiated by Metaspace cleanup. Some of these GCs are taking as long as 70 seconds and cause nodes to be kicked out of the distributed system. For Java 8 it's recommended that you estimate requirements for Metaspace and set XXMetaspaceSize to avoid these full GCs. Our REST tests seem to need nearly half a gigabyte of metaspace so I've set it accordingly. An AWS precheckin run with this change showed only one GC initiated by metaspace management, in the geode-web distributedTest suite lasting 1/2 second.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java f938c1a88cfec459efe4c87b8be41a6fa5c291e4
>
> Diff: https://reviews.apache.org/r/51696/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 51696: GEODE-1777 CI failure:
RestAPIsOnMembersFunctionExecutionDUnitTest.testFunctionExecutionEOnSelectedMembers[
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51696/#review148029
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Sept. 7, 2016, 4:25 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51696/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2016, 4:25 p.m.)
>
>
> Review request for geode, Anthony Baker, Hitesh Khamesra, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Looking through our distributedTest output I see a large number of full GCs initiated by Metaspace cleanup. Some of these GCs are taking as long as 70 seconds and cause nodes to be kicked out of the distributed system. For Java 8 it's recommended that you estimate requirements for Metaspace and set XXMetaspaceSize to avoid these full GCs. Our REST tests seem to need nearly half a gigabyte of metaspace so I've set it accordingly. An AWS precheckin run with this change showed only one GC initiated by metaspace management, in the geode-web distributedTest suite lasting 1/2 second.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java f938c1a88cfec459efe4c87b8be41a6fa5c291e4
>
> Diff: https://reviews.apache.org/r/51696/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>