You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Andrew Shirley (JIRA)" <ji...@apache.org> on 2006/06/30 13:24:32 UTC

[jira] Created: (CLI-120) equals and hashCode are incomplete

equals and hashCode are incomplete
----------------------------------

         Key: CLI-120
         URL: http://issues.apache.org/jira/browse/CLI-120
     Project: Commons CLI
        Type: Improvement

    Versions: 2.0 Beta 1    
    Reporter: Andrew Shirley
    Priority: Minor


there are many classes with equals and hashCode implemented however there are also classes which don't. We need to be consistent and if we are using equals then we need to define it for all classes in the affected hierarchy. For example OptionImpl has an equals but ParentImpl which extends OptionImpl and has several new members doesn't.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (CLI-120) equals and hashCode are incomplete

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/CLI-120?page=all ]

Henri Yandell updated CLI-120:
------------------------------

    Fix Version: 2.0

> equals and hashCode are incomplete
> ----------------------------------
>
>          Key: CLI-120
>          URL: http://issues.apache.org/jira/browse/CLI-120
>      Project: Commons CLI
>         Type: Improvement

>     Reporter: Andrew Shirley
>     Priority: Minor
>      Fix For: 2.0

>
> there are many classes with equals and hashCode implemented however there are also classes which don't. We need to be consistent and if we are using equals then we need to define it for all classes in the affected hierarchy. For example OptionImpl has an equals but ParentImpl which extends OptionImpl and has several new members doesn't.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (CLI-120) equals and hashCode are incomplete

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/CLI-120?page=comments#action_12420516 ] 

Henri Yandell commented on CLI-120:
-----------------------------------

+1, patches welcome :)

> equals and hashCode are incomplete
> ----------------------------------
>
>          Key: CLI-120
>          URL: http://issues.apache.org/jira/browse/CLI-120
>      Project: Commons CLI
>         Type: Improvement

>     Reporter: Andrew Shirley
>     Priority: Minor
>      Fix For: 2.0

>
> there are many classes with equals and hashCode implemented however there are also classes which don't. We need to be consistent and if we are using equals then we need to define it for all classes in the affected hierarchy. For example OptionImpl has an equals but ParentImpl which extends OptionImpl and has several new members doesn't.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org