[GitHub] [iceberg] wypoon commented on a diff in pull request #5742: Spark: Add read conf for setting threshold to use streaming delete filter

[GitBox <gi...@apache.org>]

wypoon commented on code in PR #5742:
URL: https://github.com/apache/iceberg/pull/5742#discussion_r968959639


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/BaseReader.java:
##########
@@ -252,7 +252,13 @@ protected class SparkDeleteFilter extends DeleteFilter<InternalRow> {
     private final InternalRowWrapper asStructLike;
 
     SparkDeleteFilter(String filePath, List<DeleteFile> deletes, DeleteCounter counter) {
-      super(filePath, deletes, table.schema(), expectedSchema, counter);
+      super(
+          filePath,
+          deletes,
+          table.schema(),
+          expectedSchema,
+          DeleteFilter.DEFAULT_STREAM_FILTER_THRESHOLD,
+          counter);

Review Comment:
   This is the only change I make to spark/v3.2 here, which is needed because the superclass, `DeleteFilter`, now takes the additional parameter.
   Once this PR is merged, I can port the changes to spark/v3.3 to v3.2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org