You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/02/20 11:21:48 UTC

Re: [PR] [SPARK-47079][PYTHON][SQL][CONNECT] Add Variant type info to PySpark [spark]

HyukjinKwon commented on code in PR #45131:
URL: https://github.com/apache/spark/pull/45131#discussion_r1495653944


##########
python/pyspark/sql/types.py:
##########
@@ -2384,6 +2408,14 @@ def verify_struct(obj: Any) -> None:
 
         verify_value = verify_struct
 
+    elif isinstance(dataType, VariantType):
+
+        def verify_variant(obj: Any) -> None:
+            # The variant data type can take in any type.
+            pass
+
+        verify_value = verify_variant

Review Comment:
   Hm, don't we need `createDataFrame`, `collect` and Python UDF test cases that uses this type? If you plan to do them in separate PRs, that's fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org