You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Travis Crawford <tr...@gmail.com> on 2012/09/11 19:20:33 UTC

Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7024/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Description
-------

Add Hive build support for publishing artifacts to a user-defined Maven repo. This is accomplished with:

ant clean maven-build maven-publish -Dversion=0.10.0-mybuild01 -Dmvn.deploy.id=my.repo.id -Dmvn.deploy.url=http://my.maven.repo/path

This feature will be useful for developers who maintain their own build and need to share those artifacts with others.


This addresses bug HIVE-3450.
    https://issues.apache.org/jira/browse/HIVE-3450


Diffs
-----

  build.properties d2bfc30 
  build.xml add5a46 

Diff: https://reviews.apache.org/r/7024/diff/


Testing
-------


Thanks,

Travis Crawford


Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

Posted by Travis Crawford <tr...@gmail.com>.

> On Sept. 11, 2012, 5:47 p.m., Feng Peng wrote:
> > build.xml, line 23
> > <https://reviews.apache.org/r/7024/diff/1/?file=152640#file152640line23>
> >
> >     Any reason for this change?

I changed the "urn" lines after reading http://maven.apache.org/ant-tasks/installation.html

The following example is shown for how to setup these tasks.

"""
<project ... xmlns:artifact="antlib:org.apache.maven.artifact.ant">
  ...
  <path id="maven-ant-tasks.classpath" path="lib/maven-ant-tasks-2.1.3.jar" />
  <typedef resource="org/apache/maven/artifact/ant/antlib.xml"
           uri="antlib:org.apache.maven.artifact.ant"
           classpathref="maven-ant-tasks.classpath" />
  ...
</project>
"""

However, I reverted the "urn" changes and was able to publish to a user-defined repo, so I'll update the patch to remove these changed lines.


- Travis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7024/#review11340
-----------------------------------------------------------


On Sept. 11, 2012, 5:21 p.m., Travis Crawford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7024/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 5:21 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Dmitriy Ryaboy, and Feng Peng.
> 
> 
> Description
> -------
> 
> Add Hive build support for publishing artifacts to a user-defined Maven repo. This is accomplished with:
> 
> ant clean maven-build maven-publish -Dversion=0.10.0-mybuild01 -Dmvn.deploy.id=my.repo.id -Dmvn.deploy.url=http://my.maven.repo/path
> 
> This feature will be useful for developers who maintain their own build and need to share those artifacts with others.
> 
> 
> This addresses bug HIVE-3450.
>     https://issues.apache.org/jira/browse/HIVE-3450
> 
> 
> Diffs
> -----
> 
>   build.properties d2bfc30 
>   build.xml add5a46 
> 
> Diff: https://reviews.apache.org/r/7024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Travis Crawford
> 
>


Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

Posted by Feng Peng <pe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7024/#review11340
-----------------------------------------------------------



build.xml
<https://reviews.apache.org/r/7024/#comment24376>

    Any reason for this change?


- Feng Peng


On Sept. 11, 2012, 5:21 p.m., Travis Crawford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7024/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 5:21 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Dmitriy Ryaboy, and Feng Peng.
> 
> 
> Description
> -------
> 
> Add Hive build support for publishing artifacts to a user-defined Maven repo. This is accomplished with:
> 
> ant clean maven-build maven-publish -Dversion=0.10.0-mybuild01 -Dmvn.deploy.id=my.repo.id -Dmvn.deploy.url=http://my.maven.repo/path
> 
> This feature will be useful for developers who maintain their own build and need to share those artifacts with others.
> 
> 
> This addresses bug HIVE-3450.
>     https://issues.apache.org/jira/browse/HIVE-3450
> 
> 
> Diffs
> -----
> 
>   build.properties d2bfc30 
>   build.xml add5a46 
> 
> Diff: https://reviews.apache.org/r/7024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Travis Crawford
> 
>


Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

Posted by Feng Peng <pe...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7024/#review11355
-----------------------------------------------------------


lgtm. non-committer +1

- Feng Peng


On Sept. 11, 2012, 6:30 p.m., Travis Crawford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7024/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 6:30 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Dmitriy Ryaboy, and Feng Peng.
> 
> 
> Description
> -------
> 
> Add Hive build support for publishing artifacts to a user-defined Maven repo. This is accomplished with:
> 
> ant clean maven-build maven-publish -Dversion=0.10.0-mybuild01 -Dmvn.deploy.id=my.repo.id -Dmvn.deploy.url=http://my.maven.repo/path
> 
> This feature will be useful for developers who maintain their own build and need to share those artifacts with others.
> 
> 
> This addresses bug HIVE-3450.
>     https://issues.apache.org/jira/browse/HIVE-3450
> 
> 
> Diffs
> -----
> 
>   build.properties d2bfc30 
>   build.xml add5a46 
> 
> Diff: https://reviews.apache.org/r/7024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Travis Crawford
> 
>


Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

Posted by Travis Crawford <tr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7024/
-----------------------------------------------------------

(Updated Sept. 11, 2012, 6:30 p.m.)


Review request for hive, Ashutosh Chauhan, Dmitriy Ryaboy, and Feng Peng.


Changes
-------

This updated diff reverts the maven-ant-task initialization changes that were made to match the docs. Testing shows the current configuration works too, so we'll leave it as-is.


Description
-------

Add Hive build support for publishing artifacts to a user-defined Maven repo. This is accomplished with:

ant clean maven-build maven-publish -Dversion=0.10.0-mybuild01 -Dmvn.deploy.id=my.repo.id -Dmvn.deploy.url=http://my.maven.repo/path

This feature will be useful for developers who maintain their own build and need to share those artifacts with others.


This addresses bug HIVE-3450.
    https://issues.apache.org/jira/browse/HIVE-3450


Diffs (updated)
-----

  build.properties d2bfc30 
  build.xml add5a46 

Diff: https://reviews.apache.org/r/7024/diff/


Testing
-------


Thanks,

Travis Crawford


Re: Review Request: HIVE-3450 Hive maven-publish ant task should be configurable

Posted by Travis Crawford <tr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7024/
-----------------------------------------------------------

(Updated Sept. 11, 2012, 5:21 p.m.)


Review request for hive, Ashutosh Chauhan, Dmitriy Ryaboy, and Feng Peng.


Description
-------

Add Hive build support for publishing artifacts to a user-defined Maven repo. This is accomplished with:

ant clean maven-build maven-publish -Dversion=0.10.0-mybuild01 -Dmvn.deploy.id=my.repo.id -Dmvn.deploy.url=http://my.maven.repo/path

This feature will be useful for developers who maintain their own build and need to share those artifacts with others.


This addresses bug HIVE-3450.
    https://issues.apache.org/jira/browse/HIVE-3450


Diffs
-----

  build.properties d2bfc30 
  build.xml add5a46 

Diff: https://reviews.apache.org/r/7024/diff/


Testing
-------


Thanks,

Travis Crawford