[GitHub] [qpid-proton] jiridanek commented on a change in pull request #295: fix invalid unsigned arithmetic.

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #295:
URL: https://github.com/apache/qpid-proton/pull/295#discussion_r571908931



##########
File path: c/src/messenger/store.c
##########
@@ -421,7 +421,7 @@ int pni_store_update(pni_store_t *store, pn_sequence_t id, pn_status_t status,
     }
   }
 
-  while (store->hwm - store->lwm > 0 &&
+  while (store->hwm > store->lwm &&

Review comment:
       I'd feel safer replacing this with `store->hwm != store->lwm` just to keep the code behavior completely identical. I haven't managed to convince myself that this change is always going to work... Somebody else who actually understands this needs to review as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org