You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/03/23 04:19:52 UTC
[GitHub] [servicecomb-java-chassis] codecov-io commented on pull request #2310: [SCB-2234] configuration for instance properties should support placeholder
codecov-io commented on pull request #2310:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2310#issuecomment-804605246
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310?src=pr&el=h1) Report
> Merging [#2310](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310?src=pr&el=desc) (3a4aa83) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/8619d5cf3d7250fcd6f35fe5416c193791de5d38?el=desc) (8619d5c) will **decrease** coverage by `0.02%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2310 +/- ##
============================================
- Coverage 79.27% 79.24% -0.03%
Complexity 1369 1369
============================================
Files 1535 1535
Lines 41087 41092 +5
Branches 3466 3466
============================================
- Hits 32572 32564 -8
- Misses 7014 7025 +11
- Partials 1501 1503 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/servicecomb/zeroconfig/Config.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS16ZXJvLWNvbmZpZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvemVyb2NvbmZpZy9Db25maWcuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/servicecomb/config/ConfigUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9Db25maWdVdGlsLmphdmE=) | `88.02% <50.00%> (-0.63%)` | `0.00 <0.00> (ø)` | |
| [...apache/servicecomb/config/BootStrapProperties.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9Cb290U3RyYXBQcm9wZXJ0aWVzLmphdmE=) | `66.12% <75.00%> (-2.73%)` | `0.00 <0.00> (ø)` | |
| [...in/java/org/apache/servicecomb/core/SCBEngine.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9TQ0JFbmdpbmUuamF2YQ==) | `77.51% <100.00%> (+0.27%)` | `0.00 <0.00> (ø)` | |
| [...ache/servicecomb/registry/RegistrationManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvUmVnaXN0cmF0aW9uTWFuYWdlci5qYXZh) | `88.27% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | `0.00% <0.00%> (ø%)` | |
| [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `75.70% <0.00%> (-1.87%)` | `0.00% <0.00%> (ø%)` | |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `69.32% <0.00%> (-1.17%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310?src=pr&el=footer). Last update [8619d5c...3a4aa83](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2310?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org