[GitHub] [carbondata] akashrn5 commented on a change in pull request #3946: [CARBONDATA-4002] Fix removal of columns from table schema.

[GitBox <gi...@apache.org>]

akashrn5 commented on a change in pull request #3946:
URL: https://github.com/apache/carbondata/pull/3946#discussion_r492651158



##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala
##########
@@ -434,6 +437,24 @@ class VarcharDataTypesBasicTestCase extends QueryTest with BeforeAndAfterEach wi
 
     sql("DROP TABLE IF EXISTS varchar_complex_table")
   }
+
+  test("check new columns after modifying schema through alter table queries") {
+    sql(
+      s"""
+         | CREATE TABLE if not exists $longStringTable(

Review comment:
       as i can see, there are no long string columns, the table property `long_string_columns` doesnt have any value. SO how the unset long string affected. Basically we should avoid the flow going too far when there are no long string columns itself. can you check?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org