[GitHub] sven-lange-last commented on a change in pull request #3199: One tid for the whole system.

[GitBox <gi...@apache.org>]

sven-lange-last commented on a change in pull request #3199: One tid for the whole system.
URL: https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r180305613
 
 

 ##########
 File path: ansible/roles/nginx/templates/nginx.conf.j2
 ##########
 @@ -12,10 +12,16 @@ http {
 {# allow large uploads, need to thread proper limit into here #}
     client_max_body_size 50M;
 
+    map $http_ow_tid $ow_tid {
 
 Review comment:
   @ddragosd `set_secure_random_alphanum` depends on `/dev/urandom` which may impact performance. Is there a requirement to use a secure random and not just the ngninx built-in `request_id`? We should also understand the performance of `set_secure_random_alphanum` compared to `request_id`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services