You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/22 02:28:32 UTC
[GitHub] [rocketmq] caigy commented on a change in pull request #4010: fix mac 12+ slow bug
caigy commented on a change in pull request #4010:
URL: https://github.com/apache/rocketmq/pull/4010#discussion_r831715983
##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/ReplyMessageProcessor.java
##########
@@ -157,8 +158,10 @@ private PushReplyResult pushReplyMessage(final ChannelHandlerContext ctx,
final SendMessageRequestHeader requestHeader,
final Message msg) {
ReplyMessageRequestHeader replyMessageRequestHeader = new ReplyMessageRequestHeader();
- replyMessageRequestHeader.setBornHost(ctx.channel().remoteAddress().toString());
- replyMessageRequestHeader.setStoreHost(this.getStoreHost().toString());
+ InetSocketAddress bornAddress =(InetSocketAddress)(ctx.channel().remoteAddress());
+ replyMessageRequestHeader.setBornHost(bornAddress.getHostName() + ":" + bornAddress.getPort());
Review comment:
Can we use `getHostString()` here to skip reverse lookup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org