[jira] [Comment Edited] (CASSANDRA-6487) Log WARN on large batch sizes

["Lyuben Todorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969501#comment-13969501 ] 

Lyuben Todorov edited comment on CASSANDRA-6487 at 4/15/14 1:05 PM:
--------------------------------------------------------------------

Just noticed that we're actually already using the memory meter for checking batch size when it might get placed into the prepared statement cache, so why not log based on that value (calculated in {{BatchStatement#measureForPreparedCache}}). As for non-prepared batch statements, there we can enforce a limit based on count of statements.


was (Author: lyubent):
Just noticed that we're actually already using the memory meter for checking batch size when it might get placed into the prepared statement cache, so why not log based on that value (calculated in {{BatchStatement#measureForPreparedCache}}). 

> Log WARN on large batch sizes
> -----------------------------
>
>                 Key: CASSANDRA-6487
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6487
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Patrick McFadin
>            Assignee: Lyuben Todorov
>            Priority: Minor
>             Fix For: 2.0.8
>
>         Attachments: 6487_trunk.patch, 6487_trunk_v2.patch, cassandra-2.0-6487.diff
>
>
> Large batches on a coordinator can cause a lot of node stress. I propose adding a WARN log entry if batch sizes go beyond a configurable size. This will give more visibility to operators on something that can happen on the developer side. 
> New yaml setting with 5k default.
> {{# Log WARN on any batch size exceeding this value. 5k by default.}}
> {{# Caution should be taken on increasing the size of this threshold as it can lead to node instability.}}
> {{batch_size_warn_threshold: 5k}}



--
This message was sent by Atlassian JIRA
(v6.2#6252)