You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "zhfeng (via GitHub)" <gi...@apache.org> on 2023/08/11 08:53:29 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #5173: Expand xslt-saxon test coverage
zhfeng opened a new pull request, #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173
Fix #5139
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng merged PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1291297484
##########
integration-test-groups/xml/native/classpath/src/test/java/org/apache/camel/quarkus/component/xml/it/XsltTest.java:
##########
@@ -79,10 +108,26 @@ public void xsltExtensionFunction() {
}
@Test
- public void xsltCustomURIResolver() {
+ @DisabledOnIntegrationTest("xslt-saxon extension function does not be supported in native mode")
Review Comment:
So xslt-saxon does not support extension function in native-mode. Is there an open issue ? Or maybe something by design that can't be changed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #5173: Expand xslt-saxon test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#issuecomment-1674728904
Is XSL params covered ? Like https://camel.apache.org/components/3.21.x/xslt-saxon-component.html#_getting_useable_parameters_into_the_xslt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1291299868
##########
poms/bom/pom.xml:
##########
@@ -6157,16 +6157,16 @@
</exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>com.ibm.mq</groupId>
- <artifactId>com.ibm.mq.jakarta.client</artifactId>
- <version>${ibm.mq.client.version}</version>
- </dependency>
<dependency>
<groupId>com.ibm.icu</groupId>
<artifactId>icu4j</artifactId>
<version>${icu4j.version}</version>
</dependency>
Review Comment:
Are those bom additions ibmmq, dropwizard needed in the context of this pr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1293104970
##########
poms/bom/pom.xml:
##########
@@ -6157,16 +6157,16 @@
</exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>com.ibm.mq</groupId>
- <artifactId>com.ibm.mq.jakarta.client</artifactId>
- <version>${ibm.mq.client.version}</version>
- </dependency>
<dependency>
<groupId>com.ibm.icu</groupId>
<artifactId>icu4j</artifactId>
<version>${icu4j.version}</version>
</dependency>
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1292985372
##########
poms/bom/pom.xml:
##########
@@ -6157,16 +6157,16 @@
</exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>com.ibm.mq</groupId>
- <artifactId>com.ibm.mq.jakarta.client</artifactId>
- <version>${ibm.mq.client.version}</version>
- </dependency>
<dependency>
<groupId>com.ibm.icu</groupId>
<artifactId>icu4j</artifactId>
<version>${icu4j.version}</version>
</dependency>
Review Comment:
I will check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1292978726
##########
integration-test-groups/xml/native/classpath/src/main/java/org/apache/camel/quarkus/component/xml/it/FunctionsConfiguration.java:
##########
@@ -18,6 +18,10 @@
import io.quarkus.runtime.annotations.RegisterForReflection;
-@RegisterForReflection(targets = { org.apache.camel.quarkus.test.support.xslt.Functions.class })
+@RegisterForReflection(targets = {
+ org.apache.camel.quarkus.test.support.xslt.Functions.class,
+ org.apache.camel.quarkus.test.support.xslt.MyExtensionFunction1.class,
+ org.apache.camel.quarkus.test.support.xslt.MyExtensionFunction2.class
+})
Review Comment:
Sorry, I think it can not be supported in `native` mode right now. So it should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1292979607
##########
extensions/mapstruct/runtime/src/main/resources/META-INF/quarkus-extension.yaml:
##########
@@ -25,9 +25,8 @@ name: "Camel MapStruct"
description: "Type Conversion using Mapstruct"
icon-url: "https://camel.apache.org/_/img/logo-d-f21b25ba38.svg"
metadata:
- unlisted: true
guide: "https://camel.apache.org/camel-quarkus/latest/reference/extensions/mapstruct.html"
categories:
- "integration"
status:
Review Comment:
Hmm, it was add by `mvn process-resources -Pformat -N`. So I think it shoud be excluded in this PR. Thanks for pointing it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#issuecomment-1676699799
`xsl:include` is test by `XsltTest::xsltInclude` and it does not support `native` mode because it needs to generate the template dynamically.
`xsl:params` should be covered by `XsltAggregateTest` and yes it does not support `native` mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1293005429
##########
extensions/mapstruct/runtime/src/main/resources/META-INF/quarkus-extension.yaml:
##########
@@ -25,9 +25,8 @@ name: "Camel MapStruct"
description: "Type Conversion using Mapstruct"
icon-url: "https://camel.apache.org/_/img/logo-d-f21b25ba38.svg"
metadata:
- unlisted: true
guide: "https://camel.apache.org/camel-quarkus/latest/reference/extensions/mapstruct.html"
categories:
- "integration"
status:
Review Comment:
Remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1292978868
##########
integration-test-groups/xml/native/classpath/src/test/java/org/apache/camel/quarkus/component/xml/it/XsltTest.java:
##########
@@ -79,10 +108,26 @@ public void xsltExtensionFunction() {
}
@Test
- public void xsltCustomURIResolver() {
+ @DisabledOnIntegrationTest("xslt-saxon extension function does not be supported in native mode")
Review Comment:
I will create an issue later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1291291040
##########
integration-test-groups/xml/native/classpath/src/main/java/org/apache/camel/quarkus/component/xml/it/FunctionsConfiguration.java:
##########
@@ -18,6 +18,10 @@
import io.quarkus.runtime.annotations.RegisterForReflection;
-@RegisterForReflection(targets = { org.apache.camel.quarkus.test.support.xslt.Functions.class })
+@RegisterForReflection(targets = {
+ org.apache.camel.quarkus.test.support.xslt.Functions.class,
+ org.apache.camel.quarkus.test.support.xslt.MyExtensionFunction1.class,
+ org.apache.camel.quarkus.test.support.xslt.MyExtensionFunction2.class
+})
Review Comment:
Do we doc for this ? Maybe it's https://camel.apache.org/camel-quarkus/3.0.x/reference/extensions/xslt.html#extensions-xslt-configuration-extension-functions-support or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1295513085
##########
integration-test-groups/xml/native/classpath/src/test/java/org/apache/camel/quarkus/component/xml/it/XsltTest.java:
##########
@@ -79,10 +108,26 @@ public void xsltExtensionFunction() {
}
@Test
- public void xsltCustomURIResolver() {
+ @DisabledOnIntegrationTest("xslt-saxon extension function does not be supported in native mode")
Review Comment:
see https://github.com/apache/camel-quarkus/issues/5189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1292982275
##########
integration-test-groups/xml/native/classpath/src/main/java/org/apache/camel/quarkus/component/xml/it/FunctionsConfiguration.java:
##########
@@ -18,6 +18,10 @@
import io.quarkus.runtime.annotations.RegisterForReflection;
-@RegisterForReflection(targets = { org.apache.camel.quarkus.test.support.xslt.Functions.class })
+@RegisterForReflection(targets = {
+ org.apache.camel.quarkus.test.support.xslt.Functions.class,
Review Comment:
Yeah, but currently the `saxon extension function` does not support in `native` mode. It throws some error mesage during at build time if we want to generate an class for the template. Something like
```
2023-08-14 13:18:24,583 ERROR [org.apa.cam.qua.com.xsl.CamelXsltErrorListener] (build-2) The first argument to the non-static Java function 'myExtensionFunction1' is not a valid object reference.: javax.xml.transform.TransformerException: The first argument to the non-static Java function 'myExtensionFunction1' is not a valid object reference.
at org.apache.xalan.xsltc.trax.TransformerFactoryImpl.passErrorsToListener(TransformerFactoryImpl.java:661)
at org.apache.xalan.xsltc.trax.TransformerFactoryImpl.newTemplates(TransformerFactoryImpl.java:836)
at org.apache.camel.quarkus.support.xalan.XalanTransformerFactory.newTemplates(XalanTransformerFactory.java:70)
at org.apache.camel.quarkus.component.xslt.deployment.XsltProcessor.xsltResources(XsltProcessor.java:117)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:864)
at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:833)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
2023-08-14 13:18:24,586 ERROR [org.apa.cam.qua.com.xsl.CamelXsltErrorListener] (build-2) The first argument to the non-static Java function 'myExtensionFunction2' is not a valid object reference.: javax.xml.transform.TransformerException: The first argument to the non-static Java function 'myExtensionFunction2' is not a valid object reference.
at org.apache.xalan.xsltc.trax.TransformerFactoryImpl.passErrorsToListener(TransformerFactoryImpl.java:661)
at org.apache.xalan.xsltc.trax.TransformerFactoryImpl.newTemplates(TransformerFactoryImpl.java:836)
at org.apache.camel.quarkus.support.xalan.XalanTransformerFactory.newTemplates(XalanTransformerFactory.java:70)
at org.apache.camel.quarkus.component.xslt.deployment.XsltProcessor.xsltResources(XsltProcessor.java:117)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:864)
at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:833)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
2023-08-14 13:18:24,586 ERROR [org.apa.cam.qua.com.xsl.CamelXsltErrorListener] (build-2) The first argument to the non-static Java function 'myExtensionFunction2' is not a valid object reference.: javax.xml.transform.TransformerException: The first argument to the non-static Java function 'myExtensionFunction2' is not a valid object reference.
at org.apache.xalan.xsltc.trax.TransformerFactoryImpl.passErrorsToListener(TransformerFactoryImpl.java:661)
at org.apache.xalan.xsltc.trax.TransformerFactoryImpl.newTemplates(TransformerFactoryImpl.java:836)
at org.apache.camel.quarkus.support.xalan.XalanTransformerFactory.newTemplates(XalanTransformerFactory.java:70)
at org.apache.camel.quarkus.component.xslt.deployment.XsltProcessor.xsltResources(XsltProcessor.java:117)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:864)
at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:833)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
2023-08-14 13:18:24,587 ERROR [org.apa.cam.qua.com.xsl.CamelXsltErrorListener] (build-2) Could not compile stylesheet: javax.xml.transform.TransformerConfigurationException: Could not compile stylesheet
at org.apache.xalan.xsltc.trax.TransformerFactoryImpl.newTemplates(TransformerFactoryImpl.java:832)
at org.apache.camel.quarkus.support.xalan.XalanTransformerFactory.newTemplates(XalanTransformerFactory.java:70)
at org.apache.camel.quarkus.component.xslt.deployment.XsltProcessor.xsltResources(XsltProcessor.java:117)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:864)
at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:833)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1291288930
##########
integration-test-groups/xml/native/classpath/src/main/java/org/apache/camel/quarkus/component/xml/it/FunctionsConfiguration.java:
##########
@@ -18,6 +18,10 @@
import io.quarkus.runtime.annotations.RegisterForReflection;
-@RegisterForReflection(targets = { org.apache.camel.quarkus.test.support.xslt.Functions.class })
+@RegisterForReflection(targets = {
+ org.apache.camel.quarkus.test.support.xslt.Functions.class,
Review Comment:
Doesn't have to be part of this PR, but I wonder if we can make the UX nicer and register these automatically? E.g find anything that extends `ExtensionFunctionDefinition` or related classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1291289305
##########
extensions/mapstruct/runtime/src/main/resources/META-INF/quarkus-extension.yaml:
##########
@@ -25,9 +25,8 @@ name: "Camel MapStruct"
description: "Type Conversion using Mapstruct"
icon-url: "https://camel.apache.org/_/img/logo-d-f21b25ba38.svg"
metadata:
- unlisted: true
guide: "https://camel.apache.org/camel-quarkus/latest/reference/extensions/mapstruct.html"
categories:
- "integration"
status:
Review Comment:
mapstruct pr has been mixed with xlst saxon one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1291291040
##########
integration-test-groups/xml/native/classpath/src/main/java/org/apache/camel/quarkus/component/xml/it/FunctionsConfiguration.java:
##########
@@ -18,6 +18,10 @@
import io.quarkus.runtime.annotations.RegisterForReflection;
-@RegisterForReflection(targets = { org.apache.camel.quarkus.test.support.xslt.Functions.class })
+@RegisterForReflection(targets = {
+ org.apache.camel.quarkus.test.support.xslt.Functions.class,
+ org.apache.camel.quarkus.test.support.xslt.MyExtensionFunction1.class,
+ org.apache.camel.quarkus.test.support.xslt.MyExtensionFunction2.class
+})
Review Comment:
Do we have doc for this ? Maybe it's https://camel.apache.org/camel-quarkus/3.0.x/reference/extensions/xslt.html#extensions-xslt-configuration-extension-functions-support or similar.
If not supported, maybe it would need to be documented too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #5173: Expand xslt-saxon test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #5173:
URL: https://github.com/apache/camel-quarkus/pull/5173#discussion_r1291291040
##########
integration-test-groups/xml/native/classpath/src/main/java/org/apache/camel/quarkus/component/xml/it/FunctionsConfiguration.java:
##########
@@ -18,6 +18,10 @@
import io.quarkus.runtime.annotations.RegisterForReflection;
-@RegisterForReflection(targets = { org.apache.camel.quarkus.test.support.xslt.Functions.class })
+@RegisterForReflection(targets = {
+ org.apache.camel.quarkus.test.support.xslt.Functions.class,
+ org.apache.camel.quarkus.test.support.xslt.MyExtensionFunction1.class,
+ org.apache.camel.quarkus.test.support.xslt.MyExtensionFunction2.class
+})
Review Comment:
Do we have doc for this ? Maybe it's https://camel.apache.org/camel-quarkus/3.0.x/reference/extensions/xslt.html#extensions-xslt-configuration-extension-functions-support or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org