You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@commons.apache.org by gg...@apache.org on 2020/09/29 15:33:20 UTC
svn commit: r1066218 [23/31] - in
/websites/production/commons/content/proper/commons-pool: ./ apidocs/
apidocs/org/apache/commons/pool2/ apidocs/org/apache/commons/pool2/class-use/
apidocs/org/apache/commons/pool2/impl/ apidocs/org/apache/commons/pool...
Modified: websites/production/commons/content/proper/commons-pool/xref-test/org/apache/commons/pool2/TestObjectPool.html
==============================================================================
--- websites/production/commons/content/proper/commons-pool/xref-test/org/apache/commons/pool2/TestObjectPool.html (original)
+++ websites/production/commons/content/proper/commons-pool/xref-test/org/apache/commons/pool2/TestObjectPool.html Tue Sep 29 15:33:18 2020
@@ -26,424 +26,422 @@
<a class="jxr_linenumber" name="L18" href="#L18">18</a>
<a class="jxr_linenumber" name="L19" href="#L19">19</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.junit.Assert.*;
<a class="jxr_linenumber" name="L20" href="#L20">20</a>
-<a class="jxr_linenumber" name="L21" href="#L21">21</a> <strong class="jxr_keyword">import</strong> org.apache.commons.pool2.ObjectPool;
-<a class="jxr_linenumber" name="L22" href="#L22">22</a> <strong class="jxr_keyword">import</strong> org.apache.commons.pool2.PooledObjectFactory;
-<a class="jxr_linenumber" name="L23" href="#L23">23</a> <strong class="jxr_keyword">import</strong> org.apache.commons.pool2.impl.GenericObjectPool;
-<a class="jxr_linenumber" name="L24" href="#L24">24</a> <strong class="jxr_keyword">import</strong> org.apache.commons.pool2.impl.SoftReferenceObjectPool;
-<a class="jxr_linenumber" name="L25" href="#L25">25</a> <strong class="jxr_keyword">import</strong> org.junit.Test;
-<a class="jxr_linenumber" name="L26" href="#L26">26</a>
-<a class="jxr_linenumber" name="L27" href="#L27">27</a> <strong class="jxr_keyword">import</strong> java.util.List;
-<a class="jxr_linenumber" name="L28" href="#L28">28</a> <strong class="jxr_keyword">import</strong> java.util.ArrayList;
-<a class="jxr_linenumber" name="L29" href="#L29">29</a> <strong class="jxr_keyword">import</strong> java.util.Iterator;
-<a class="jxr_linenumber" name="L30" href="#L30">30</a> <strong class="jxr_keyword">import</strong> java.util.NoSuchElementException;
-<a class="jxr_linenumber" name="L31" href="#L31">31</a>
-<a class="jxr_linenumber" name="L32" href="#L32">32</a> <em class="jxr_javadoccomment">/**</em>
-<a class="jxr_linenumber" name="L33" href="#L33">33</a> <em class="jxr_javadoccomment"> * Abstract test case for {@link ObjectPool} implementations.</em>
-<a class="jxr_linenumber" name="L34" href="#L34">34</a> <em class="jxr_javadoccomment"> */</em>
-<a class="jxr_linenumber" name="L35" href="#L35">35</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">abstract</strong> <strong class="jxr_keyword">class</strong> <a name="TestObjectPool" href="../../../../org/apache/commons/pool2/TestObjectPool.html#TestObjectPool">TestObjectPool</a> {
-<a class="jxr_linenumber" name="L36" href="#L36">36</a>
-<a class="jxr_linenumber" name="L37" href="#L37">37</a> <em class="jxr_javadoccomment">/**</em>
-<a class="jxr_linenumber" name="L38" href="#L38">38</a> <em class="jxr_javadoccomment"> * Create an {@code ObjectPool} with the specified factory.</em>
-<a class="jxr_linenumber" name="L39" href="#L39">39</a> <em class="jxr_javadoccomment"> * The pool should be in a default configuration and conform to the expected</em>
-<a class="jxr_linenumber" name="L40" href="#L40">40</a> <em class="jxr_javadoccomment"> * behaviors described in {@link ObjectPool}.</em>
-<a class="jxr_linenumber" name="L41" href="#L41">41</a> <em class="jxr_javadoccomment"> * Generally speaking there should be no limits on the various object counts.</em>
+<a class="jxr_linenumber" name="L21" href="#L21">21</a> <strong class="jxr_keyword">import</strong> org.apache.commons.pool2.impl.GenericObjectPool;
+<a class="jxr_linenumber" name="L22" href="#L22">22</a> <strong class="jxr_keyword">import</strong> org.apache.commons.pool2.impl.SoftReferenceObjectPool;
+<a class="jxr_linenumber" name="L23" href="#L23">23</a> <strong class="jxr_keyword">import</strong> org.junit.Test;
+<a class="jxr_linenumber" name="L24" href="#L24">24</a>
+<a class="jxr_linenumber" name="L25" href="#L25">25</a> <strong class="jxr_keyword">import</strong> java.util.List;
+<a class="jxr_linenumber" name="L26" href="#L26">26</a> <strong class="jxr_keyword">import</strong> java.util.ArrayList;
+<a class="jxr_linenumber" name="L27" href="#L27">27</a> <strong class="jxr_keyword">import</strong> java.util.Iterator;
+<a class="jxr_linenumber" name="L28" href="#L28">28</a> <strong class="jxr_keyword">import</strong> java.util.NoSuchElementException;
+<a class="jxr_linenumber" name="L29" href="#L29">29</a>
+<a class="jxr_linenumber" name="L30" href="#L30">30</a> <em class="jxr_javadoccomment">/**</em>
+<a class="jxr_linenumber" name="L31" href="#L31">31</a> <em class="jxr_javadoccomment"> * Abstract test case for {@link ObjectPool} implementations.</em>
+<a class="jxr_linenumber" name="L32" href="#L32">32</a> <em class="jxr_javadoccomment"> */</em>
+<a class="jxr_linenumber" name="L33" href="#L33">33</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">abstract</strong> <strong class="jxr_keyword">class</strong> <a name="TestObjectPool" href="../../../../org/apache/commons/pool2/TestObjectPool.html#TestObjectPool">TestObjectPool</a> {
+<a class="jxr_linenumber" name="L34" href="#L34">34</a>
+<a class="jxr_linenumber" name="L35" href="#L35">35</a> <em class="jxr_javadoccomment">/**</em>
+<a class="jxr_linenumber" name="L36" href="#L36">36</a> <em class="jxr_javadoccomment"> * Create an {@code ObjectPool} with the specified factory.</em>
+<a class="jxr_linenumber" name="L37" href="#L37">37</a> <em class="jxr_javadoccomment"> * The pool should be in a default configuration and conform to the expected</em>
+<a class="jxr_linenumber" name="L38" href="#L38">38</a> <em class="jxr_javadoccomment"> * behaviors described in {@link ObjectPool}.</em>
+<a class="jxr_linenumber" name="L39" href="#L39">39</a> <em class="jxr_javadoccomment"> * Generally speaking there should be no limits on the various object counts.</em>
+<a class="jxr_linenumber" name="L40" href="#L40">40</a> <em class="jxr_javadoccomment"> *</em>
+<a class="jxr_linenumber" name="L41" href="#L41">41</a> <em class="jxr_javadoccomment"> * @param factory The factory to be used by the object pool</em>
<a class="jxr_linenumber" name="L42" href="#L42">42</a> <em class="jxr_javadoccomment"> *</em>
-<a class="jxr_linenumber" name="L43" href="#L43">43</a> <em class="jxr_javadoccomment"> * @param factory The factory to be used by the object pool</em>
+<a class="jxr_linenumber" name="L43" href="#L43">43</a> <em class="jxr_javadoccomment"> * @return the newly created empty pool</em>
<a class="jxr_linenumber" name="L44" href="#L44">44</a> <em class="jxr_javadoccomment"> *</em>
-<a class="jxr_linenumber" name="L45" href="#L45">45</a> <em class="jxr_javadoccomment"> * @return the newly created empty pool</em>
-<a class="jxr_linenumber" name="L46" href="#L46">46</a> <em class="jxr_javadoccomment"> *</em>
-<a class="jxr_linenumber" name="L47" href="#L47">47</a> <em class="jxr_javadoccomment"> * @throws UnsupportedOperationException if the pool being tested does not</em>
-<a class="jxr_linenumber" name="L48" href="#L48">48</a> <em class="jxr_javadoccomment"> * follow pool contracts.</em>
-<a class="jxr_linenumber" name="L49" href="#L49">49</a> <em class="jxr_javadoccomment"> */</em>
-<a class="jxr_linenumber" name="L50" href="#L50">50</a> <strong class="jxr_keyword">protected</strong> <strong class="jxr_keyword">abstract</strong> ObjectPool<Object> makeEmptyPool(PooledObjectFactory<Object> factory) <strong class="jxr_keyword">throws</strong> UnsupportedOperationException;
-<a class="jxr_linenumber" name="L51" href="#L51">51</a>
-<a class="jxr_linenumber" name="L52" href="#L52">52</a> @Test
-<a class="jxr_linenumber" name="L53" href="#L53">53</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testClosedPoolBehavior() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="L54" href="#L54">54</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
-<a class="jxr_linenumber" name="L55" href="#L55">55</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L56" href="#L56">56</a> pool = makeEmptyPool(<strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>());
-<a class="jxr_linenumber" name="L57" href="#L57">57</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
-<a class="jxr_linenumber" name="L58" href="#L58">58</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
-<a class="jxr_linenumber" name="L59" href="#L59">59</a> }
-<a class="jxr_linenumber" name="L60" href="#L60">60</a> <strong class="jxr_keyword">final</strong> Object o1 = pool.borrowObject();
-<a class="jxr_linenumber" name="L61" href="#L61">61</a> <strong class="jxr_keyword">final</strong> Object o2 = pool.borrowObject();
+<a class="jxr_linenumber" name="L45" href="#L45">45</a> <em class="jxr_javadoccomment"> * @throws UnsupportedOperationException if the pool being tested does not</em>
+<a class="jxr_linenumber" name="L46" href="#L46">46</a> <em class="jxr_javadoccomment"> * follow pool contracts.</em>
+<a class="jxr_linenumber" name="L47" href="#L47">47</a> <em class="jxr_javadoccomment"> */</em>
+<a class="jxr_linenumber" name="L48" href="#L48">48</a> <strong class="jxr_keyword">protected</strong> <strong class="jxr_keyword">abstract</strong> ObjectPool<Object> makeEmptyPool(PooledObjectFactory<Object> factory) <strong class="jxr_keyword">throws</strong> UnsupportedOperationException;
+<a class="jxr_linenumber" name="L49" href="#L49">49</a>
+<a class="jxr_linenumber" name="L50" href="#L50">50</a> @Test
+<a class="jxr_linenumber" name="L51" href="#L51">51</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testClosedPoolBehavior() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="L52" href="#L52">52</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
+<a class="jxr_linenumber" name="L53" href="#L53">53</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L54" href="#L54">54</a> pool = makeEmptyPool(<strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>());
+<a class="jxr_linenumber" name="L55" href="#L55">55</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
+<a class="jxr_linenumber" name="L56" href="#L56">56</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
+<a class="jxr_linenumber" name="L57" href="#L57">57</a> }
+<a class="jxr_linenumber" name="L58" href="#L58">58</a> <strong class="jxr_keyword">final</strong> Object o1 = pool.borrowObject();
+<a class="jxr_linenumber" name="L59" href="#L59">59</a> <strong class="jxr_keyword">final</strong> Object o2 = pool.borrowObject();
+<a class="jxr_linenumber" name="L60" href="#L60">60</a>
+<a class="jxr_linenumber" name="L61" href="#L61">61</a> pool.close();
<a class="jxr_linenumber" name="L62" href="#L62">62</a>
-<a class="jxr_linenumber" name="L63" href="#L63">63</a> pool.close();
-<a class="jxr_linenumber" name="L64" href="#L64">64</a>
-<a class="jxr_linenumber" name="L65" href="#L65">65</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L66" href="#L66">66</a> pool.addObject();
-<a class="jxr_linenumber" name="L67" href="#L67">67</a> fail(<span class="jxr_string">"A closed pool must throw an IllegalStateException when addObject is called."</span>);
-<a class="jxr_linenumber" name="L68" href="#L68">68</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> IllegalStateException ise) {
-<a class="jxr_linenumber" name="L69" href="#L69">69</a> <em class="jxr_comment">// expected</em>
-<a class="jxr_linenumber" name="L70" href="#L70">70</a> }
-<a class="jxr_linenumber" name="L71" href="#L71">71</a>
-<a class="jxr_linenumber" name="L72" href="#L72">72</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L73" href="#L73">73</a> pool.borrowObject();
-<a class="jxr_linenumber" name="L74" href="#L74">74</a> fail(<span class="jxr_string">"A closed pool must throw an IllegalStateException when borrowObject is called."</span>);
-<a class="jxr_linenumber" name="L75" href="#L75">75</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> IllegalStateException ise) {
-<a class="jxr_linenumber" name="L76" href="#L76">76</a> <em class="jxr_comment">// expected</em>
-<a class="jxr_linenumber" name="L77" href="#L77">77</a> }
-<a class="jxr_linenumber" name="L78" href="#L78">78</a>
-<a class="jxr_linenumber" name="L79" href="#L79">79</a> <em class="jxr_comment">// The following should not throw exceptions just because the pool is closed.</em>
-<a class="jxr_linenumber" name="L80" href="#L80">80</a> <strong class="jxr_keyword">if</strong> (pool.getNumIdle() >= 0) {
-<a class="jxr_linenumber" name="L81" href="#L81">81</a> assertEquals(<span class="jxr_string">"A closed pool shouldn't have any idle objects."</span>, 0, pool.getNumIdle());
-<a class="jxr_linenumber" name="L82" href="#L82">82</a> }
-<a class="jxr_linenumber" name="L83" href="#L83">83</a> <strong class="jxr_keyword">if</strong> (pool.getNumActive() >= 0) {
-<a class="jxr_linenumber" name="L84" href="#L84">84</a> assertEquals(<span class="jxr_string">"A closed pool should still keep count of active objects."</span>, 2, pool.getNumActive());
-<a class="jxr_linenumber" name="L85" href="#L85">85</a> }
-<a class="jxr_linenumber" name="L86" href="#L86">86</a> pool.returnObject(o1);
-<a class="jxr_linenumber" name="L87" href="#L87">87</a> <strong class="jxr_keyword">if</strong> (pool.getNumIdle() >= 0) {
-<a class="jxr_linenumber" name="L88" href="#L88">88</a> assertEquals(<span class="jxr_string">"returnObject should not add items back into the idle object pool for a closed pool."</span>, 0, pool.getNumIdle());
-<a class="jxr_linenumber" name="L89" href="#L89">89</a> }
-<a class="jxr_linenumber" name="L90" href="#L90">90</a> <strong class="jxr_keyword">if</strong> (pool.getNumActive() >= 0) {
-<a class="jxr_linenumber" name="L91" href="#L91">91</a> assertEquals(<span class="jxr_string">"A closed pool should still keep count of active objects."</span>, 1, pool.getNumActive());
-<a class="jxr_linenumber" name="L92" href="#L92">92</a> }
-<a class="jxr_linenumber" name="L93" href="#L93">93</a> pool.invalidateObject(o2);
-<a class="jxr_linenumber" name="L94" href="#L94">94</a> <strong class="jxr_keyword">if</strong> (pool.getNumIdle() >= 0) {
-<a class="jxr_linenumber" name="L95" href="#L95">95</a> assertEquals(<span class="jxr_string">"invalidateObject must not add items back into the idle object pool."</span>, 0, pool.getNumIdle());
-<a class="jxr_linenumber" name="L96" href="#L96">96</a> }
-<a class="jxr_linenumber" name="L97" href="#L97">97</a> <strong class="jxr_keyword">if</strong> (pool.getNumActive() >= 0) {
-<a class="jxr_linenumber" name="L98" href="#L98">98</a> assertEquals(<span class="jxr_string">"A closed pool should still keep count of active objects."</span>, 0, pool.getNumActive());
-<a class="jxr_linenumber" name="L99" href="#L99">99</a> }
-<a class="jxr_linenumber" name="L100" href="#L100">100</a> pool.clear();
-<a class="jxr_linenumber" name="L101" href="#L101">101</a> pool.close();
-<a class="jxr_linenumber" name="L102" href="#L102">102</a> }
-<a class="jxr_linenumber" name="L103" href="#L103">103</a>
-<a class="jxr_linenumber" name="L104" href="#L104">104</a> <em class="jxr_comment">// Deliberate choice to create a new object in case future unit tests check</em>
-<a class="jxr_linenumber" name="L105" href="#L105">105</a> <em class="jxr_comment">// for a specific object.</em>
-<a class="jxr_linenumber" name="L106" href="#L106">106</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">final</strong> Integer ZERO = <strong class="jxr_keyword">new</strong> Integer(0);
-<a class="jxr_linenumber" name="L107" href="#L107">107</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">final</strong> Integer ONE = <strong class="jxr_keyword">new</strong> Integer(1);
-<a class="jxr_linenumber" name="L108" href="#L108">108</a>
-<a class="jxr_linenumber" name="L109" href="#L109">109</a> @Test
-<a class="jxr_linenumber" name="L110" href="#L110">110</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPOFAddObjectUsage() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="L111" href="#L111">111</a> <strong class="jxr_keyword">final</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool<a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>ry.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a> factory = <strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>();
-<a class="jxr_linenumber" name="L112" href="#L112">112</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
-<a class="jxr_linenumber" name="L113" href="#L113">113</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L114" href="#L114">114</a> pool = makeEmptyPool(factory);
-<a class="jxr_linenumber" name="L115" href="#L115">115</a> } <strong class="jxr_keyword">catch</strong>(<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
-<a class="jxr_linenumber" name="L116" href="#L116">116</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
-<a class="jxr_linenumber" name="L117" href="#L117">117</a> }
-<a class="jxr_linenumber" name="L118" href="#L118">118</a> <strong class="jxr_keyword">final</strong> List<MethodCall> expectedMethods = <strong class="jxr_keyword">new</strong> ArrayList<>();
-<a class="jxr_linenumber" name="L119" href="#L119">119</a>
-<a class="jxr_linenumber" name="L120" href="#L120">120</a> assertEquals(0, pool.getNumActive());
-<a class="jxr_linenumber" name="L121" href="#L121">121</a> assertEquals(0, pool.getNumIdle());
-<a class="jxr_linenumber" name="L122" href="#L122">122</a> <em class="jxr_comment">// addObject should make a new object, passivate it and put it in the pool</em>
-<a class="jxr_linenumber" name="L123" href="#L123">123</a> pool.addObject();
-<a class="jxr_linenumber" name="L124" href="#L124">124</a> assertEquals(0, pool.getNumActive());
-<a class="jxr_linenumber" name="L125" href="#L125">125</a> assertEquals(1, pool.getNumIdle());
-<a class="jxr_linenumber" name="L126" href="#L126">126</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>).returned(ZERO));
-<a class="jxr_linenumber" name="L127" href="#L127">127</a> <em class="jxr_comment">// StackObjectPool, SoftReferenceObjectPool also validate on add</em>
-<a class="jxr_linenumber" name="L128" href="#L128">128</a> <strong class="jxr_keyword">if</strong> (pool instanceof SoftReferenceObjectPool) {
-<a class="jxr_linenumber" name="L129" href="#L129">129</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(
-<a class="jxr_linenumber" name="L130" href="#L130">130</a> <span class="jxr_string">"validateObject"</span>, ZERO).returned(Boolean.TRUE));
-<a class="jxr_linenumber" name="L131" href="#L131">131</a> }
-<a class="jxr_linenumber" name="L132" href="#L132">132</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"passivateObject"</span>, ZERO));
-<a class="jxr_linenumber" name="L133" href="#L133">133</a> assertEquals(expectedMethods, factory.getMethodCalls());
-<a class="jxr_linenumber" name="L134" href="#L134">134</a>
-<a class="jxr_linenumber" name="L135" href="#L135">135</a> <em class="jxr_comment">//// Test exception handling of addObject</em>
-<a class="jxr_linenumber" name="L136" href="#L136">136</a> reset(pool, factory, expectedMethods);
-<a class="jxr_linenumber" name="L137" href="#L137">137</a>
-<a class="jxr_linenumber" name="L138" href="#L138">138</a> <em class="jxr_comment">// makeObject Exceptions should be propagated to client code from addObject</em>
-<a class="jxr_linenumber" name="L139" href="#L139">139</a> factory.setMakeObjectFail(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L140" href="#L140">140</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L141" href="#L141">141</a> pool.addObject();
-<a class="jxr_linenumber" name="L142" href="#L142">142</a> fail(<span class="jxr_string">"Expected addObject to propagate makeObject exception."</span>);
-<a class="jxr_linenumber" name="L143" href="#L143">143</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> <a name="PrivateException" href="../../../../org/apache/commons/pool2/PrivateException.html#PrivateException">PrivateException</a> pe) {
-<a class="jxr_linenumber" name="L144" href="#L144">144</a> <em class="jxr_comment">// expected</em>
-<a class="jxr_linenumber" name="L145" href="#L145">145</a> }
-<a class="jxr_linenumber" name="L146" href="#L146">146</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>));
-<a class="jxr_linenumber" name="L147" href="#L147">147</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L63" href="#L63">63</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L64" href="#L64">64</a> pool.addObject();
+<a class="jxr_linenumber" name="L65" href="#L65">65</a> fail(<span class="jxr_string">"A closed pool must throw an IllegalStateException when addObject is called."</span>);
+<a class="jxr_linenumber" name="L66" href="#L66">66</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> IllegalStateException ise) {
+<a class="jxr_linenumber" name="L67" href="#L67">67</a> <em class="jxr_comment">// expected</em>
+<a class="jxr_linenumber" name="L68" href="#L68">68</a> }
+<a class="jxr_linenumber" name="L69" href="#L69">69</a>
+<a class="jxr_linenumber" name="L70" href="#L70">70</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L71" href="#L71">71</a> pool.borrowObject();
+<a class="jxr_linenumber" name="L72" href="#L72">72</a> fail(<span class="jxr_string">"A closed pool must throw an IllegalStateException when borrowObject is called."</span>);
+<a class="jxr_linenumber" name="L73" href="#L73">73</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> IllegalStateException ise) {
+<a class="jxr_linenumber" name="L74" href="#L74">74</a> <em class="jxr_comment">// expected</em>
+<a class="jxr_linenumber" name="L75" href="#L75">75</a> }
+<a class="jxr_linenumber" name="L76" href="#L76">76</a>
+<a class="jxr_linenumber" name="L77" href="#L77">77</a> <em class="jxr_comment">// The following should not throw exceptions just because the pool is closed.</em>
+<a class="jxr_linenumber" name="L78" href="#L78">78</a> <strong class="jxr_keyword">if</strong> (pool.getNumIdle() >= 0) {
+<a class="jxr_linenumber" name="L79" href="#L79">79</a> assertEquals(<span class="jxr_string">"A closed pool shouldn't have any idle objects."</span>, 0, pool.getNumIdle());
+<a class="jxr_linenumber" name="L80" href="#L80">80</a> }
+<a class="jxr_linenumber" name="L81" href="#L81">81</a> <strong class="jxr_keyword">if</strong> (pool.getNumActive() >= 0) {
+<a class="jxr_linenumber" name="L82" href="#L82">82</a> assertEquals(<span class="jxr_string">"A closed pool should still keep count of active objects."</span>, 2, pool.getNumActive());
+<a class="jxr_linenumber" name="L83" href="#L83">83</a> }
+<a class="jxr_linenumber" name="L84" href="#L84">84</a> pool.returnObject(o1);
+<a class="jxr_linenumber" name="L85" href="#L85">85</a> <strong class="jxr_keyword">if</strong> (pool.getNumIdle() >= 0) {
+<a class="jxr_linenumber" name="L86" href="#L86">86</a> assertEquals(<span class="jxr_string">"returnObject should not add items back into the idle object pool for a closed pool."</span>, 0, pool.getNumIdle());
+<a class="jxr_linenumber" name="L87" href="#L87">87</a> }
+<a class="jxr_linenumber" name="L88" href="#L88">88</a> <strong class="jxr_keyword">if</strong> (pool.getNumActive() >= 0) {
+<a class="jxr_linenumber" name="L89" href="#L89">89</a> assertEquals(<span class="jxr_string">"A closed pool should still keep count of active objects."</span>, 1, pool.getNumActive());
+<a class="jxr_linenumber" name="L90" href="#L90">90</a> }
+<a class="jxr_linenumber" name="L91" href="#L91">91</a> pool.invalidateObject(o2);
+<a class="jxr_linenumber" name="L92" href="#L92">92</a> <strong class="jxr_keyword">if</strong> (pool.getNumIdle() >= 0) {
+<a class="jxr_linenumber" name="L93" href="#L93">93</a> assertEquals(<span class="jxr_string">"invalidateObject must not add items back into the idle object pool."</span>, 0, pool.getNumIdle());
+<a class="jxr_linenumber" name="L94" href="#L94">94</a> }
+<a class="jxr_linenumber" name="L95" href="#L95">95</a> <strong class="jxr_keyword">if</strong> (pool.getNumActive() >= 0) {
+<a class="jxr_linenumber" name="L96" href="#L96">96</a> assertEquals(<span class="jxr_string">"A closed pool should still keep count of active objects."</span>, 0, pool.getNumActive());
+<a class="jxr_linenumber" name="L97" href="#L97">97</a> }
+<a class="jxr_linenumber" name="L98" href="#L98">98</a> pool.clear();
+<a class="jxr_linenumber" name="L99" href="#L99">99</a> pool.close();
+<a class="jxr_linenumber" name="L100" href="#L100">100</a> }
+<a class="jxr_linenumber" name="L101" href="#L101">101</a>
+<a class="jxr_linenumber" name="L102" href="#L102">102</a> <em class="jxr_comment">// Deliberate choice to create a new object in case future unit tests check</em>
+<a class="jxr_linenumber" name="L103" href="#L103">103</a> <em class="jxr_comment">// for a specific object.</em>
+<a class="jxr_linenumber" name="L104" href="#L104">104</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">final</strong> Integer ZERO = <strong class="jxr_keyword">new</strong> Integer(0);
+<a class="jxr_linenumber" name="L105" href="#L105">105</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">final</strong> Integer ONE = <strong class="jxr_keyword">new</strong> Integer(1);
+<a class="jxr_linenumber" name="L106" href="#L106">106</a>
+<a class="jxr_linenumber" name="L107" href="#L107">107</a> @Test
+<a class="jxr_linenumber" name="L108" href="#L108">108</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPOFAddObjectUsage() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="L109" href="#L109">109</a> <strong class="jxr_keyword">final</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool<a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>ry.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a> factory = <strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>();
+<a class="jxr_linenumber" name="L110" href="#L110">110</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
+<a class="jxr_linenumber" name="L111" href="#L111">111</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L112" href="#L112">112</a> pool = makeEmptyPool(factory);
+<a class="jxr_linenumber" name="L113" href="#L113">113</a> } <strong class="jxr_keyword">catch</strong>(<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
+<a class="jxr_linenumber" name="L114" href="#L114">114</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
+<a class="jxr_linenumber" name="L115" href="#L115">115</a> }
+<a class="jxr_linenumber" name="L116" href="#L116">116</a> <strong class="jxr_keyword">final</strong> List<MethodCall> expectedMethods = <strong class="jxr_keyword">new</strong> ArrayList<>();
+<a class="jxr_linenumber" name="L117" href="#L117">117</a>
+<a class="jxr_linenumber" name="L118" href="#L118">118</a> assertEquals(0, pool.getNumActive());
+<a class="jxr_linenumber" name="L119" href="#L119">119</a> assertEquals(0, pool.getNumIdle());
+<a class="jxr_linenumber" name="L120" href="#L120">120</a> <em class="jxr_comment">// addObject should make a new object, passivate it and put it in the pool</em>
+<a class="jxr_linenumber" name="L121" href="#L121">121</a> pool.addObject();
+<a class="jxr_linenumber" name="L122" href="#L122">122</a> assertEquals(0, pool.getNumActive());
+<a class="jxr_linenumber" name="L123" href="#L123">123</a> assertEquals(1, pool.getNumIdle());
+<a class="jxr_linenumber" name="L124" href="#L124">124</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>).returned(ZERO));
+<a class="jxr_linenumber" name="L125" href="#L125">125</a> <em class="jxr_comment">// StackObjectPool, SoftReferenceObjectPool also validate on add</em>
+<a class="jxr_linenumber" name="L126" href="#L126">126</a> <strong class="jxr_keyword">if</strong> (pool instanceof SoftReferenceObjectPool) {
+<a class="jxr_linenumber" name="L127" href="#L127">127</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(
+<a class="jxr_linenumber" name="L128" href="#L128">128</a> <span class="jxr_string">"validateObject"</span>, ZERO).returned(Boolean.TRUE));
+<a class="jxr_linenumber" name="L129" href="#L129">129</a> }
+<a class="jxr_linenumber" name="L130" href="#L130">130</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"passivateObject"</span>, ZERO));
+<a class="jxr_linenumber" name="L131" href="#L131">131</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L132" href="#L132">132</a>
+<a class="jxr_linenumber" name="L133" href="#L133">133</a> <em class="jxr_comment">//// Test exception handling of addObject</em>
+<a class="jxr_linenumber" name="L134" href="#L134">134</a> reset(pool, factory, expectedMethods);
+<a class="jxr_linenumber" name="L135" href="#L135">135</a>
+<a class="jxr_linenumber" name="L136" href="#L136">136</a> <em class="jxr_comment">// makeObject Exceptions should be propagated to client code from addObject</em>
+<a class="jxr_linenumber" name="L137" href="#L137">137</a> factory.setMakeObjectFail(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L138" href="#L138">138</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L139" href="#L139">139</a> pool.addObject();
+<a class="jxr_linenumber" name="L140" href="#L140">140</a> fail(<span class="jxr_string">"Expected addObject to propagate makeObject exception."</span>);
+<a class="jxr_linenumber" name="L141" href="#L141">141</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> <a name="PrivateException" href="../../../../org/apache/commons/pool2/PrivateException.html#PrivateException">PrivateException</a> pe) {
+<a class="jxr_linenumber" name="L142" href="#L142">142</a> <em class="jxr_comment">// expected</em>
+<a class="jxr_linenumber" name="L143" href="#L143">143</a> }
+<a class="jxr_linenumber" name="L144" href="#L144">144</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>));
+<a class="jxr_linenumber" name="L145" href="#L145">145</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L146" href="#L146">146</a>
+<a class="jxr_linenumber" name="L147" href="#L147">147</a> clear(factory, expectedMethods);
<a class="jxr_linenumber" name="L148" href="#L148">148</a>
-<a class="jxr_linenumber" name="L149" href="#L149">149</a> clear(factory, expectedMethods);
-<a class="jxr_linenumber" name="L150" href="#L150">150</a>
-<a class="jxr_linenumber" name="L151" href="#L151">151</a> <em class="jxr_comment">// passivateObject Exceptions should be propagated to client code from addObject</em>
-<a class="jxr_linenumber" name="L152" href="#L152">152</a> factory.setMakeObjectFail(false);
-<a class="jxr_linenumber" name="L153" href="#L153">153</a> factory.setPassivateObjectFail(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L154" href="#L154">154</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L155" href="#L155">155</a> pool.addObject();
-<a class="jxr_linenumber" name="L156" href="#L156">156</a> fail(<span class="jxr_string">"Expected addObject to propagate passivateObject exception."</span>);
-<a class="jxr_linenumber" name="L157" href="#L157">157</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> <a name="PrivateException" href="../../../../org/apache/commons/pool2/PrivateException.html#PrivateException">PrivateException</a> pe) {
-<a class="jxr_linenumber" name="L158" href="#L158">158</a> <em class="jxr_comment">// expected</em>
-<a class="jxr_linenumber" name="L159" href="#L159">159</a> }
-<a class="jxr_linenumber" name="L160" href="#L160">160</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>).returned(ONE));
-<a class="jxr_linenumber" name="L161" href="#L161">161</a> <em class="jxr_comment">// StackObjectPool, SofReferenceObjectPool also validate on add</em>
-<a class="jxr_linenumber" name="L162" href="#L162">162</a> <strong class="jxr_keyword">if</strong> (pool instanceof SoftReferenceObjectPool) {
-<a class="jxr_linenumber" name="L163" href="#L163">163</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(
-<a class="jxr_linenumber" name="L164" href="#L164">164</a> <span class="jxr_string">"validateObject"</span>, ONE).returned(Boolean.TRUE));
-<a class="jxr_linenumber" name="L165" href="#L165">165</a> }
-<a class="jxr_linenumber" name="L166" href="#L166">166</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"passivateObject"</span>, ONE));
-<a class="jxr_linenumber" name="L167" href="#L167">167</a> assertEquals(expectedMethods, factory.getMethodCalls());
-<a class="jxr_linenumber" name="L168" href="#L168">168</a> pool.close();
-<a class="jxr_linenumber" name="L169" href="#L169">169</a> }
-<a class="jxr_linenumber" name="L170" href="#L170">170</a>
-<a class="jxr_linenumber" name="L171" href="#L171">171</a> @Test
-<a class="jxr_linenumber" name="L172" href="#L172">172</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPOFBorrowObjectUsages() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="L173" href="#L173">173</a> <strong class="jxr_keyword">final</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool<a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>ry.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a> factory = <strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>();
-<a class="jxr_linenumber" name="L174" href="#L174">174</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
-<a class="jxr_linenumber" name="L175" href="#L175">175</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L176" href="#L176">176</a> pool = makeEmptyPool(factory);
-<a class="jxr_linenumber" name="L177" href="#L177">177</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
-<a class="jxr_linenumber" name="L178" href="#L178">178</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
-<a class="jxr_linenumber" name="L179" href="#L179">179</a> }
-<a class="jxr_linenumber" name="L180" href="#L180">180</a> <strong class="jxr_keyword">if</strong> (pool instanceof GenericObjectPool) {
-<a class="jxr_linenumber" name="L181" href="#L181">181</a> ((GenericObjectPool<Object>) pool).setTestOnBorrow(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L182" href="#L182">182</a> }
-<a class="jxr_linenumber" name="L183" href="#L183">183</a> <strong class="jxr_keyword">final</strong> List<MethodCall> expectedMethods = <strong class="jxr_keyword">new</strong> ArrayList<>();
-<a class="jxr_linenumber" name="L184" href="#L184">184</a> Object obj;
+<a class="jxr_linenumber" name="L149" href="#L149">149</a> <em class="jxr_comment">// passivateObject Exceptions should be propagated to client code from addObject</em>
+<a class="jxr_linenumber" name="L150" href="#L150">150</a> factory.setMakeObjectFail(false);
+<a class="jxr_linenumber" name="L151" href="#L151">151</a> factory.setPassivateObjectFail(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L152" href="#L152">152</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L153" href="#L153">153</a> pool.addObject();
+<a class="jxr_linenumber" name="L154" href="#L154">154</a> fail(<span class="jxr_string">"Expected addObject to propagate passivateObject exception."</span>);
+<a class="jxr_linenumber" name="L155" href="#L155">155</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> <a name="PrivateException" href="../../../../org/apache/commons/pool2/PrivateException.html#PrivateException">PrivateException</a> pe) {
+<a class="jxr_linenumber" name="L156" href="#L156">156</a> <em class="jxr_comment">// expected</em>
+<a class="jxr_linenumber" name="L157" href="#L157">157</a> }
+<a class="jxr_linenumber" name="L158" href="#L158">158</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>).returned(ONE));
+<a class="jxr_linenumber" name="L159" href="#L159">159</a> <em class="jxr_comment">// StackObjectPool, SofReferenceObjectPool also validate on add</em>
+<a class="jxr_linenumber" name="L160" href="#L160">160</a> <strong class="jxr_keyword">if</strong> (pool instanceof SoftReferenceObjectPool) {
+<a class="jxr_linenumber" name="L161" href="#L161">161</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(
+<a class="jxr_linenumber" name="L162" href="#L162">162</a> <span class="jxr_string">"validateObject"</span>, ONE).returned(Boolean.TRUE));
+<a class="jxr_linenumber" name="L163" href="#L163">163</a> }
+<a class="jxr_linenumber" name="L164" href="#L164">164</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"passivateObject"</span>, ONE));
+<a class="jxr_linenumber" name="L165" href="#L165">165</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L166" href="#L166">166</a> pool.close();
+<a class="jxr_linenumber" name="L167" href="#L167">167</a> }
+<a class="jxr_linenumber" name="L168" href="#L168">168</a>
+<a class="jxr_linenumber" name="L169" href="#L169">169</a> @Test
+<a class="jxr_linenumber" name="L170" href="#L170">170</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPOFBorrowObjectUsages() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="L171" href="#L171">171</a> <strong class="jxr_keyword">final</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool<a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>ry.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a> factory = <strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>();
+<a class="jxr_linenumber" name="L172" href="#L172">172</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
+<a class="jxr_linenumber" name="L173" href="#L173">173</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L174" href="#L174">174</a> pool = makeEmptyPool(factory);
+<a class="jxr_linenumber" name="L175" href="#L175">175</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
+<a class="jxr_linenumber" name="L176" href="#L176">176</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
+<a class="jxr_linenumber" name="L177" href="#L177">177</a> }
+<a class="jxr_linenumber" name="L178" href="#L178">178</a> <strong class="jxr_keyword">if</strong> (pool instanceof GenericObjectPool) {
+<a class="jxr_linenumber" name="L179" href="#L179">179</a> ((GenericObjectPool<Object>) pool).setTestOnBorrow(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L180" href="#L180">180</a> }
+<a class="jxr_linenumber" name="L181" href="#L181">181</a> <strong class="jxr_keyword">final</strong> List<MethodCall> expectedMethods = <strong class="jxr_keyword">new</strong> ArrayList<>();
+<a class="jxr_linenumber" name="L182" href="#L182">182</a> Object obj;
+<a class="jxr_linenumber" name="L183" href="#L183">183</a>
+<a class="jxr_linenumber" name="L184" href="#L184">184</a> <em class="jxr_comment">/// Test correct behavior code paths</em>
<a class="jxr_linenumber" name="L185" href="#L185">185</a>
-<a class="jxr_linenumber" name="L186" href="#L186">186</a> <em class="jxr_comment">/// Test correct behavior code paths</em>
-<a class="jxr_linenumber" name="L187" href="#L187">187</a>
-<a class="jxr_linenumber" name="L188" href="#L188">188</a> <em class="jxr_comment">// existing idle object should be activated and validated</em>
-<a class="jxr_linenumber" name="L189" href="#L189">189</a> pool.addObject();
-<a class="jxr_linenumber" name="L190" href="#L190">190</a> clear(factory, expectedMethods);
-<a class="jxr_linenumber" name="L191" href="#L191">191</a> obj = pool.borrowObject();
-<a class="jxr_linenumber" name="L192" href="#L192">192</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, ZERO));
-<a class="jxr_linenumber" name="L193" href="#L193">193</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"validateObject"</span>, ZERO).returned(Boolean.TRUE));
-<a class="jxr_linenumber" name="L194" href="#L194">194</a> assertEquals(expectedMethods, factory.getMethodCalls());
-<a class="jxr_linenumber" name="L195" href="#L195">195</a> pool.returnObject(obj);
-<a class="jxr_linenumber" name="L196" href="#L196">196</a>
-<a class="jxr_linenumber" name="L197" href="#L197">197</a> <em class="jxr_comment">//// Test exception handling of borrowObject</em>
-<a class="jxr_linenumber" name="L198" href="#L198">198</a> reset(pool, factory, expectedMethods);
-<a class="jxr_linenumber" name="L199" href="#L199">199</a>
-<a class="jxr_linenumber" name="L200" href="#L200">200</a> <em class="jxr_comment">// makeObject Exceptions should be propagated to client code from borrowObject</em>
-<a class="jxr_linenumber" name="L201" href="#L201">201</a> factory.setMakeObjectFail(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L202" href="#L202">202</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L203" href="#L203">203</a> obj = pool.borrowObject();
-<a class="jxr_linenumber" name="L204" href="#L204">204</a> fail(<span class="jxr_string">"Expected borrowObject to propagate makeObject exception."</span>);
-<a class="jxr_linenumber" name="L205" href="#L205">205</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> <a name="PrivateException" href="../../../../org/apache/commons/pool2/PrivateException.html#PrivateException">PrivateException</a> pe) {
-<a class="jxr_linenumber" name="L206" href="#L206">206</a> <em class="jxr_comment">// expected</em>
-<a class="jxr_linenumber" name="L207" href="#L207">207</a> }
-<a class="jxr_linenumber" name="L208" href="#L208">208</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>));
-<a class="jxr_linenumber" name="L209" href="#L209">209</a> assertEquals(expectedMethods, factory.getMethodCalls());
-<a class="jxr_linenumber" name="L210" href="#L210">210</a>
-<a class="jxr_linenumber" name="L211" href="#L211">211</a>
-<a class="jxr_linenumber" name="L212" href="#L212">212</a> <em class="jxr_comment">// when activateObject fails in borrowObject, a new object should be borrowed/created</em>
-<a class="jxr_linenumber" name="L213" href="#L213">213</a> reset(pool, factory, expectedMethods);
-<a class="jxr_linenumber" name="L214" href="#L214">214</a> pool.addObject();
-<a class="jxr_linenumber" name="L215" href="#L215">215</a> clear(factory, expectedMethods);
-<a class="jxr_linenumber" name="L216" href="#L216">216</a>
-<a class="jxr_linenumber" name="L217" href="#L217">217</a> factory.setActivateObjectFail(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L218" href="#L218">218</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, obj));
-<a class="jxr_linenumber" name="L219" href="#L219">219</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L220" href="#L220">220</a> pool.borrowObject();
-<a class="jxr_linenumber" name="L221" href="#L221">221</a> fail(<span class="jxr_string">"Expecting NoSuchElementException"</span>);
-<a class="jxr_linenumber" name="L222" href="#L222">222</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> NoSuchElementException ex) {
-<a class="jxr_linenumber" name="L223" href="#L223">223</a> <em class="jxr_comment">// Expected - newly created object will also fail to activate</em>
-<a class="jxr_linenumber" name="L224" href="#L224">224</a> }
-<a class="jxr_linenumber" name="L225" href="#L225">225</a> <em class="jxr_comment">// Idle object fails activation, new one created, also fails</em>
-<a class="jxr_linenumber" name="L226" href="#L226">226</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>).returned(ONE));
-<a class="jxr_linenumber" name="L227" href="#L227">227</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, ONE));
-<a class="jxr_linenumber" name="L228" href="#L228">228</a> removeDestroyObjectCall(factory.getMethodCalls()); <em class="jxr_comment">// The exact timing of destroyObject is flexible here.</em>
-<a class="jxr_linenumber" name="L229" href="#L229">229</a> assertEquals(expectedMethods, factory.getMethodCalls());
-<a class="jxr_linenumber" name="L230" href="#L230">230</a>
-<a class="jxr_linenumber" name="L231" href="#L231">231</a> <em class="jxr_comment">// when validateObject fails in borrowObject, a new object should be borrowed/created</em>
-<a class="jxr_linenumber" name="L232" href="#L232">232</a> reset(pool, factory, expectedMethods);
-<a class="jxr_linenumber" name="L233" href="#L233">233</a> pool.addObject();
-<a class="jxr_linenumber" name="L234" href="#L234">234</a> clear(factory, expectedMethods);
-<a class="jxr_linenumber" name="L235" href="#L235">235</a>
-<a class="jxr_linenumber" name="L236" href="#L236">236</a> factory.setValidateObjectFail(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L237" href="#L237">237</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, ZERO));
-<a class="jxr_linenumber" name="L238" href="#L238">238</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"validateObject"</span>, ZERO));
-<a class="jxr_linenumber" name="L239" href="#L239">239</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L240" href="#L240">240</a> pool.borrowObject();
-<a class="jxr_linenumber" name="L241" href="#L241">241</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> NoSuchElementException ex) {
-<a class="jxr_linenumber" name="L242" href="#L242">242</a> <em class="jxr_comment">// Expected - newly created object will also fail to validate</em>
-<a class="jxr_linenumber" name="L243" href="#L243">243</a> }
-<a class="jxr_linenumber" name="L244" href="#L244">244</a> <em class="jxr_comment">// Idle object is activated, but fails validation.</em>
-<a class="jxr_linenumber" name="L245" href="#L245">245</a> <em class="jxr_comment">// New instance is created, activated and then fails validation</em>
-<a class="jxr_linenumber" name="L246" href="#L246">246</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>).returned(ONE));
-<a class="jxr_linenumber" name="L247" href="#L247">247</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, ONE));
-<a class="jxr_linenumber" name="L248" href="#L248">248</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"validateObject"</span>, ONE));
-<a class="jxr_linenumber" name="L249" href="#L249">249</a> removeDestroyObjectCall(factory.getMethodCalls()); <em class="jxr_comment">// The exact timing of destroyObject is flexible here.</em>
-<a class="jxr_linenumber" name="L250" href="#L250">250</a> <em class="jxr_comment">// Second activate and validate are missing from expectedMethods</em>
-<a class="jxr_linenumber" name="L251" href="#L251">251</a> assertTrue(factory.getMethodCalls().containsAll(expectedMethods));
-<a class="jxr_linenumber" name="L252" href="#L252">252</a> pool.close();
-<a class="jxr_linenumber" name="L253" href="#L253">253</a> }
-<a class="jxr_linenumber" name="L254" href="#L254">254</a>
-<a class="jxr_linenumber" name="L255" href="#L255">255</a> @Test
-<a class="jxr_linenumber" name="L256" href="#L256">256</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPOFReturnObjectUsages() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="L257" href="#L257">257</a> <strong class="jxr_keyword">final</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool<a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>ry.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a> factory = <strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>();
-<a class="jxr_linenumber" name="L258" href="#L258">258</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
-<a class="jxr_linenumber" name="L259" href="#L259">259</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L260" href="#L260">260</a> pool = makeEmptyPool(factory);
-<a class="jxr_linenumber" name="L261" href="#L261">261</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
-<a class="jxr_linenumber" name="L262" href="#L262">262</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
-<a class="jxr_linenumber" name="L263" href="#L263">263</a> }
-<a class="jxr_linenumber" name="L264" href="#L264">264</a> <strong class="jxr_keyword">final</strong> List<MethodCall> expectedMethods = <strong class="jxr_keyword">new</strong> ArrayList<>();
-<a class="jxr_linenumber" name="L265" href="#L265">265</a> Object obj;
-<a class="jxr_linenumber" name="L266" href="#L266">266</a>
-<a class="jxr_linenumber" name="L267" href="#L267">267</a> <em class="jxr_comment">/// Test correct behavior code paths</em>
-<a class="jxr_linenumber" name="L268" href="#L268">268</a> obj = pool.borrowObject();
-<a class="jxr_linenumber" name="L269" href="#L269">269</a> clear(factory, expectedMethods);
-<a class="jxr_linenumber" name="L270" href="#L270">270</a>
-<a class="jxr_linenumber" name="L271" href="#L271">271</a> <em class="jxr_comment">// returned object should be passivated</em>
-<a class="jxr_linenumber" name="L272" href="#L272">272</a> pool.returnObject(obj);
-<a class="jxr_linenumber" name="L273" href="#L273">273</a> <em class="jxr_comment">// StackObjectPool, SoftReferenceObjectPool also validate on return</em>
-<a class="jxr_linenumber" name="L274" href="#L274">274</a> <strong class="jxr_keyword">if</strong> (pool instanceof SoftReferenceObjectPool) {
-<a class="jxr_linenumber" name="L275" href="#L275">275</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(
-<a class="jxr_linenumber" name="L276" href="#L276">276</a> <span class="jxr_string">"validateObject"</span>, obj).returned(Boolean.TRUE));
-<a class="jxr_linenumber" name="L277" href="#L277">277</a> }
-<a class="jxr_linenumber" name="L278" href="#L278">278</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"passivateObject"</span>, obj));
-<a class="jxr_linenumber" name="L279" href="#L279">279</a> assertEquals(expectedMethods, factory.getMethodCalls());
-<a class="jxr_linenumber" name="L280" href="#L280">280</a>
-<a class="jxr_linenumber" name="L281" href="#L281">281</a> <em class="jxr_comment">//// Test exception handling of returnObject</em>
-<a class="jxr_linenumber" name="L282" href="#L282">282</a> reset(pool, factory, expectedMethods);
+<a class="jxr_linenumber" name="L186" href="#L186">186</a> <em class="jxr_comment">// existing idle object should be activated and validated</em>
+<a class="jxr_linenumber" name="L187" href="#L187">187</a> pool.addObject();
+<a class="jxr_linenumber" name="L188" href="#L188">188</a> clear(factory, expectedMethods);
+<a class="jxr_linenumber" name="L189" href="#L189">189</a> obj = pool.borrowObject();
+<a class="jxr_linenumber" name="L190" href="#L190">190</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, ZERO));
+<a class="jxr_linenumber" name="L191" href="#L191">191</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"validateObject"</span>, ZERO).returned(Boolean.TRUE));
+<a class="jxr_linenumber" name="L192" href="#L192">192</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L193" href="#L193">193</a> pool.returnObject(obj);
+<a class="jxr_linenumber" name="L194" href="#L194">194</a>
+<a class="jxr_linenumber" name="L195" href="#L195">195</a> <em class="jxr_comment">//// Test exception handling of borrowObject</em>
+<a class="jxr_linenumber" name="L196" href="#L196">196</a> reset(pool, factory, expectedMethods);
+<a class="jxr_linenumber" name="L197" href="#L197">197</a>
+<a class="jxr_linenumber" name="L198" href="#L198">198</a> <em class="jxr_comment">// makeObject Exceptions should be propagated to client code from borrowObject</em>
+<a class="jxr_linenumber" name="L199" href="#L199">199</a> factory.setMakeObjectFail(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L200" href="#L200">200</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L201" href="#L201">201</a> obj = pool.borrowObject();
+<a class="jxr_linenumber" name="L202" href="#L202">202</a> fail(<span class="jxr_string">"Expected borrowObject to propagate makeObject exception."</span>);
+<a class="jxr_linenumber" name="L203" href="#L203">203</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> <a name="PrivateException" href="../../../../org/apache/commons/pool2/PrivateException.html#PrivateException">PrivateException</a> pe) {
+<a class="jxr_linenumber" name="L204" href="#L204">204</a> <em class="jxr_comment">// expected</em>
+<a class="jxr_linenumber" name="L205" href="#L205">205</a> }
+<a class="jxr_linenumber" name="L206" href="#L206">206</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>));
+<a class="jxr_linenumber" name="L207" href="#L207">207</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L208" href="#L208">208</a>
+<a class="jxr_linenumber" name="L209" href="#L209">209</a>
+<a class="jxr_linenumber" name="L210" href="#L210">210</a> <em class="jxr_comment">// when activateObject fails in borrowObject, a new object should be borrowed/created</em>
+<a class="jxr_linenumber" name="L211" href="#L211">211</a> reset(pool, factory, expectedMethods);
+<a class="jxr_linenumber" name="L212" href="#L212">212</a> pool.addObject();
+<a class="jxr_linenumber" name="L213" href="#L213">213</a> clear(factory, expectedMethods);
+<a class="jxr_linenumber" name="L214" href="#L214">214</a>
+<a class="jxr_linenumber" name="L215" href="#L215">215</a> factory.setActivateObjectFail(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L216" href="#L216">216</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, obj));
+<a class="jxr_linenumber" name="L217" href="#L217">217</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L218" href="#L218">218</a> pool.borrowObject();
+<a class="jxr_linenumber" name="L219" href="#L219">219</a> fail(<span class="jxr_string">"Expecting NoSuchElementException"</span>);
+<a class="jxr_linenumber" name="L220" href="#L220">220</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> NoSuchElementException ex) {
+<a class="jxr_linenumber" name="L221" href="#L221">221</a> <em class="jxr_comment">// Expected - newly created object will also fail to activate</em>
+<a class="jxr_linenumber" name="L222" href="#L222">222</a> }
+<a class="jxr_linenumber" name="L223" href="#L223">223</a> <em class="jxr_comment">// Idle object fails activation, new one created, also fails</em>
+<a class="jxr_linenumber" name="L224" href="#L224">224</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>).returned(ONE));
+<a class="jxr_linenumber" name="L225" href="#L225">225</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, ONE));
+<a class="jxr_linenumber" name="L226" href="#L226">226</a> removeDestroyObjectCall(factory.getMethodCalls()); <em class="jxr_comment">// The exact timing of destroyObject is flexible here.</em>
+<a class="jxr_linenumber" name="L227" href="#L227">227</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L228" href="#L228">228</a>
+<a class="jxr_linenumber" name="L229" href="#L229">229</a> <em class="jxr_comment">// when validateObject fails in borrowObject, a new object should be borrowed/created</em>
+<a class="jxr_linenumber" name="L230" href="#L230">230</a> reset(pool, factory, expectedMethods);
+<a class="jxr_linenumber" name="L231" href="#L231">231</a> pool.addObject();
+<a class="jxr_linenumber" name="L232" href="#L232">232</a> clear(factory, expectedMethods);
+<a class="jxr_linenumber" name="L233" href="#L233">233</a>
+<a class="jxr_linenumber" name="L234" href="#L234">234</a> factory.setValidateObjectFail(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L235" href="#L235">235</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, ZERO));
+<a class="jxr_linenumber" name="L236" href="#L236">236</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"validateObject"</span>, ZERO));
+<a class="jxr_linenumber" name="L237" href="#L237">237</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L238" href="#L238">238</a> pool.borrowObject();
+<a class="jxr_linenumber" name="L239" href="#L239">239</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> NoSuchElementException ex) {
+<a class="jxr_linenumber" name="L240" href="#L240">240</a> <em class="jxr_comment">// Expected - newly created object will also fail to validate</em>
+<a class="jxr_linenumber" name="L241" href="#L241">241</a> }
+<a class="jxr_linenumber" name="L242" href="#L242">242</a> <em class="jxr_comment">// Idle object is activated, but fails validation.</em>
+<a class="jxr_linenumber" name="L243" href="#L243">243</a> <em class="jxr_comment">// New instance is created, activated and then fails validation</em>
+<a class="jxr_linenumber" name="L244" href="#L244">244</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"makeObject"</span>).returned(ONE));
+<a class="jxr_linenumber" name="L245" href="#L245">245</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"activateObject"</span>, ONE));
+<a class="jxr_linenumber" name="L246" href="#L246">246</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"validateObject"</span>, ONE));
+<a class="jxr_linenumber" name="L247" href="#L247">247</a> removeDestroyObjectCall(factory.getMethodCalls()); <em class="jxr_comment">// The exact timing of destroyObject is flexible here.</em>
+<a class="jxr_linenumber" name="L248" href="#L248">248</a> <em class="jxr_comment">// Second activate and validate are missing from expectedMethods</em>
+<a class="jxr_linenumber" name="L249" href="#L249">249</a> assertTrue(factory.getMethodCalls().containsAll(expectedMethods));
+<a class="jxr_linenumber" name="L250" href="#L250">250</a> pool.close();
+<a class="jxr_linenumber" name="L251" href="#L251">251</a> }
+<a class="jxr_linenumber" name="L252" href="#L252">252</a>
+<a class="jxr_linenumber" name="L253" href="#L253">253</a> @Test
+<a class="jxr_linenumber" name="L254" href="#L254">254</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPOFReturnObjectUsages() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="L255" href="#L255">255</a> <strong class="jxr_keyword">final</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool<a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>ry.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a> factory = <strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>();
+<a class="jxr_linenumber" name="L256" href="#L256">256</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
+<a class="jxr_linenumber" name="L257" href="#L257">257</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L258" href="#L258">258</a> pool = makeEmptyPool(factory);
+<a class="jxr_linenumber" name="L259" href="#L259">259</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
+<a class="jxr_linenumber" name="L260" href="#L260">260</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
+<a class="jxr_linenumber" name="L261" href="#L261">261</a> }
+<a class="jxr_linenumber" name="L262" href="#L262">262</a> <strong class="jxr_keyword">final</strong> List<MethodCall> expectedMethods = <strong class="jxr_keyword">new</strong> ArrayList<>();
+<a class="jxr_linenumber" name="L263" href="#L263">263</a> Object obj;
+<a class="jxr_linenumber" name="L264" href="#L264">264</a>
+<a class="jxr_linenumber" name="L265" href="#L265">265</a> <em class="jxr_comment">/// Test correct behavior code paths</em>
+<a class="jxr_linenumber" name="L266" href="#L266">266</a> obj = pool.borrowObject();
+<a class="jxr_linenumber" name="L267" href="#L267">267</a> clear(factory, expectedMethods);
+<a class="jxr_linenumber" name="L268" href="#L268">268</a>
+<a class="jxr_linenumber" name="L269" href="#L269">269</a> <em class="jxr_comment">// returned object should be passivated</em>
+<a class="jxr_linenumber" name="L270" href="#L270">270</a> pool.returnObject(obj);
+<a class="jxr_linenumber" name="L271" href="#L271">271</a> <em class="jxr_comment">// StackObjectPool, SoftReferenceObjectPool also validate on return</em>
+<a class="jxr_linenumber" name="L272" href="#L272">272</a> <strong class="jxr_keyword">if</strong> (pool instanceof SoftReferenceObjectPool) {
+<a class="jxr_linenumber" name="L273" href="#L273">273</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(
+<a class="jxr_linenumber" name="L274" href="#L274">274</a> <span class="jxr_string">"validateObject"</span>, obj).returned(Boolean.TRUE));
+<a class="jxr_linenumber" name="L275" href="#L275">275</a> }
+<a class="jxr_linenumber" name="L276" href="#L276">276</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"passivateObject"</span>, obj));
+<a class="jxr_linenumber" name="L277" href="#L277">277</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L278" href="#L278">278</a>
+<a class="jxr_linenumber" name="L279" href="#L279">279</a> <em class="jxr_comment">//// Test exception handling of returnObject</em>
+<a class="jxr_linenumber" name="L280" href="#L280">280</a> reset(pool, factory, expectedMethods);
+<a class="jxr_linenumber" name="L281" href="#L281">281</a> pool.addObject();
+<a class="jxr_linenumber" name="L282" href="#L282">282</a> pool.addObject();
<a class="jxr_linenumber" name="L283" href="#L283">283</a> pool.addObject();
-<a class="jxr_linenumber" name="L284" href="#L284">284</a> pool.addObject();
-<a class="jxr_linenumber" name="L285" href="#L285">285</a> pool.addObject();
-<a class="jxr_linenumber" name="L286" href="#L286">286</a> assertEquals(3, pool.getNumIdle());
-<a class="jxr_linenumber" name="L287" href="#L287">287</a> <em class="jxr_comment">// passivateObject should swallow exceptions and not add the object to the pool</em>
-<a class="jxr_linenumber" name="L288" href="#L288">288</a> obj = pool.borrowObject();
-<a class="jxr_linenumber" name="L289" href="#L289">289</a> pool.borrowObject();
-<a class="jxr_linenumber" name="L290" href="#L290">290</a> assertEquals(1, pool.getNumIdle());
-<a class="jxr_linenumber" name="L291" href="#L291">291</a> assertEquals(2, pool.getNumActive());
-<a class="jxr_linenumber" name="L292" href="#L292">292</a> clear(factory, expectedMethods);
-<a class="jxr_linenumber" name="L293" href="#L293">293</a> factory.setPassivateObjectFail(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L294" href="#L294">294</a> pool.returnObject(obj);
-<a class="jxr_linenumber" name="L295" href="#L295">295</a> <em class="jxr_comment">// StackObjectPool, SoftReferenceObjectPool also validate on return</em>
-<a class="jxr_linenumber" name="L296" href="#L296">296</a> <strong class="jxr_keyword">if</strong> (pool instanceof SoftReferenceObjectPool) {
-<a class="jxr_linenumber" name="L297" href="#L297">297</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(
-<a class="jxr_linenumber" name="L298" href="#L298">298</a> <span class="jxr_string">"validateObject"</span>, obj).returned(Boolean.TRUE));
-<a class="jxr_linenumber" name="L299" href="#L299">299</a> }
-<a class="jxr_linenumber" name="L300" href="#L300">300</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"passivateObject"</span>, obj));
-<a class="jxr_linenumber" name="L301" href="#L301">301</a> removeDestroyObjectCall(factory.getMethodCalls()); <em class="jxr_comment">// The exact timing of destroyObject is flexible here.</em>
-<a class="jxr_linenumber" name="L302" href="#L302">302</a> assertEquals(expectedMethods, factory.getMethodCalls());
-<a class="jxr_linenumber" name="L303" href="#L303">303</a> assertEquals(1, pool.getNumIdle()); <em class="jxr_comment">// Not returned</em>
-<a class="jxr_linenumber" name="L304" href="#L304">304</a> assertEquals(1, pool.getNumActive()); <em class="jxr_comment">// But not in active count</em>
-<a class="jxr_linenumber" name="L305" href="#L305">305</a>
-<a class="jxr_linenumber" name="L306" href="#L306">306</a> <em class="jxr_comment">// destroyObject should swallow exceptions too</em>
-<a class="jxr_linenumber" name="L307" href="#L307">307</a> reset(pool, factory, expectedMethods);
-<a class="jxr_linenumber" name="L308" href="#L308">308</a> obj = pool.borrowObject();
-<a class="jxr_linenumber" name="L309" href="#L309">309</a> clear(factory, expectedMethods);
-<a class="jxr_linenumber" name="L310" href="#L310">310</a> factory.setPassivateObjectFail(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L311" href="#L311">311</a> factory.setDestroyObjectFail(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="L312" href="#L312">312</a> pool.returnObject(obj);
-<a class="jxr_linenumber" name="L313" href="#L313">313</a> pool.close();
-<a class="jxr_linenumber" name="L314" href="#L314">314</a> }
-<a class="jxr_linenumber" name="L315" href="#L315">315</a>
-<a class="jxr_linenumber" name="L316" href="#L316">316</a> @Test
-<a class="jxr_linenumber" name="L317" href="#L317">317</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPOFInvalidateObjectUsages() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="L318" href="#L318">318</a> <strong class="jxr_keyword">final</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool<a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>ry.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a> factory = <strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>();
-<a class="jxr_linenumber" name="L319" href="#L319">319</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
-<a class="jxr_linenumber" name="L320" href="#L320">320</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="L321" href="#L321">321</a> pool = makeEmptyPool(factory);
-<a class="jxr_linenumber" name="L322" href="#L322">322</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
-<a class="jxr_linenumber" name="L323" href="#L323">323</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
-<a class="jxr_linenumber" name="L324" href="#L324">324</a> }
-<a class="jxr_linenumber" name="L325" href="#L325">325</a> <strong class="jxr_keyword">final</strong> List<MethodCall> expectedMethods = <strong class="jxr_keyword">new</strong> ArrayList<>();
-<a class="jxr_linenumber" name="L326" href="#L326">326</a> Object obj;
+<a class="jxr_linenumber" name="L284" href="#L284">284</a> assertEquals(3, pool.getNumIdle());
+<a class="jxr_linenumber" name="L285" href="#L285">285</a> <em class="jxr_comment">// passivateObject should swallow exceptions and not add the object to the pool</em>
+<a class="jxr_linenumber" name="L286" href="#L286">286</a> obj = pool.borrowObject();
+<a class="jxr_linenumber" name="L287" href="#L287">287</a> pool.borrowObject();
+<a class="jxr_linenumber" name="L288" href="#L288">288</a> assertEquals(1, pool.getNumIdle());
+<a class="jxr_linenumber" name="L289" href="#L289">289</a> assertEquals(2, pool.getNumActive());
+<a class="jxr_linenumber" name="L290" href="#L290">290</a> clear(factory, expectedMethods);
+<a class="jxr_linenumber" name="L291" href="#L291">291</a> factory.setPassivateObjectFail(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L292" href="#L292">292</a> pool.returnObject(obj);
+<a class="jxr_linenumber" name="L293" href="#L293">293</a> <em class="jxr_comment">// StackObjectPool, SoftReferenceObjectPool also validate on return</em>
+<a class="jxr_linenumber" name="L294" href="#L294">294</a> <strong class="jxr_keyword">if</strong> (pool instanceof SoftReferenceObjectPool) {
+<a class="jxr_linenumber" name="L295" href="#L295">295</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(
+<a class="jxr_linenumber" name="L296" href="#L296">296</a> <span class="jxr_string">"validateObject"</span>, obj).returned(Boolean.TRUE));
+<a class="jxr_linenumber" name="L297" href="#L297">297</a> }
+<a class="jxr_linenumber" name="L298" href="#L298">298</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"passivateObject"</span>, obj));
+<a class="jxr_linenumber" name="L299" href="#L299">299</a> removeDestroyObjectCall(factory.getMethodCalls()); <em class="jxr_comment">// The exact timing of destroyObject is flexible here.</em>
+<a class="jxr_linenumber" name="L300" href="#L300">300</a> assertEquals(expectedMethods, factory.getMethodCalls());
+<a class="jxr_linenumber" name="L301" href="#L301">301</a> assertEquals(1, pool.getNumIdle()); <em class="jxr_comment">// Not returned</em>
+<a class="jxr_linenumber" name="L302" href="#L302">302</a> assertEquals(1, pool.getNumActive()); <em class="jxr_comment">// But not in active count</em>
+<a class="jxr_linenumber" name="L303" href="#L303">303</a>
+<a class="jxr_linenumber" name="L304" href="#L304">304</a> <em class="jxr_comment">// destroyObject should swallow exceptions too</em>
+<a class="jxr_linenumber" name="L305" href="#L305">305</a> reset(pool, factory, expectedMethods);
+<a class="jxr_linenumber" name="L306" href="#L306">306</a> obj = pool.borrowObject();
+<a class="jxr_linenumber" name="L307" href="#L307">307</a> clear(factory, expectedMethods);
+<a class="jxr_linenumber" name="L308" href="#L308">308</a> factory.setPassivateObjectFail(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L309" href="#L309">309</a> factory.setDestroyObjectFail(<strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="L310" href="#L310">310</a> pool.returnObject(obj);
+<a class="jxr_linenumber" name="L311" href="#L311">311</a> pool.close();
+<a class="jxr_linenumber" name="L312" href="#L312">312</a> }
+<a class="jxr_linenumber" name="L313" href="#L313">313</a>
+<a class="jxr_linenumber" name="L314" href="#L314">314</a> @Test
+<a class="jxr_linenumber" name="L315" href="#L315">315</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testPOFInvalidateObjectUsages() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="L316" href="#L316">316</a> <strong class="jxr_keyword">final</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool<a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>ry.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a> factory = <strong class="jxr_keyword">new</strong> <a name="MethodCallPoolableObjectFactory" href="../../../../org/apache/commons/pool2/MethodCallPoolableObjectFactory.html#MethodCallPoolableObjectFactory">MethodCallPoolableObjectFactory</a>();
+<a class="jxr_linenumber" name="L317" href="#L317">317</a> <strong class="jxr_keyword">final</strong> ObjectPool<Object> pool;
+<a class="jxr_linenumber" name="L318" href="#L318">318</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="L319" href="#L319">319</a> pool = makeEmptyPool(factory);
+<a class="jxr_linenumber" name="L320" href="#L320">320</a> } <strong class="jxr_keyword">catch</strong> (<strong class="jxr_keyword">final</strong> UnsupportedOperationException uoe) {
+<a class="jxr_linenumber" name="L321" href="#L321">321</a> <strong class="jxr_keyword">return</strong>; <em class="jxr_comment">// test not supported</em>
+<a class="jxr_linenumber" name="L322" href="#L322">322</a> }
+<a class="jxr_linenumber" name="L323" href="#L323">323</a> <strong class="jxr_keyword">final</strong> List<MethodCall> expectedMethods = <strong class="jxr_keyword">new</strong> ArrayList<>();
+<a class="jxr_linenumber" name="L324" href="#L324">324</a> Object obj;
+<a class="jxr_linenumber" name="L325" href="#L325">325</a>
+<a class="jxr_linenumber" name="L326" href="#L326">326</a> <em class="jxr_comment">/// Test correct behavior code paths</em>
<a class="jxr_linenumber" name="L327" href="#L327">327</a>
-<a class="jxr_linenumber" name="L328" href="#L328">328</a> <em class="jxr_comment">/// Test correct behavior code paths</em>
-<a class="jxr_linenumber" name="L329" href="#L329">329</a>
-<a class="jxr_linenumber" name="L330" href="#L330">330</a> obj = pool.borrowObject();
-<a class="jxr_linenumber" name="L331" href="#L331">331</a> clear(factory, expectedMethods);
-<a class="jxr_linenumber" name="L332" href="#L332">332</a>
-<a class="jxr_linenumber" name="L333" href="#L333">333</a> <em class="jxr_comment">// invalidated object should be destroyed</em>
-<a class="jxr_linenumber" name="L334" href="#L334">334</a> pool.invalidateObject(obj);
-<a class="jxr_linenumber" name="L335" href="#L335">335</a> expectedMethods.add(<strong class="jxr_keyword">new</strong> <a name="MethodCall" href="../../../../org/apache/commons/pool2/MethodCall.html#MethodCall">MethodCall</a>(<span class="jxr_string">"destroyObject"</span>, obj));
-<a class="jxr_linenumber" name="L336" href="#L336">336</a> assertEquals(expectedMethods, factory.getMethodCalls());
-<a class="jxr_linenumber" name="L337" href="#L337">337</a>
-<a class="jxr_linenumber" name="L338" href="#L338">338</a> <em class="jxr_comment">//// Test exception handling of invalidateObject</em>
-<a class="jxr_linenumber" name="L339" href="#L339">339</a> reset(pool, factory, expectedMethods);
[... 212 lines stripped ...]