You are viewing a plain text version of this content. The canonical link for it is here.
Posted to infrastructure-dev@apache.org by Adam Bordelon <ad...@mesosphere.io> on 2015/10/13 08:07:17 UTC
Applying Github PRs to Apache git repos
Is there some automagical way to merge PRs from our github mirror into
the Apache git repo? The Myriad podling has been looking at Mesos'
apply-review.sh (and the in-development apply-review.py), which can
also support ReviewBoard patches, but wanted to ask around to find out
what other projects are using.
Please advise.
Thanks for your help,
-Adam-
Apache Myriad, Apache Mesos
Re: Applying Github PRs to Apache git repos
Posted by Allen Wittenauer <aw...@altiscale.com>.
This just sort of stresses why we need to get a release out. Something static that can act as a focal point. The number of blockers heading for that first release is shrinking. :)
On Oct 13, 2015, at 9:28 AM, Andrew Bayer <an...@gmail.com> wrote:
> Cool - we should reach out to Mesos and any other project that's doing this
> sort of thing and get it all consolidated to Yetus.
>
> A.
>
> On Tue, Oct 13, 2015 at 6:06 PM, Allen Wittenauer <aw...@altiscale.com> wrote:
>
>>
>> Actually, smart-apply-patch should be able to apply github PRs now that it
>> uses the test-patch plugins. So, (hopefully obviously) parameters would be
>> the same as if you were using test-patch, so:
>>
>> $ smart-apply-patch —project=(project that defines a github repo) 5
>>
>> would apply pr #5 from that project’s repo.
>>
>> $ smart-apply-patch --github-repo=aw-altiscale/yetus 5
>>
>> would apply PR #5 from the aw-altiscale/yetus repo.
>>
>> Normal s-a-p options work as well (dry run, committer mode, etc). In the
>> case of github, there’s also options for settings tokens and the actual
>> github URL to use if you want to use the commercial github stuff too.
>>
>>
>> On Oct 13, 2015, at 1:11 AM, Andrew Bayer <an...@gmail.com> wrote:
>>
>>> FYI - this seems like the kind of thing we should be jumping on? =)
>>>
>>> A.
>>>
>>> ---------- Forwarded message ----------
>>> From: Andrew Bayer <an...@gmail.com>
>>> Date: Tue, Oct 13, 2015 at 10:11 AM
>>> Subject: Re: Applying Github PRs to Apache git repos
>>> To: "infrastructure-dev@apache.org" <in...@apache.org>
>>>
>>>
>>> Yetus (http://yetus.apache.org) doesn't yet have GitHub support for
>>> smart-apply-patch, and doesn't have review board support yet, but that's
>>> the logical place for such tooling to end up.
>>>
>>> A.
>>>
>>>
>>> On Tue, Oct 13, 2015 at 10:07 AM, Daan Hoogland <daan.hoogland@gmail.com
>>>
>>> wrote:
>>>
>>>> have a look at git-pr in the cloudstack repo
>>>> tools/git/git-pr. It merges locally after which you'll have to push to
>>>> apache.
>>>>
>>>> On Tue, Oct 13, 2015 at 8:07 AM, Adam Bordelon <ad...@mesosphere.io>
>> wrote:
>>>>
>>>>> Is there some automagical way to merge PRs from our github mirror into
>>>>> the Apache git repo? The Myriad podling has been looking at Mesos'
>>>>> apply-review.sh (and the in-development apply-review.py), which can
>>>>> also support ReviewBoard patches, but wanted to ask around to find out
>>>>> what other projects are using.
>>>>> Please advise.
>>>>>
>>>>> Thanks for your help,
>>>>> -Adam-
>>>>> Apache Myriad, Apache Mesos
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Daan
>>>>
>>
>>
Re: Applying Github PRs to Apache git repos
Posted by Andrew Bayer <an...@gmail.com>.
Cool - we should reach out to Mesos and any other project that's doing this
sort of thing and get it all consolidated to Yetus.
A.
On Tue, Oct 13, 2015 at 6:06 PM, Allen Wittenauer <aw...@altiscale.com> wrote:
>
> Actually, smart-apply-patch should be able to apply github PRs now that it
> uses the test-patch plugins. So, (hopefully obviously) parameters would be
> the same as if you were using test-patch, so:
>
> $ smart-apply-patch —project=(project that defines a github repo) 5
>
> would apply pr #5 from that project’s repo.
>
> $ smart-apply-patch --github-repo=aw-altiscale/yetus 5
>
> would apply PR #5 from the aw-altiscale/yetus repo.
>
> Normal s-a-p options work as well (dry run, committer mode, etc). In the
> case of github, there’s also options for settings tokens and the actual
> github URL to use if you want to use the commercial github stuff too.
>
>
> On Oct 13, 2015, at 1:11 AM, Andrew Bayer <an...@gmail.com> wrote:
>
> > FYI - this seems like the kind of thing we should be jumping on? =)
> >
> > A.
> >
> > ---------- Forwarded message ----------
> > From: Andrew Bayer <an...@gmail.com>
> > Date: Tue, Oct 13, 2015 at 10:11 AM
> > Subject: Re: Applying Github PRs to Apache git repos
> > To: "infrastructure-dev@apache.org" <in...@apache.org>
> >
> >
> > Yetus (http://yetus.apache.org) doesn't yet have GitHub support for
> > smart-apply-patch, and doesn't have review board support yet, but that's
> > the logical place for such tooling to end up.
> >
> > A.
> >
> >
> > On Tue, Oct 13, 2015 at 10:07 AM, Daan Hoogland <daan.hoogland@gmail.com
> >
> > wrote:
> >
> >> have a look at git-pr in the cloudstack repo
> >> tools/git/git-pr. It merges locally after which you'll have to push to
> >> apache.
> >>
> >> On Tue, Oct 13, 2015 at 8:07 AM, Adam Bordelon <ad...@mesosphere.io>
> wrote:
> >>
> >>> Is there some automagical way to merge PRs from our github mirror into
> >>> the Apache git repo? The Myriad podling has been looking at Mesos'
> >>> apply-review.sh (and the in-development apply-review.py), which can
> >>> also support ReviewBoard patches, but wanted to ask around to find out
> >>> what other projects are using.
> >>> Please advise.
> >>>
> >>> Thanks for your help,
> >>> -Adam-
> >>> Apache Myriad, Apache Mesos
> >>>
> >>
> >>
> >>
> >> --
> >> Daan
> >>
>
>
Re: Applying Github PRs to Apache git repos
Posted by Allen Wittenauer <aw...@altiscale.com>.
Actually, smart-apply-patch should be able to apply github PRs now that it uses the test-patch plugins. So, (hopefully obviously) parameters would be the same as if you were using test-patch, so:
$ smart-apply-patch —project=(project that defines a github repo) 5
would apply pr #5 from that project’s repo.
$ smart-apply-patch --github-repo=aw-altiscale/yetus 5
would apply PR #5 from the aw-altiscale/yetus repo.
Normal s-a-p options work as well (dry run, committer mode, etc). In the case of github, there’s also options for settings tokens and the actual github URL to use if you want to use the commercial github stuff too.
On Oct 13, 2015, at 1:11 AM, Andrew Bayer <an...@gmail.com> wrote:
> FYI - this seems like the kind of thing we should be jumping on? =)
>
> A.
>
> ---------- Forwarded message ----------
> From: Andrew Bayer <an...@gmail.com>
> Date: Tue, Oct 13, 2015 at 10:11 AM
> Subject: Re: Applying Github PRs to Apache git repos
> To: "infrastructure-dev@apache.org" <in...@apache.org>
>
>
> Yetus (http://yetus.apache.org) doesn't yet have GitHub support for
> smart-apply-patch, and doesn't have review board support yet, but that's
> the logical place for such tooling to end up.
>
> A.
>
>
> On Tue, Oct 13, 2015 at 10:07 AM, Daan Hoogland <da...@gmail.com>
> wrote:
>
>> have a look at git-pr in the cloudstack repo
>> tools/git/git-pr. It merges locally after which you'll have to push to
>> apache.
>>
>> On Tue, Oct 13, 2015 at 8:07 AM, Adam Bordelon <ad...@mesosphere.io> wrote:
>>
>>> Is there some automagical way to merge PRs from our github mirror into
>>> the Apache git repo? The Myriad podling has been looking at Mesos'
>>> apply-review.sh (and the in-development apply-review.py), which can
>>> also support ReviewBoard patches, but wanted to ask around to find out
>>> what other projects are using.
>>> Please advise.
>>>
>>> Thanks for your help,
>>> -Adam-
>>> Apache Myriad, Apache Mesos
>>>
>>
>>
>>
>> --
>> Daan
>>
Fwd: Applying Github PRs to Apache git repos
Posted by Andrew Bayer <an...@gmail.com>.
FYI - this seems like the kind of thing we should be jumping on? =)
A.
---------- Forwarded message ----------
From: Andrew Bayer <an...@gmail.com>
Date: Tue, Oct 13, 2015 at 10:11 AM
Subject: Re: Applying Github PRs to Apache git repos
To: "infrastructure-dev@apache.org" <in...@apache.org>
Yetus (http://yetus.apache.org) doesn't yet have GitHub support for
smart-apply-patch, and doesn't have review board support yet, but that's
the logical place for such tooling to end up.
A.
On Tue, Oct 13, 2015 at 10:07 AM, Daan Hoogland <da...@gmail.com>
wrote:
> have a look at git-pr in the cloudstack repo
> tools/git/git-pr. It merges locally after which you'll have to push to
> apache.
>
> On Tue, Oct 13, 2015 at 8:07 AM, Adam Bordelon <ad...@mesosphere.io> wrote:
>
> > Is there some automagical way to merge PRs from our github mirror into
> > the Apache git repo? The Myriad podling has been looking at Mesos'
> > apply-review.sh (and the in-development apply-review.py), which can
> > also support ReviewBoard patches, but wanted to ask around to find out
> > what other projects are using.
> > Please advise.
> >
> > Thanks for your help,
> > -Adam-
> > Apache Myriad, Apache Mesos
> >
>
>
>
> --
> Daan
>
Re: Applying Github PRs to Apache git repos
Posted by Andrew Bayer <an...@gmail.com>.
Yetus (http://yetus.apache.org) doesn't yet have GitHub support for
smart-apply-patch, and doesn't have review board support yet, but that's
the logical place for such tooling to end up.
A.
On Tue, Oct 13, 2015 at 10:07 AM, Daan Hoogland <da...@gmail.com>
wrote:
> have a look at git-pr in the cloudstack repo
> tools/git/git-pr. It merges locally after which you'll have to push to
> apache.
>
> On Tue, Oct 13, 2015 at 8:07 AM, Adam Bordelon <ad...@mesosphere.io> wrote:
>
> > Is there some automagical way to merge PRs from our github mirror into
> > the Apache git repo? The Myriad podling has been looking at Mesos'
> > apply-review.sh (and the in-development apply-review.py), which can
> > also support ReviewBoard patches, but wanted to ask around to find out
> > what other projects are using.
> > Please advise.
> >
> > Thanks for your help,
> > -Adam-
> > Apache Myriad, Apache Mesos
> >
>
>
>
> --
> Daan
>
Re: Applying Github PRs to Apache git repos
Posted by Daan Hoogland <da...@gmail.com>.
have a look at git-pr in the cloudstack repo
tools/git/git-pr. It merges locally after which you'll have to push to
apache.
On Tue, Oct 13, 2015 at 8:07 AM, Adam Bordelon <ad...@mesosphere.io> wrote:
> Is there some automagical way to merge PRs from our github mirror into
> the Apache git repo? The Myriad podling has been looking at Mesos'
> apply-review.sh (and the in-development apply-review.py), which can
> also support ReviewBoard patches, but wanted to ask around to find out
> what other projects are using.
> Please advise.
>
> Thanks for your help,
> -Adam-
> Apache Myriad, Apache Mesos
>
--
Daan
Re: Applying Github PRs to Apache git repos
Posted by Jake Farrell <jf...@apache.org>.
Hey Adam
The tools you have been looking at are leveraging the commit message hook
that Github supports [1]. Based on the commit message you can close out
pull requests on Github. I also wrote a plugin to rbt that will work with
Github pull requests, code available at [2]. If you have any questions
please let me know
-Jake
[1]:
https://help.github.com/enterprise/11.10.340/user/articles/closing-issues-via-commit-messages/
[2]: https://github.com/jfarrell/rbt-github
On Tue, Oct 13, 2015 at 2:07 AM, Adam Bordelon <ad...@mesosphere.io> wrote:
> Is there some automagical way to merge PRs from our github mirror into
> the Apache git repo? The Myriad podling has been looking at Mesos'
> apply-review.sh (and the in-development apply-review.py), which can
> also support ReviewBoard patches, but wanted to ask around to find out
> what other projects are using.
> Please advise.
>
> Thanks for your help,
> -Adam-
> Apache Myriad, Apache Mesos
>