You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/11/12 11:33:59 UTC

[GitHub] [zeppelin] Reamer opened a new pull request #3969: [ZEPPELIN-5130] Improve changes

Reamer opened a new pull request #3969:
URL: https://github.com/apache/zeppelin/pull/3969


   ### What is this PR for?
   This PR improves the code, but should not change functionality.
    - Improve `LOGGER` usage
    - Remove unused imports
    - Remove deprecated function calls e.g. FileUtils.read/write without a charset
    - closing of DirectoryStream with try-with-resource
    - Correct use of 'AssertEquals()', first value is the expected value
   
   ### What type of PR is it?
    - Maintenance
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5130
   
   ### How should this be tested?
   * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3969: [ZEPPELIN-5130] Improve code style

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3969:
URL: https://github.com/apache/zeppelin/pull/3969


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3969: [ZEPPELIN-5130] Improve code style

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3969:
URL: https://github.com/apache/zeppelin/pull/3969#issuecomment-726126818


   These changes are without magic, so I will merge them into Master and Branch-0.9 on Friday (13.11.2020) if no further comments follow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org