You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Tom Schneider (JIRA)" <ji...@apache.org> on 2006/12/16 16:41:58 UTC
[jira] Created: (WW-1563) URL tag includeParams get functionality
does not work under websphere
URL tag includeParams get functionality does not work under websphere
---------------------------------------------------------------------
Key: WW-1563
URL: http://issues.apache.org/struts/browse/WW-1563
Project: Struts 2
Issue Type: Bug
Components: Views
Affects Versions: 2.0.1
Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
Reporter: Tom Schneider
In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Tom Schneider (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=comments#action_39126 ]
Tom Schneider commented on WW-1563:
-----------------------------------
I have verified that the fix does not work for Websphere 5.1. The query string information is not available anywhere in the request via the standard servlet API after a forward. To get this functionality to work under Websphere 5.1, we would have to save off the query string information somewhere in the request and look for it in that location in the URL tag. Since Websphere 5.1 is not Servlet spec 2.4 compliant, (it supports servlet spec 2.3) then I don't think struts2 needs to support Websphere 5.1.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=comments#action_39125 ]
Don Brown commented on WW-1563:
-------------------------------
Well, as a general rule, the Struts project doesn't add fixes for specific broken containers, but if there is something more we can do, please at least let us know...this ticket is a fine place for continued discussion and patches.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Tom Schneider (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=comments#action_39131 ]
Tom Schneider commented on WW-1563:
-----------------------------------
I wasn't able to edit the FAQ. Instead, I added it to the Vault: http://cwiki.apache.org/confluence/display/S2WIKI/Vault.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch, Websphere51QueryStringInterceptor.java
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Tom Schneider (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=comments#action_39124 ]
Tom Schneider commented on WW-1563:
-----------------------------------
Well, our testing showed that this resolved the issue under Websphere 6.1. However, it did not fix the issue for Websphere 5.1.1.8. :(
According to IBM, the behavior should be consistent between all versions of Websphere. (http://www-1.ibm.com/support/docview.wss?fdoc=aimwas&rs=180&uid=swg21215961) I'll see if I can figure out where the query string is stored under Websphere 5.1. Let me know if you want a seperate bug for Websphere 5.1.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=comments#action_39130 ]
Don Brown commented on WW-1563:
-------------------------------
Could you add this code and explanation to our FAQ: http://cwiki.apache.org/confluence/display/WW/FAQs
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch, Websphere51QueryStringInterceptor.java
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Tom Schneider (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=comments#action_39128 ]
Tom Schneider commented on WW-1563:
-----------------------------------
That is an excellent idea. (Never even crossed my mind, but that would solve the problem nicely I think) I'll post the code to this issue if we end up needing it. Thanks.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Tom Schneider (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=all ]
Tom Schneider updated WW-1563:
------------------------------
Attachment: websphere-includeparams.patch
This patch modifies the default request wrapper to look first in the getQueryString method and if not found there, then in getAttribute("javax.servlet.forward.query_string"). This should allow it to function on both Websphere and Tomcat platforms. I'll be testing this on Monday with a patched version of Webwork 2.2.4.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Attachments: websphere-includeparams.patch
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Tom Schneider (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=all ]
Tom Schneider updated WW-1563:
------------------------------
Attachment: Websphere51QueryStringInterceptor.java
Here is an intercpetor that works around the Websphere 5.1 query string issue. I tested it under websphere 5.1.1.8, websphere 6.1, and jetty 5.1 and it worked under all of these app servers.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch, Websphere51QueryStringInterceptor.java
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=all ]
Don Brown resolved WW-1563.
---------------------------
Fix Version/s: 2.0.2
Resolution: Fixed
Assignee: Don Brown
I fixed the issue, although I put the fix in the URL component itself, since returning null is the expected behavior.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=comments#action_39127 ]
Don Brown commented on WW-1563:
-------------------------------
Hmm...what if we created a simple interceptor that stored the querystring into that request attribute? If nothing else, we could attach the code to the FAQ.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1563) URL tag includeParams get functionality
does not work under websphere
Posted by "Tom Schneider (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1563?page=comments#action_39118 ]
Tom Schneider commented on WW-1563:
-----------------------------------
Thanks for the quick resolution. I'll be backporting your fix to webwork and testing it on Monday.
> URL tag includeParams get functionality does not work under websphere
> ---------------------------------------------------------------------
>
> Key: WW-1563
> URL: http://issues.apache.org/struts/browse/WW-1563
> Project: Struts 2
> Issue Type: Bug
> Components: Views
> Affects Versions: 2.0.1
> Environment: Websphere 5.1.1.8, 5.1.1.13, 6.1
> Reporter: Tom Schneider
> Assigned To: Don Brown
> Fix For: 2.0.2
>
> Attachments: websphere-includeparams.patch
>
>
> In our testing with webwork, we found that the URL tag includeParams functionality does not work under Websphere 5 and 6. The issue is that after a forward, the call to request.getQueryString() always returns null, regardless of whether there were query parameters for the original request. The fix is to additionally look for getAttribute("javax.servlet.forward.query_string") since this is where this information is stored for 2.4 servlet containers.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira