You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/11/01 20:53:57 UTC
[impala] 02/02: IMPALA-9105: Catalog debug page top-n table has a
URL generation issue
This is an automated email from the ASF dual-hosted git repository.
tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 770e72d53e11c2902be848a5f2608c4b4c6e19aa
Author: Jiawei Wang <ji...@cloudera.com>
AuthorDate: Wed Oct 30 13:32:58 2019 -0500
IMPALA-9105: Catalog debug page top-n table has a URL generation issue
What's the problem:
Previously, catalogd debug page does not have 'fqtn' property. Because
CatalogServer::GetCatalogUsage() does not pass fqtn to the template.
Thus, the generated page table detail page cannot be opened. Also,
Someone might accedentially deleted <td> which makes the catalogd UI
top-K page unorganized.
Fix:
Correct the URL generation part.
Test:
Open the page and all the tables object can be correctly opened.
Change-Id: If7416c79baf2e78d6790995e97d9802ec7a8cc37
Reviewed-on: http://gerrit.cloudera.org:8080/14589
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
www/catalog.tmpl | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/www/catalog.tmpl b/www/catalog.tmpl
index 126c658..095717a 100644
--- a/www/catalog.tmpl
+++ b/www/catalog.tmpl
@@ -39,11 +39,12 @@ under the License.
<tbody>
{{#large_tables}}
<tr>
+ <td>
<!-- The /catalog_object endpoint is disabled if local_catalog_mode is used
since metadata is partially fetched on demand. -->
{{?use_local_catalog}} {{name}} {{/use_local_catalog}}
{{^use_local_catalog}}
- <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{fqtn}}">{{name}}</a>
+ <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a>
{{/use_local_catalog}}
</td>
<td>{{mem_estimate}}</td>
@@ -88,7 +89,7 @@ under the License.
<td>
{{?use_local_catalog}} {{name}} {{/use_local_catalog}}
{{^use_local_catalog}}
- <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{fqtn}}">{{name}}</a>
+ <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a>
{{/use_local_catalog}}
</td>
<td>{{num_metadata_ops}}</td>
@@ -132,7 +133,7 @@ under the License.
<td>
{{?use_local_catalog}} {{name}} {{/use_local_catalog}}
{{^use_local_catalog}}
- <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{fqtn}}">{{name}}</a>
+ <a href="{{ __common__.host-url }}/catalog_object?object_type=TABLE&object_name={{name}}">{{name}}</a>
{{/use_local_catalog}}
</td>
<td>{{num_files}}</td>