You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/12 10:03:48 UTC

Review Request 12498: CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12498/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and edison su.


Bugs: CLOUDSTACK-2987


Repository: cloudstack-git


Description
-------

CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API

This has to be fixed due to the merges post to my commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 which is working fine.


Diffs
-----

  engine/schema/src/com/cloud/storage/VMTemplateVO.java 3e71191 
  server/src/com/cloud/template/TemplateAdapterBase.java fce2506 
  server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 

Diff: https://reviews.apache.org/r/12498/diff/


Testing
-------


Thanks,

Harikrishna Patnala


Re: Review Request 12498: CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12498/#review23071
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On July 12, 2013, 8:03 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12498/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 8:03 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and edison su.
> 
> 
> Bugs: CLOUDSTACK-2987
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API
> 
> This has to be fixed due to the merges post to my commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 which is working fine.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/storage/VMTemplateVO.java 3e71191 
>   server/src/com/cloud/template/TemplateAdapterBase.java fce2506 
>   server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 
> 
> Diff: https://reviews.apache.org/r/12498/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12498: CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12498/#review23075
-----------------------------------------------------------


Commit 8816d41d3b62fe50bbeb70e541f54f8e232c362e in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8816d41 ]

CLOUDSTACK-2987: Fixing dynamicallyScalable flag in register and update template API Previuos commit: 7b6b8d7a077478620232ea1ac4ec2304289e8661 This fix is due to some changes made by the merges after this commit.

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On July 12, 2013, 9:48 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12498/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 9:48 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, edison su, and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2987
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API
> 
> This has to be fixed due to the merges post to my commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 which is working fine.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/storage/VMTemplateVO.java 3e71191 
>   server/src/com/cloud/template/TemplateAdapterBase.java fce2506 
>   server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 
> 
> Diff: https://reviews.apache.org/r/12498/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12498: CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12498/#review23074
-----------------------------------------------------------


Commit 5dd1a1dd8eec0a37db36b5c86d847fbbe4fcc41d in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5dd1a1d ]

CLOUDSTACK-2987: Fixing dynamicallyScalable flag in register and update template API Previuos commit: 7b6b8d7a077478620232ea1ac4ec2304289e8661 This fix is due to some changes made by the merges after this commit.

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On July 12, 2013, 9:48 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12498/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 9:48 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, edison su, and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-2987
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API
> 
> This has to be fixed due to the merges post to my commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 which is working fine.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/storage/VMTemplateVO.java 3e71191 
>   server/src/com/cloud/template/TemplateAdapterBase.java fce2506 
>   server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 
> 
> Diff: https://reviews.apache.org/r/12498/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12498: CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12498/
-----------------------------------------------------------

(Updated July 12, 2013, 9:48 a.m.)


Review request for cloudstack, Abhinandan Prateek, edison su, and Nitin Mehta.


Bugs: CLOUDSTACK-2987


Repository: cloudstack-git


Description
-------

CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API

This has to be fixed due to the merges post to my commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 which is working fine.


Diffs
-----

  engine/schema/src/com/cloud/storage/VMTemplateVO.java 3e71191 
  server/src/com/cloud/template/TemplateAdapterBase.java fce2506 
  server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 

Diff: https://reviews.apache.org/r/12498/diff/


Testing
-------


Thanks,

Harikrishna Patnala