You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by GitBox <gi...@apache.org> on 2021/01/30 19:29:23 UTC
[GitHub] [db-jdo-site] tzaeschke opened a new pull request #19: Update pom.xml
tzaeschke opened a new pull request #19:
URL: https://github.com/apache/db-jdo-site/pull/19
This PR updates the `.pom` to cpoy the javadoc APIs from the resources to the `docs` folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
I created an Infra ticket to disable GitHub Pages.
Posted by Tilmann <ti...@gmx.de>.
https://issues.apache.org/jira/browse/INFRA-21384
tilmann
Re: Is it worth establishing a separate mailing list for the GitHub
message traffic?
Posted by Tilmann <ti...@gmx.de>.
Maybe it is possible to reduce the volume a bit?
For example currently many messages are sent twice, once from GitHub and
again from GitBox. Maybe than can be avoided?
Tilmann
On 04/02/2021 23:21, JDO Spec wrote:
> Personally, I have no problem with the number of messages on the jdo-dev list that come from github/gitbox/contributors.
>
> If we push it off to another list it's just one more list I will need to subscribe to in order to pay attention.
>
> It's all important. In the near future when we are mostly done with the web site, it won't matter.
>
> Craig
>
>
>> On Feb 4, 2021, at 1:04 PM, Bouschen, Michael <Mi...@akquinet.de.INVALID> wrote:
>>
>> Hi Tilmann,
>>
>> yes, I'll put it one the agenda.
>>
>> Regards Michael
>>
>> yes it does, we merged 4 (or 5?) PRs today, but I agree it is a bit noisy.
>>
>> @Michael, should we put this on the agenda for next time?
>>
>> tilmann
>>
>>
>>
>> On 04/02/2021 21:29, Bryan Pendleton wrote:
>> Seems like the new website machinery generates a lot of messages?
>>
>> bryan
>>
>> ---------- Forwarded message ---------
>> From: GitBox <git@apache.org <ma...@apache.org>><mailto:git@apache.org <ma...@apache.org>>
>> Date: Thu, Feb 4, 2021 at 11:20 AM
>> Subject: [GitHub] [db-jdo-site] tzaeschke merged pull request #19:
>> Update pom.xml
>> To: <jdo-dev@db.apache.org <ma...@db.apache.org>><mailto:jdo-dev@db.apache.org <ma...@db.apache.org>>
>>
>>
>>
>> tzaeschke merged pull request #19:
>> URL: https://github.com/apache/db-jdo-site/pull/19 <https://github.com/apache/db-jdo-site/pull/19>
>>
>>
>>
>>
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org <ma...@infra.apache.org><mailto:users@infra.apache.org <ma...@infra.apache.org>>
>>
>>
>> --
>> Michael Bouschen
>> akquinet tech@spree GmbH
>> Bülowstraße 66 • D-10783 Berlin
>> Tel: +49 30 235520-33
>> Fax: +49 30 217520-12
>>
>> E-Mail: michael.bouschen@akquinet.de <ma...@akquinet.de><mailto:michael.bouschen@akquinet.de <ma...@akquinet.de>>
>> Web: www.akquinet.de <http://www.akquinet.de/><http://www.akquinet.de/ <http://www.akquinet.de/>>
>>
>> Geschäftsführung: Martin Weber, Dr. Torsten Fink, Heinz Wilming
>> Amtsgericht Berlin HRB 86780 • USt.-Id. Nr.: DE 225 964 680
>>
>> [Facebook]<http://www.facebook.com/akquinet <http://www.facebook.com/akquinet>> [XING]<https://www.xing.com/companies/akquinetag <https://www.xing.com/companies/akquinetag>> [LinkedIn]<https://www.linkedin.com/company/akquinet-ag <https://www.linkedin.com/company/akquinet-ag>> [Twitter]<https://twitter.com/akquinet <https://twitter.com/akquinet>>
>
Re: Is it worth establishing a separate mailing list for the GitHub
message traffic?
Posted by JDO Spec <ap...@gmail.com>.
Personally, I have no problem with the number of messages on the jdo-dev list that come from github/gitbox/contributors.
If we push it off to another list it's just one more list I will need to subscribe to in order to pay attention.
It's all important. In the near future when we are mostly done with the web site, it won't matter.
Craig
> On Feb 4, 2021, at 1:04 PM, Bouschen, Michael <Mi...@akquinet.de.INVALID> wrote:
>
> Hi Tilmann,
>
> yes, I'll put it one the agenda.
>
> Regards Michael
>
> yes it does, we merged 4 (or 5?) PRs today, but I agree it is a bit noisy.
>
> @Michael, should we put this on the agenda for next time?
>
> tilmann
>
>
>
> On 04/02/2021 21:29, Bryan Pendleton wrote:
> Seems like the new website machinery generates a lot of messages?
>
> bryan
>
> ---------- Forwarded message ---------
> From: GitBox <git@apache.org <ma...@apache.org>><mailto:git@apache.org <ma...@apache.org>>
> Date: Thu, Feb 4, 2021 at 11:20 AM
> Subject: [GitHub] [db-jdo-site] tzaeschke merged pull request #19:
> Update pom.xml
> To: <jdo-dev@db.apache.org <ma...@db.apache.org>><mailto:jdo-dev@db.apache.org <ma...@db.apache.org>>
>
>
>
> tzaeschke merged pull request #19:
> URL: https://github.com/apache/db-jdo-site/pull/19 <https://github.com/apache/db-jdo-site/pull/19>
>
>
>
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org <ma...@infra.apache.org><mailto:users@infra.apache.org <ma...@infra.apache.org>>
>
>
> --
> Michael Bouschen
> akquinet tech@spree GmbH
> Bülowstraße 66 • D-10783 Berlin
> Tel: +49 30 235520-33
> Fax: +49 30 217520-12
>
> E-Mail: michael.bouschen@akquinet.de <ma...@akquinet.de><mailto:michael.bouschen@akquinet.de <ma...@akquinet.de>>
> Web: www.akquinet.de <http://www.akquinet.de/><http://www.akquinet.de/ <http://www.akquinet.de/>>
>
> Geschäftsführung: Martin Weber, Dr. Torsten Fink, Heinz Wilming
> Amtsgericht Berlin HRB 86780 • USt.-Id. Nr.: DE 225 964 680
>
> [Facebook]<http://www.facebook.com/akquinet <http://www.facebook.com/akquinet>> [XING]<https://www.xing.com/companies/akquinetag <https://www.xing.com/companies/akquinetag>> [LinkedIn]<https://www.linkedin.com/company/akquinet-ag <https://www.linkedin.com/company/akquinet-ag>> [Twitter]<https://twitter.com/akquinet <https://twitter.com/akquinet>>
Re: Is it worth establishing a separate mailing list for the GitHub
message traffic?
Posted by "Bouschen, Michael" <Mi...@akquinet.de.INVALID>.
Hi Tilmann,
yes, I'll put it one the agenda.
Regards Michael
yes it does, we merged 4 (or 5?) PRs today, but I agree it is a bit noisy.
@Michael, should we put this on the agenda for next time?
tilmann
On 04/02/2021 21:29, Bryan Pendleton wrote:
Seems like the new website machinery generates a lot of messages?
bryan
---------- Forwarded message ---------
From: GitBox <gi...@apache.org>
Date: Thu, Feb 4, 2021 at 11:20 AM
Subject: [GitHub] [db-jdo-site] tzaeschke merged pull request #19:
Update pom.xml
To: <jd...@db.apache.org>
tzaeschke merged pull request #19:
URL: https://github.com/apache/db-jdo-site/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org<ma...@infra.apache.org>
--
Michael Bouschen
akquinet tech@spree GmbH
Bülowstraße 66 • D-10783 Berlin
Tel: +49 30 235520-33
Fax: +49 30 217520-12
E-Mail: michael.bouschen@akquinet.de<ma...@akquinet.de>
Web: www.akquinet.de<http://www.akquinet.de/>
Geschäftsführung: Martin Weber, Dr. Torsten Fink, Heinz Wilming
Amtsgericht Berlin HRB 86780 • USt.-Id. Nr.: DE 225 964 680
[Facebook]<http://www.facebook.com/akquinet> [XING]<https://www.xing.com/companies/akquinetag> [LinkedIn]<https://www.linkedin.com/company/akquinet-ag> [Twitter]<https://twitter.com/akquinet>
Re: Is it worth establishing a separate mailing list for the GitHub
message traffic?
Posted by Tilmann Zäschke <za...@gmx.de>.
yes it does, we merged 4 (or 5?) PRs today, but I agree it is a bit noisy.
@Michael, should we put this on the agenda for next time?
tilmann
On 04/02/2021 21:29, Bryan Pendleton wrote:
> Seems like the new website machinery generates a lot of messages?
>
> bryan
>
> ---------- Forwarded message ---------
> From: GitBox <gi...@apache.org>
> Date: Thu, Feb 4, 2021 at 11:20 AM
> Subject: [GitHub] [db-jdo-site] tzaeschke merged pull request #19:
> Update pom.xml
> To: <jd...@db.apache.org>
>
>
>
> tzaeschke merged pull request #19:
> URL: https://github.com/apache/db-jdo-site/pull/19
>
>
>
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
Is it worth establishing a separate mailing list for the GitHub
message traffic?
Posted by Bryan Pendleton <bp...@gmail.com>.
Seems like the new website machinery generates a lot of messages?
bryan
---------- Forwarded message ---------
From: GitBox <gi...@apache.org>
Date: Thu, Feb 4, 2021 at 11:20 AM
Subject: [GitHub] [db-jdo-site] tzaeschke merged pull request #19:
Update pom.xml
To: <jd...@db.apache.org>
tzaeschke merged pull request #19:
URL: https://github.com/apache/db-jdo-site/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] tzaeschke merged pull request #19: Update pom.xml
Posted by GitBox <gi...@apache.org>.
tzaeschke merged pull request #19:
URL: https://github.com/apache/db-jdo-site/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] tzaeschke commented on a change in pull request #19: Update pom.xml
Posted by GitBox <gi...@apache.org>.
tzaeschke commented on a change in pull request #19:
URL: https://github.com/apache/db-jdo-site/pull/19#discussion_r568143351
##########
File path: pom.xml
##########
@@ -104,13 +104,22 @@
<goal>copy-resources</goal>
</goals>
<configuration>
- <outputDirectory>${basedir}/docs</outputDirectory>
- <resources>
- <resource>
- <directory>target/site</directory>
- </resource>
- </resources>
- </configuration>
+ <outputDirectory>${basedir}/docs</outputDirectory>
+ <nonFilteredFileExtensions>
+ <nonFilteredFileExtension>pdf</nonFilteredFileExtension>
+ <nonFilteredFileExtension>jar</nonFilteredFileExtension>
+ <nonFilteredFileExtension>html</nonFilteredFileExtension>
+ </nonFilteredFileExtensions>
+ <resources>
+ <resource>
+ <directory>target/site</directory>
+ </resource>
Review comment:
Thanks for reviewing, I cleaned it up a bit. Looks better now :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] tobous commented on a change in pull request #19: Update pom.xml
Posted by GitBox <gi...@apache.org>.
tobous commented on a change in pull request #19:
URL: https://github.com/apache/db-jdo-site/pull/19#discussion_r567447688
##########
File path: pom.xml
##########
@@ -104,13 +104,22 @@
<goal>copy-resources</goal>
</goals>
<configuration>
- <outputDirectory>${basedir}/docs</outputDirectory>
- <resources>
- <resource>
- <directory>target/site</directory>
- </resource>
- </resources>
- </configuration>
+ <outputDirectory>${basedir}/docs</outputDirectory>
+ <nonFilteredFileExtensions>
+ <nonFilteredFileExtension>pdf</nonFilteredFileExtension>
+ <nonFilteredFileExtension>jar</nonFilteredFileExtension>
+ <nonFilteredFileExtension>html</nonFilteredFileExtension>
+ </nonFilteredFileExtensions>
+ <resources>
+ <resource>
+ <directory>target/site</directory>
+ </resource>
Review comment:
The output directory should be the configured build directory as the deploy action just looks at the resources located in `target/site`.
Additionally, the previous configuration moving resources from `target/site` is no longer necessary. It was previously used to move the build results into the `docs` directory.
And, as a minor change, I don't think the filter exceptions are necessary as filtering is explicitly disabled for the resource.
```suggestion
<outputDirectory>${build.dir}</outputDirectory>
<resources>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [db-jdo-site] tzaeschke merged pull request #19: Update pom.xml
Posted by GitBox <gi...@apache.org>.
tzaeschke merged pull request #19:
URL: https://github.com/apache/db-jdo-site/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org