You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@trafficcontrol.apache.org by "Fieck, Brennan" <Br...@comcast.com> on 2018/12/19 20:42:59 UTC

Re: [EXTERNAL] Re: New Golang db/admin binary for Traffic Ops DB administration

I think it'd be simple enough to add a deprecation notice to the documentation:

    .. deprecated:: 3.0.0
         Version 3.0.0 of Traffic Control supports both the legacy Perl script :file:`traffic_ops/app/db/admin.pl` and the new Go binary :program:`admin`. The Perl script will be removed in Traffic Control 4.0.0.
________________________________________
From: Rawlin Peters <ra...@gmail.com>
Sent: Wednesday, December 19, 2018 12:39 PM
To: users@trafficcontrol.apache.org
Subject: [EXTERNAL] Re: New Golang db/admin binary for Traffic Ops DB administration

Well, 3.0 is already heading out the door, and if we continue pulling
stuff into it we will never get it released. I added a deprecation
warning to the admin.pl script that prints to stderr whenever the
script is run, but it doesn't explicitly say which release it will be
removed in. That was mostly intentional so that we can remove it in
_whatever the next release is_ since we don't really have a solid
release schedule. Should I just add to the deprecation warning that
users have until 5.0 to switch over to using the binary version?

- Rawlin

On Wed, Dec 19, 2018 at 11:44 AM Robert Butts <ro...@apache.org> wrote:
>
> >This new db/admin binary will land in whatever minor/major Traffic
> >Control release is after 3.0.0, and the db/admin.pl script will most
> >likely be removed in the release following that. So, it's best to
> >switch to using the new db/admin binary as soon as it is available to
> >you.
>
> Deprecation should be explicit and unambiguous. We should declare that admin.pl is deprecated in 3.0 and WILL be removed in 4.0, and add documentation and code comments to that effect. Unless there's an objection to removing it.
>
>
>
> On Tue, Dec 18, 2018 at 5:24 PM Rawlin Peters <ra...@gmail.com> wrote:
>>
>> Hey all,
>>
>> If you build a recent version of Traffic Ops from the master branch,
>> you should now see a binary executable at
>> /opt/traffic_ops/app/db/admin. This binary has all the same
>> functionality as the admin.pl script which it is meant to replace. The
>> admin binary supports the same options+commands as the admin.pl script
>> and should be used in place of admin.pl at your earliest convenience.
>> If you have scripts/tooling/automation that calls the admin.pl script,
>> it should be as simple as just removing the ".pl" suffix wherever
>> you're currently calling it.
>>
>> This new db/admin binary will land in whatever minor/major Traffic
>> Control release is after 3.0.0, and the db/admin.pl script will most
>> likely be removed in the release following that. So, it's best to
>> switch to using the new db/admin binary as soon as it is available to
>> you.
>>
>> If you have a dev environment that wasn't built from the traffic_ops
>> rpm, you can build the db/admin binary yourself like this in order to
>> use it:
>>
>> cd traffic_ops/app/db
>> go build -o admin
>>
>> Regards,
>> Rawlin

Re: [EXTERNAL] Re: New Golang db/admin binary for Traffic Ops DB administration

Posted by Dan Kirkwood <da...@gmail.com>.
that still requires us to include the new Go admin tool in 3.0.0.    I'm
with Rawlin -- we can't keep adding to it or it'll never go out.

-dan

On Wed, Dec 19, 2018 at 1:43 PM Fieck, Brennan <Br...@comcast.com>
wrote:

> I think it'd be simple enough to add a deprecation notice to the
> documentation:
>
>     .. deprecated:: 3.0.0
>          Version 3.0.0 of Traffic Control supports both the legacy Perl
> script :file:`traffic_ops/app/db/admin.pl` and the new Go binary
> :program:`admin`. The Perl script will be removed in Traffic Control 4.0.0.
> ________________________________________
> From: Rawlin Peters <ra...@gmail.com>
> Sent: Wednesday, December 19, 2018 12:39 PM
> To: users@trafficcontrol.apache.org
> Subject: [EXTERNAL] Re: New Golang db/admin binary for Traffic Ops DB
> administration
>
> Well, 3.0 is already heading out the door, and if we continue pulling
> stuff into it we will never get it released. I added a deprecation
> warning to the admin.pl script that prints to stderr whenever the
> script is run, but it doesn't explicitly say which release it will be
> removed in. That was mostly intentional so that we can remove it in
> _whatever the next release is_ since we don't really have a solid
> release schedule. Should I just add to the deprecation warning that
> users have until 5.0 to switch over to using the binary version?
>
> - Rawlin
>
> On Wed, Dec 19, 2018 at 11:44 AM Robert Butts <ro...@apache.org> wrote:
> >
> > >This new db/admin binary will land in whatever minor/major Traffic
> > >Control release is after 3.0.0, and the db/admin.pl script will most
> > >likely be removed in the release following that. So, it's best to
> > >switch to using the new db/admin binary as soon as it is available to
> > >you.
> >
> > Deprecation should be explicit and unambiguous. We should declare that
> admin.pl is deprecated in 3.0 and WILL be removed in 4.0, and add
> documentation and code comments to that effect. Unless there's an objection
> to removing it.
> >
> >
> >
> > On Tue, Dec 18, 2018 at 5:24 PM Rawlin Peters <ra...@gmail.com>
> wrote:
> >>
> >> Hey all,
> >>
> >> If you build a recent version of Traffic Ops from the master branch,
> >> you should now see a binary executable at
> >> /opt/traffic_ops/app/db/admin. This binary has all the same
> >> functionality as the admin.pl script which it is meant to replace. The
> >> admin binary supports the same options+commands as the admin.pl script
> >> and should be used in place of admin.pl at your earliest convenience.
> >> If you have scripts/tooling/automation that calls the admin.pl script,
> >> it should be as simple as just removing the ".pl" suffix wherever
> >> you're currently calling it.
> >>
> >> This new db/admin binary will land in whatever minor/major Traffic
> >> Control release is after 3.0.0, and the db/admin.pl script will most
> >> likely be removed in the release following that. So, it's best to
> >> switch to using the new db/admin binary as soon as it is available to
> >> you.
> >>
> >> If you have a dev environment that wasn't built from the traffic_ops
> >> rpm, you can build the db/admin binary yourself like this in order to
> >> use it:
> >>
> >> cd traffic_ops/app/db
> >> go build -o admin
> >>
> >> Regards,
> >> Rawlin
>