You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/07/26 18:06:55 UTC

[GitHub] spark pull request #21847: [SPARK-24855][SQL][EXTERNAL]: Built-in AVRO suppo...

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21847#discussion_r205550412
  
    --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala ---
    @@ -165,16 +183,100 @@ class AvroSerializer(rootCatalystType: DataType, rootAvroType: Schema, nullable:
           result
       }
     
    -  private def resolveNullableType(avroType: Schema, nullable: Boolean): Schema = {
    -    if (nullable) {
    +  private def resolveNullableType(avroType: Schema, catalystType: DataType,
    --- End diff --
    
    Not caused by this PR, but we better explain what this method does. Can you add a comment for it?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org