You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2020/05/17 19:16:26 UTC
[maven-wagon] 01/02: Add more TODOs and FIXMEs
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch WAGON-593
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
commit d378806d60bbc2bb5d90869d01b5072e81eed0de
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Mon May 11 22:39:39 2020 +0200
Add more TODOs and FIXMEs
---
.../org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java | 1 +
.../java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java | 2 ++
2 files changed, 3 insertions(+)
diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
index 1d2bf0f..9bedabc 100644
--- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
+++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
@@ -1013,6 +1013,7 @@ public abstract class AbstractHttpClientWagon
{
// TODO: merge with the other headers and have some better defaults, unify with lightweight headers
method.addHeader( "Cache-control", "no-cache" );
+ // FIXME This header does not exist, remove it
method.addHeader( "Cache-store", "no-store" );
method.addHeader( "Pragma", "no-cache" );
}
diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java
index 3c82851..36b97f9 100755
--- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java
+++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java
@@ -54,6 +54,7 @@ public class ConfigurationUtils
private static final String MAX_REDIRECTS = "http.protocol.max-redirects";
private static final String HANDLE_REDIRECTS = "http.protocol.handle-redirects";
private static final String REJECT_RELATIVE_REDIRECT = "http.protocol.reject-relative-redirect";
+ // TODO Add contentCompressionEnabled and normalizeUri
private static final String COERCE_PATTERN = "%(\\w+),(.+)";
@@ -100,6 +101,7 @@ public class ConfigurationUtils
}
else if ( key.equals( DEFAULT_PROXY ) )
{
+ // FIXME This passes host only, ignoring the port
builder.setProxy( new HttpHost( value ) );
}
else if ( key.equals( LOCAL_ADDRESS ) )