You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/02/13 08:19:42 UTC

[GitHub] [skywalking-python] Superskyyy commented on a change in pull request #181: Add plugin for FastAPI

Superskyyy commented on a change in pull request #181:
URL: https://github.com/apache/skywalking-python/pull/181#discussion_r805298272



##########
File path: skywalking/plugins/sw_fastapi.py
##########
@@ -0,0 +1,79 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from skywalking import Layer, Component, config
+from skywalking.trace.carrier import Carrier
+from skywalking.trace.context import get_context, NoopContext
+from skywalking.trace.span import NoopSpan
+from skywalking.trace.tags import TagHttpMethod, TagHttpURL, TagHttpStatusCode, TagHttpParams
+
+link_vector = ['https://fastapi.tiangolo.com']
+support_matrix = {
+    'fastapi': {
+        '>=3.6': ['0.70.1']
+    }
+}
+note = """"""
+
+
+def install():
+    from starlette.types import Receive, Scope, Send, Message
+    from starlette.exceptions import ExceptionMiddleware
+
+    _original_fast_api = ExceptionMiddleware.__call__
+
+    def params_tostring(params):
+        return '\n'.join([f"{k}=[{','.join(params.getlist(k))}]" for k, _ in params.items()])
+
+    async def _sw_fast_api(self, scope: Scope, receive: Receive, send: Send):
+        from starlette.requests import Request
+
+        req = Request(scope, receive=receive, send=send)
+        carrier = Carrier()
+        method = req.method
+
+        for item in carrier:
+            if item.key.capitalize() in req.headers:
+                item.val = req.headers[item.key.capitalize()]
+
+        span = NoopSpan(NoopContext()) if config.ignore_http_method_check(method) \
+            else get_context().new_entry_span(op=dict(scope)['path'], carrier=carrier, inherit=Component.General)
+
+        with span:
+            span.layer = Layer.Http
+            span.component = Component.FastApi
+            span.peer = f'{req.client.host}:{req.client.port}'
+            span.tag(TagHttpMethod(method))
+            span.tag(TagHttpURL(req.url._url.split('?')[0]))
+            if config.fastapi_collect_http_params and req.values:
+                span.tag(TagHttpParams(params_tostring(req.values)[0:config.http_params_length_threshold]))

Review comment:
       This should be something like `req.query_params` right? `req` is an object of type `MutableMapping(Request)` which has the method `values` inherited. Your code is trying to parse a function instead of the actual query parameter dict, that's why it fails.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org