You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Keith Berkoben (JIRA)" <ji...@apache.org> on 2017/06/19 16:48:00 UTC

[jira] [Comment Edited] (BEAM-2451) writeProtos() should allow a user to specify message attributes

    [ https://issues.apache.org/jira/browse/BEAM-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054303#comment-16054303 ] 

Keith Berkoben edited comment on BEAM-2451 at 6/19/17 4:47 PM:
---------------------------------------------------------------

What values are used for the timestamp and ID when withTimestampAttribute() and withIdAttribute() are set? 


was (Author: berkoben):
What values are used for the timestamp and ID when withTimestampAttribute() and withIdAttribute() is set? 

> writeProtos() should allow a user to specify message attributes
> ---------------------------------------------------------------
>
>                 Key: BEAM-2451
>                 URL: https://issues.apache.org/jira/browse/BEAM-2451
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>    Affects Versions: 2.0.0
>            Reporter: Keith Berkoben
>            Assignee: Reuven Lax
>
> when using PubsubIO.writeProtos(protoMessage), the PubsubMessage is created in the background and there is no way to specify the attributes of the message.  This makes the method useless if a user wants to then use the withTimestampAttribute() or withIdAttribute() of the writer with anything other than the default timestamp or ID (a common use case).  
> As a workaround the user can manually create the PubsubMessage, but this basically requires duplication of the writeProtos() logic, which is brittle in the case that the encoding logic changes.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)