You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/01 15:55:39 UTC

[GitHub] [ozone] errose28 opened a new pull request #1645: HDDS-4463. Verify that no node can start when Software Layout Version < Metadata Layout Version.

errose28 opened a new pull request #1645:
URL: https://github.com/apache/ozone/pull/1645


   ## What changes were proposed in this pull request?
   
   Add tests for OzoneManager, StorageContainerManager, and DatanodeStateMachine classes that will verify an Exception is thrown on startup when the metadata layout version on disk is larger than the software version of the component.
   
   ## What is the link to the Apache JIRA
   
   HDDS-4463
   
   ## How was this patch tested?
   
   Added tests pass.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on pull request #1645: HDDS-4463. Verify that no node can start when Software Layout Version < Metadata Layout Version.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1645:
URL: https://github.com/apache/ozone/pull/1645#issuecomment-737603166


   Test failure seems unrelated.  I ran it multiple times on local setup with the patch, but could not reproduce it. Since this is a test only change to feature branch, overriding CI failure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on a change in pull request #1645: HDDS-4463. Verify that no node can start when Software Layout Version < Metadata Layout Version.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #1645:
URL: https://github.com/apache/ozone/pull/1645#discussion_r533596046



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -43,7 +43,7 @@
   public static final String STORAGE_ID = "storageID";
   public static final String DATANODE_UUID = "datanodeUuid";
   public static final String CLUSTER_ID = "clusterID";
-  public static final String LAYOUTVERSION = "layOutVersion";
+  public static final String LAYOUTVERSION = "layoutVersion";

Review comment:
       Changing this may break backward compatibility in the Datanode since the value of this constant is written down to and read from the Version file. We can either leave it as it is, or make sure that the writers always use "layoutVersion", and the readers fall back to "layOutVersion" if the default is not present.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on pull request #1645: HDDS-4463. Verify that no node can start when Software Layout Version < Metadata Layout Version.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1645:
URL: https://github.com/apache/ozone/pull/1645#issuecomment-736979522


   @errose28 The CI failure looks related. Please take a look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on a change in pull request #1645: HDDS-4463. Verify that no node can start when Software Layout Version < Metadata Layout Version.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #1645:
URL: https://github.com/apache/ozone/pull/1645#discussion_r533596046



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##########
@@ -43,7 +43,7 @@
   public static final String STORAGE_ID = "storageID";
   public static final String DATANODE_UUID = "datanodeUuid";
   public static final String CLUSTER_ID = "clusterID";
-  public static final String LAYOUTVERSION = "layOutVersion";
+  public static final String LAYOUTVERSION = "layoutVersion";

Review comment:
       Changing this may break backward compatibility since the value of this constant is written down to and read from the Version file. We can keep this as it is.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on pull request #1645: HDDS-4463. Verify that no node can start when Software Layout Version < Metadata Layout Version.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1645:
URL: https://github.com/apache/ozone/pull/1645#issuecomment-737603349


   Thanks for the contribution @errose28.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx merged pull request #1645: HDDS-4463. Verify that no node can start when Software Layout Version < Metadata Layout Version.

Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #1645:
URL: https://github.com/apache/ozone/pull/1645


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org