You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/10/11 17:20:13 UTC

[kudu-CR] [doc] added link to the online Kudu C++ API doc 

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4684

Change subject: [doc] added link to the online Kudu C++ API doc
......................................................................

[doc] added link to the online Kudu C++ API doc

Added link to the auto-generated doxygen documentaion for the Kudu
C++ client API.  Besides, fixed broken 'build_from_source' links.

Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
---
M docs/installation.adoc
1 file changed, 19 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/4684/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4684/4/docs/installation.adoc
File docs/installation.adoc:

PS4, Line 648: Besides, the in-line documentation for the C++ client API is included in the
             : header files in `/usr/include/kudu/` if you installed Kudu using packages or
             : subdirectories of `src/kudu/client/` if you built Kudu from source. If you
             : installed Kudu using parcels, no headers are included in your installation,
             : and you will need to <<build_from_source,build Kudu from source>> in order
             : to have access to the headers and shared libraries.
             : 
             : The following command is a naive approach to finding relevant header files. Use
             : of any APIs other than the client APIs is unsupported.
             : 
             : [source,bash]
             : ----
             : $ find /usr/include/kudu -type f -name *.h
             : ----
> I would be in favor of removing these paragraphs.  Now that we have doxygen
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4684/3/docs/installation.adoc
File docs/installation.adoc:

PS3, Line 637: build_from_source
> That's the implicitly generated anchor.  I would prefer to use an explicit 
I've just asked Misty regarding use of implicit vs explicit anchors in for AsciiDoc documents.  Misty prefers the explicit ones.

OK, since at least one AsciiDoctor expert recommended using explicit anchors and there are no strong objections, let's use those.


-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4684

to look at the new patch set (#5).

Change subject: [doc] added link to online Kudu C++ client API
......................................................................

[doc] added link to online Kudu C++ client API

Added link to the auto-generated doxygen documentaion for the Kudu
C++ client API.  Besides, fixed broken 'build_from_source' links.

Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
---
M docs/installation.adoc
1 file changed, 11 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/4684/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4684

to look at the new patch set (#4).

Change subject: [doc] added link to online Kudu C++ client API
......................................................................

[doc] added link to online Kudu C++ client API

Added link to the auto-generated doxygen documentaion for the Kudu
C++ client API.  Besides, fixed broken 'build_from_source' links.

Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
---
M docs/installation.adoc
1 file changed, 19 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/4684/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 4:

> Could you also add the link to this section: https://kudu.apache.org/docs/developing.html#_viewing_the_api_documentation

As I understand, the developing.adoc automatically gets this link:

--- Snippet from developing.adoc begins ---

== Viewing the API Documentation
include::installation.adoc[tags=view_api]


--- Snippet from developing.adoc ends ---

-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 3:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/4684/3/docs/installation.adoc
File docs/installation.adoc:

Line 236: [[build_from_source]]
not needed


PS3, Line 637:   
nit: extra blank space


PS3, Line 637: build_from_source
use _build_from_source


PS3, Line 639:  
nit: by* opening


PS3, Line 639:  
nit: the* locally


PS3, Line 643: installated
nit: installed*


PS3, Line 643:   
nit: extra blank space


PS3, Line 645: the
nit: remove


-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 2:

Could you also add the link to this section: https://kudu.apache.org/docs/developing.html#_viewing_the_api_documentation

-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 2:

> Could you also add the link to this section: https://kudu.apache.org/docs/developing.html#_viewing_the_api_documentation

It's there already: the docs/developing.adoc contains a link to this document, as I understand:

== Viewing the API Documentation
include::installation.adoc[tags=view_api]

-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4684/2/docs/installation.adoc
File docs/installation.adoc:

PS2, Line 636: ]
> A space needed after this ?
There is a new line after the closing bracket which works as a space in the generated doc, I think.  Do I miss something?


-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


[doc] added link to online Kudu C++ client API

Added link to the auto-generated doxygen documentaion for the Kudu
C++ client API.  Besides, fixed broken 'build_from_source' links.

Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Reviewed-on: http://gerrit.cloudera.org:8080/4684
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@cloudera.com>
---
M docs/installation.adoc
1 file changed, 11 insertions(+), 12 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4684/3/docs/installation.adoc
File docs/installation.adoc:

PS3, Line 637: build_from_source
> use _build_from_source
That's the implicitly generated anchor.  I would prefer to use an explicit one, because
* it's easier to locate and check whether it's present at all
* if somebody changing the title, those links stay valid.

Anyway, per your recommendation, I asked Misty about using implicit anchors instead of explicit ones.  Let's see what she says.


PS3, Line 637:   
> nit: extra blank space
Done


PS3, Line 639:  
> nit: by* opening
Done


PS3, Line 639:  
> nit: the* locally
Done


PS3, Line 643: installated
> nit: installed*
Done


PS3, Line 643:   
> nit: extra blank space
Done


PS3, Line 645: the
> nit: remove
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4684

to look at the new patch set (#3).

Change subject: [doc] added link to online Kudu C++ client API
......................................................................

[doc] added link to online Kudu C++ client API

Added link to the auto-generated doxygen documentaion for the Kudu
C++ client API.  Besides, fixed broken 'build_from_source' links.

Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
---
M docs/installation.adoc
1 file changed, 19 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/4684/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4684/2/docs/installation.adoc
File docs/installation.adoc:

PS2, Line 636: ]
A space needed after this ?


-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4684/4/docs/installation.adoc
File docs/installation.adoc:

PS4, Line 648: Besides, the in-line documentation for the C++ client API is included in the
             : header files in `/usr/include/kudu/` if you installed Kudu using packages or
             : subdirectories of `src/kudu/client/` if you built Kudu from source. If you
             : installed Kudu using parcels, no headers are included in your installation,
             : and you will need to <<build_from_source,build Kudu from source>> in order
             : to have access to the headers and shared libraries.
             : 
             : The following command is a naive approach to finding relevant header files. Use
             : of any APIs other than the client APIs is unsupported.
             : 
             : [source,bash]
             : ----
             : $ find /usr/include/kudu -type f -name *.h
             : ----
I would be in favor of removing these paragraphs.  Now that we have doxygen, it doesn't really seem useful to tell people to go read the source.  Anyone who wants to do that is already going to know how.  It also keeps it consistent with the Java section.


-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4684/2/docs/installation.adoc
File docs/installation.adoc:

PS2, Line 636: n
> There is a new line after the closing bracket which works as a space in the
Yeah, I happen to see Javadoc example below earlier. I think wrap-arounds in adoc doesn't necessarily match with newlines in gh-pages. Please make sure generated docs via make_site.sh has generated the text as per our assumptions.


-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).

Change subject: [doc] added link to online Kudu C++ client API
......................................................................

[doc] added link to online Kudu C++ client API

Added link to the auto-generated doxygen documentaion for the Kudu
C++ client API.  Besides, fixed broken 'build_from_source' links.

Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
---
M docs/installation.adoc
1 file changed, 19 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/4684/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [doc] added link to online Kudu C++ client API

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: [doc] added link to online Kudu C++ client API
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4d77b9b154b635c4aedaced9b050942529cf65f
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No