You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/25 04:35:05 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #35653: [SPARK-38318][SQL] Skip view cyclic reference check when storeAnalyzedPlan = true
cloud-fan commented on a change in pull request #35653:
URL: https://github.com/apache/spark/pull/35653#discussion_r814468315
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -614,7 +614,11 @@ object ViewHelper extends SQLConfHelper with Logging {
}.getOrElse(false)
if (replace && uncache) {
logDebug(s"Try to uncache ${name.quotedString} before replacing.")
- checkCyclicViewReference(analyzedPlan, Seq(name), name)
+ if (!conf.storeAnalyzedPlanForView) {
Review comment:
how about `!conf.storeAnalyzedPlanForView && originalText.nonEmpty`? It also matches the condition below where we decide to store analyzed plan.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -614,7 +614,11 @@ object ViewHelper extends SQLConfHelper with Logging {
}.getOrElse(false)
if (replace && uncache) {
logDebug(s"Try to uncache ${name.quotedString} before replacing.")
- checkCyclicViewReference(analyzedPlan, Seq(name), name)
+ if (!conf.storeAnalyzedPlanForView) {
Review comment:
how about `!conf.storeAnalyzedPlanForView && originalText.nonEmpty`? It also matches the if condition below where we decide to store analyzed plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org