[GitHub] [airflow] dstandish commented on a diff in pull request #26766: Allow xcom sidecar container image to be configurable

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #26766:
URL: https://github.com/apache/airflow/pull/26766#discussion_r988313951


##########
kubernetes_tests/test_kubernetes_pod_operator.py:
##########
@@ -918,6 +918,7 @@ def test_pod_template_file(
     ):
         # todo: This isn't really a system test
         await_xcom_sidecar_container_start_mock.return_value = None
+        hook_mock.return_value.get_xcom_sidecar_container_image.return_value = "alpine"

Review Comment:
   seems you should not need this change?



##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -837,6 +837,7 @@ def test_push_xcom_pod_info(
         self, mock_await_xcom_sidecar_container_start, mock_extract_xcom, do_xcom_push
     ):
         """pod name and namespace are *always* pushed; do_xcom_push only controls xcom sidecar"""
+        self.hook_mock.return_value.get_xcom_sidecar_container_image.return_value = "alpine"

Review Comment:
   seems you should not need this change?



##########
tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py:
##########
@@ -893,6 +894,7 @@ def test_mark_checked_unexpected_exception(self, mock_patch_already_checked, moc
     @mock.patch(f"{POD_MANAGER_CLASS}.await_xcom_sidecar_container_start")
     def test_wait_for_xcom_sidecar_iff_push_xcom(self, mock_await, mock_extract_xcom, do_xcom_push):
         """Assert we wait for xcom sidecar container if and only if we push xcom."""
+        self.hook_mock.return_value.get_xcom_sidecar_container_image.return_value = "alpine"

Review Comment:
   seems you should not need this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org