You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by yh...@apache.org on 2023/12/13 15:46:51 UTC

(beam) branch master updated: Add logs to confirm JvmInitializer completed running and Spanner successfully connected. (#29727)

This is an automated email from the ASF dual-hosted git repository.

yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 06c3340e338 Add logs to confirm JvmInitializer completed running and Spanner successfully connected. (#29727)
06c3340e338 is described below

commit 06c3340e338ab380f7f5a18b11d7ed8cbe0f8bd0
Author: Tom Stepp <to...@gmail.com>
AuthorDate: Wed Dec 13 07:46:43 2023 -0800

    Add logs to confirm JvmInitializer completed running and Spanner successfully connected. (#29727)
    
    * Add logs to confirm JvmInitializer completed running.
    
    * Add log to confirm Spanner successfully connected.
---
 .../src/main/java/org/apache/beam/sdk/fn/JvmInitializers.java           | 2 ++
 .../main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java   | 1 +
 2 files changed, 3 insertions(+)

diff --git a/sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/JvmInitializers.java b/sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/JvmInitializers.java
index c12adf8c02f..f739a797af8 100644
--- a/sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/JvmInitializers.java
+++ b/sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/JvmInitializers.java
@@ -35,6 +35,7 @@ public class JvmInitializers {
       // We write to standard out since logging has yet to be initialized.
       System.out.format("Running JvmInitializer#onStartup for %s%n", initializer);
       initializer.onStartup();
+      System.out.format("Completed JvmInitializer#onStartup for %s%n", initializer);
     }
   }
 
@@ -52,6 +53,7 @@ public class JvmInitializers {
     for (JvmInitializer initializer : ReflectHelpers.loadServicesOrdered(JvmInitializer.class)) {
       logger.info("Running JvmInitializer#beforeProcessing for {}", initializer);
       initializer.beforeProcessing(options);
+      logger.info("Completed JvmInitializer#beforeProcessing for {}", initializer);
     }
   }
 }
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
index bdfc933b5c7..471fe0329bf 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
@@ -98,6 +98,7 @@ public class SpannerAccessor implements AutoCloseable {
           // Connect to spanner for this SpannerConfig.
           LOG.info("Connecting to {}", spannerConfig);
           self = SpannerAccessor.createAndConnect(spannerConfig);
+          LOG.info("Successfully connected to {}", spannerConfig);
           spannerAccessors.put(spannerConfig, self);
           refcounts.putIfAbsent(spannerConfig, new AtomicInteger(0));
         }