You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/05 02:41:14 UTC
[GitHub] [kafka] kowshik opened a new pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration
kowshik opened a new pull request #9561:
URL: https://github.com/apache/kafka/pull/9561
In this PR, I've switched the `FeatureZNodeStatus` enum to be a sealed trait. In Scala, we prefer sealed traits over Enumeration since the former gives you exhaustiveness checking. With Scala enumeration, you don't get a warning if you add a new value that is not handled in a given pattern match.
**Test plan:**
Rely on existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik edited a comment on pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration
Posted by GitBox <gi...@apache.org>.
kowshik edited a comment on pull request #9561:
URL: https://github.com/apache/kafka/pull/9561#issuecomment-722113042
The build in CI is broken due to absence of https://github.com/apache/kafka/pull/9559. I'll rebase on top of latest AK trunk, after that PR is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9561:
URL: https://github.com/apache/kafka/pull/9561#issuecomment-722113042
The build in CI is broken due to https://github.com/apache/kafka/pull/9559 . I'll rebase on top of latest AK trunk, after that PR is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9561:
URL: https://github.com/apache/kafka/pull/9561#issuecomment-722644136
I've rebased on top of #9559 now. So the build failure(s) should be gone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #9561:
URL: https://github.com/apache/kafka/pull/9561
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kowshik commented on pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration
Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #9561:
URL: https://github.com/apache/kafka/pull/9561#issuecomment-722097335
@junrao @abbccdda: this PR is ready for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org