You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/07 10:25:05 UTC
[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #33:
[Feature] Support top N entities and thermodynamic metrics
kezhenxu94 opened a new pull request #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33
### Motivation
Support top N entities and thermodynamic metrics commands
### Result
- Commands `metrics top n` and `thermodynamic` are added
- Closes https://github.com/apache/skywalking/issues/3898
- Closes https://github.com/apache/skywalking/issues/3897
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #33: [Feature]
Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596076068
> Heatmap without graph?
The Ascii Graph lib doesn't support heat map for now, we may need to implement ourselves, but it takes a lot of efforts, will consider in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #33:
[Feature] Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596072259
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=h1) Report
> Merging [#33](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/53d1395a48c506247df6554730644d1c5b46ea60?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 7 7
Lines 112 112
=======================================
Hits 64 64
Misses 40 40
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=footer). Last update [53d1395...09852ce](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] arugal commented on a change in pull request #33:
[Feature] Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#discussion_r389245498
##########
File path: README.md
##########
@@ -395,6 +425,50 @@ $ ./bin/swctl-latest-darwin-amd64 --display=graph --debug metrics multiple-linea
<details>
+<summary>Query the top 5 services whose sla is largest</summary>
+
+```shell
+$ ./bin/swctl metrics top 5 --name service_sla
+[{"name":"projectB","id":"2","value":10000},{"name":"projectC","id":"3","value":10000},{"name":"projectA","id":"4","value":10000},{"name":"projectD","id":"5","value":10000}]
+```
+
+</details>
+
+<details>
+
+<summary>Query the top 5 instances whose sla is largest, of service (id = 3)</summary>
+
+```shell
+$ ./bin/swctl metrics top 5 --name service_instance_sla --service-id 3
+[{"name":"projectC-pid:30335@skywalking-server-0002","id":"13","value":10000},{"name":"projectC-pid:22037@skywalking-server-0001","id":"2","value":10000}]
+```
+
+</details>
+
+<details>
+
+<summary>Query the top 5 endpoints whose sla is largest, of service (id = 3)</summary>
+
+```shell
+$ ./bin/swctl metrics top 5 --name endpoint_sla --service-id 3
+[{"name":"/projectC/{value}","id":"4","value":10000}]
+```
+
+</details>
+
+<details>
+
+<summary>Query the overall heatmap</summary>
+
+```shell
+$ ./bin/swctl-latest-darwin-amd64 metrics thermodynamic --name all_heatmap
Review comment:
`swctl-latest-darwin-amd64`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io commented on issue #33: [Feature]
Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596072259
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=h1) Report
> Merging [#33](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/6542344a89605f04fa32471da4bd5575df677bee?src=pr&el=desc) will **increase** coverage by `2.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 54.45% 57.14% +2.68%
==========================================
Files 6 7 +1
Lines 101 112 +11
==========================================
+ Hits 55 64 +9
- Misses 39 40 +1
- Partials 7 8 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [graphql/utils/adapter.go](https://codecov.io/gh/apache/skywalking-cli/pull/33/diff?src=pr&el=tree#diff-Z3JhcGhxbC91dGlscy9hZGFwdGVyLmdv) | `81.81% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=footer). Last update [6542344...6308893](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #33: [Feature] Support
top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596075529
Heatmap without graph?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #33:
[Feature] Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596072259
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=h1) Report
> Merging [#33](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/53d1395a48c506247df6554730644d1c5b46ea60?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 7 7
Lines 112 112
=======================================
Hits 64 64
Misses 40 40
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=footer). Last update [53d1395...09852ce](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng merged pull request #33: [Feature]
Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] arugal commented on a change in pull request #33:
[Feature] Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#discussion_r389245498
##########
File path: README.md
##########
@@ -395,6 +425,50 @@ $ ./bin/swctl-latest-darwin-amd64 --display=graph --debug metrics multiple-linea
<details>
+<summary>Query the top 5 services whose sla is largest</summary>
+
+```shell
+$ ./bin/swctl metrics top 5 --name service_sla
+[{"name":"projectB","id":"2","value":10000},{"name":"projectC","id":"3","value":10000},{"name":"projectA","id":"4","value":10000},{"name":"projectD","id":"5","value":10000}]
+```
+
+</details>
+
+<details>
+
+<summary>Query the top 5 instances whose sla is largest, of service (id = 3)</summary>
+
+```shell
+$ ./bin/swctl metrics top 5 --name service_instance_sla --service-id 3
+[{"name":"projectC-pid:30335@skywalking-server-0002","id":"13","value":10000},{"name":"projectC-pid:22037@skywalking-server-0001","id":"2","value":10000}]
+```
+
+</details>
+
+<details>
+
+<summary>Query the top 5 endpoints whose sla is largest, of service (id = 3)</summary>
+
+```shell
+$ ./bin/swctl metrics top 5 --name endpoint_sla --service-id 3
+[{"name":"/projectC/{value}","id":"4","value":10000}]
+```
+
+</details>
+
+<details>
+
+<summary>Query the overall heatmap</summary>
+
+```shell
+$ ./bin/swctl-latest-darwin-amd64 metrics thermodynamic --name all_heatmap
Review comment:
is `swctl-latest-darwin-amd64`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #33:
[Feature] Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596072259
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=h1) Report
> Merging [#33](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/6542344a89605f04fa32471da4bd5575df677bee?src=pr&el=desc) will **increase** coverage by `2.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 54.45% 57.14% +2.68%
==========================================
Files 6 7 +1
Lines 101 112 +11
==========================================
+ Hits 55 64 +9
- Misses 39 40 +1
- Partials 7 8 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [graphql/utils/adapter.go](https://codecov.io/gh/apache/skywalking-cli/pull/33/diff?src=pr&el=tree#diff-Z3JhcGhxbC91dGlscy9hZGFwdGVyLmdv) | `81.81% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=footer). Last update [6542344...6308893](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #33: [Feature] Support
top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596075724
Is this intended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io edited a comment on issue #33:
[Feature] Support top N entities and thermodynamic metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #33: [Feature] Support top N entities and thermodynamic metrics
URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596072259
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=h1) Report
> Merging [#33](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/53d1395a48c506247df6554730644d1c5b46ea60?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 7 7
Lines 112 112
=======================================
Hits 64 64
Misses 40 40
Partials 8 8
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=footer). Last update [53d1395...d7ba925](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services