You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/09/04 23:27:45 UTC
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11386
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
[DOCS] Additional updates to the fine-grained priv
Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_revoke.xml
4 files changed, 555 insertions(+), 344 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/11386/1
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 03:26:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/67/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Sep 2018 21:54:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_grant.xml@93
PS1, Line 93: Impala does not currently support revoking only the <codeph>WITH GRANT OPTION</codeph>
: from a privilege previously granted to a role. To remove the <codeph>WITH GRANT
: OPTION</codeph>, revoke the privilege and grant it again without the <codeph>WITH GRANT
: OPTION</codeph> flag.
> This is not correct. You cannot revoke a privilege if it has the grant opt
Added in impala_revoke.xml
http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_revoke.xml
File docs/topics/impala_revoke.xml:
http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_revoke.xml@57
PS1, Line 57: <varname>privilege</varname>
> The optional "GRANT OPTION FOR" is missing.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Sep 2018 21:45:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/66/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Sep 2018 23:57:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Adam Holley,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11386
to look at the new patch set (#2).
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
[DOCS] Additional updates to the fine-grained priv
Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_revoke.xml
4 files changed, 567 insertions(+), 345 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/11386/2
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_grant.xml
File docs/topics/impala_grant.xml:
http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_grant.xml@93
PS1, Line 93: Impala does not currently support revoking only the <codeph>WITH GRANT OPTION</codeph>
: from a privilege previously granted to a role. To remove the <codeph>WITH GRANT
: OPTION</codeph>, revoke the privilege and grant it again without the <codeph>WITH GRANT
: OPTION</codeph> flag.
This is not correct. You cannot revoke a privilege if it has the grant option set to true. If a privilege is granted with grant option, it takes two statements to revoke it.
e.g.
if:
GRANT ALL ON SERVER TO ROLE foo_role;
then to remove:
REVOKE GRANT OPTION FOR ALL ON SERVER FROM ROLE foo_role;
REVOKE ALL ON SERVER FROM ROLE foo_fole;
http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_revoke.xml
File docs/topics/impala_revoke.xml:
http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_revoke.xml@57
PS1, Line 57: <varname>privilege</varname>
The optional "GRANT OPTION FOR" is missing.
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Sep 2018 20:00:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/66/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Sep 2018 23:27:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/67/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Sep 2018 21:44:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
[DOCS] Additional updates to the fine-grained priv
Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Reviewed-on: http://gerrit.cloudera.org:8080/11386
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Adam Holley <ah...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_revoke.xml
4 files changed, 567 insertions(+), 345 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Adam Holley: Looks good to me, but someone else must approve
Alex Rodoni: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [DOCS] Additional updates to the fine-grained priv
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c
Gerrit-Change-Number: 11386
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Sep 2018 03:28:19 +0000
Gerrit-HasComments: No