You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "srinireddy2020 (via GitHub)" <gi...@apache.org> on 2026/04/02 03:53:19 UTC
[PR] HBASE-30051 Avoid Unnecessary Protobuf Conversions in HMaster Admin API Calls [hbase]
srinireddy2020 opened a new pull request, #8018:
URL: https://github.com/apache/hbase/pull/8018
Admin APIs invoked on the HMaster are routed internally back to the same HMaster instance, leading to unnecessary protobuf serialization and deserialization. This adds significant overhead, especially in environments with a large number of tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30051 Avoid Unnecessary Protobuf Conversions in HMaster Admin API Calls [hbase]
Posted by "srinireddy2020 (via GitHub)" <gi...@apache.org>.
srinireddy2020 commented on PR #8018:
URL: https://github.com/apache/hbase/pull/8018#issuecomment-4261452818
> I mean the performance change in real workload.
>
> I see that you have changed two places, what is the performance numbers for these two places before and after this PR?
@Apache9 please check, I have provided the performance numbers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30051 Avoid Unnecessary Protobuf Conversions in HMaster Admin API Calls [hbase]
Posted by "srinireddy2020 (via GitHub)" <gi...@apache.org>.
srinireddy2020 commented on PR #8018:
URL: https://github.com/apache/hbase/pull/8018#issuecomment-4233782219
> I mean the performance change in real workload.
>
> I see that you have changed two places, what is the performance numbers for these two places before and after this PR?
I validated the performance test on a real HBase cluster with 400 tables. Here are the observations:
For rsGroup changes observed 42.5% improvement.
For RSGroup (with out fix)
Iterations: 100
Avg Time: 41175178.39 nanos
Min Time: 29244928 nanos
Max Time: 81204085 nanos
Median Time: 37750862 nanos
P95 Time: 59508779 nanos
P99 Time: 69041148 nanos
============================
For RSGroup (with fix)
Iterations: 100
Avg Time: 23654449.31 nanos
Min Time: 16609079 nanos
Max Time: 36157928 nanos
Median Time: 22623794 nanos
P95 Time: 32494615 nanos
P99 Time: 35838576 nanos
============================
For SnapshotQuotaObserverChore observed 40.6% improvement
Improvement 40.6%
For SnapshotQuota (with out fix)
Iterations: 100
Avg Time: 43582296.45 nanos
Min Time: 31566942 nanos
Max Time: 82250476 nanos
Median Time: 38645752 nanos
P95 Time: 62457758 nanos
P99 Time: 70146689 nanos
============================
For SnapshotQuota (with fix)
Iterations: 100
Avg Time: 25858876.45 nanos
Min Time: 17589768 nanos
Max Time: 38564598 nanos
Median Time: 23498268 nanos
P95 Time: 33386064 nanos
P99 Time: 37569430 nanos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30051 Avoid Unnecessary Protobuf Conversions in HMaster Admin API Calls [hbase]
Posted by "srinireddy2020 (via GitHub)" <gi...@apache.org>.
srinireddy2020 commented on PR #8018:
URL: https://github.com/apache/hbase/pull/8018#issuecomment-4192586196
> Do you have any performance numbers about the overhead?
Verified performance test in HBase Mini cluster with 350 tables. Observed 97.5% improvement for this changes.
Method: admin.listTableDescriptors(true)
Iterations: 100
Avg Time: 10311891.82 nanos
Min Time: 6341330 nanos
Max Time: 119611397 nanos
Median Time: 7631084 nanos
P95 Time: 16353979 nanos
P99 Time: 119611397 nanos
============================
Method: master.listTableDescriptorsByNamespace(null)
Iterations: 100
Avg Time: 253733.7 nanos
Min Time: 197507 nanos
Max Time: 511075 nanos
Median Time: 224771 nanos
P95 Time: 444529 nanos
P99 Time: 511075 nanos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30051 Avoid Unnecessary Protobuf Conversions in HMaster Admin API Calls [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #8018:
URL: https://github.com/apache/hbase/pull/8018#issuecomment-4189012567
Do you have any performance numbers about the overhead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-30051 Avoid Unnecessary Protobuf Conversions in HMaster Admin API Calls [hbase]
Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #8018:
URL: https://github.com/apache/hbase/pull/8018#issuecomment-4192714726
I mean the performance change in real workload.
I see that you have changed two places, what is the performance numbers for these two places before and after this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org