You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/20 13:54:47 UTC
[GitHub] [apisix] zhixiongdu027 opened a new pull request, #7506: fix: cleanup variable before re list and watch
zhixiongdu027 opened a new pull request, #7506:
URL: https://github.com/apache/apisix/pull/7506
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixs # (issue)
#7489
### Checklist
- [] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on PR #7506:
URL: https://github.com/apache/apisix/pull/7506#issuecomment-1192130320
pls rebase the upstream master branch to your PR branch, the CI failed has been fixed in the master branch of upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhixiongdu027 commented on pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
zhixiongdu027 commented on PR #7506:
URL: https://github.com/apache/apisix/pull/7506#issuecomment-1190929150
Hi, @tokers @crazyMonkey1995
Please help review, Many tks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #7506:
URL: https://github.com/apache/apisix/pull/7506#issuecomment-1192207146
> @tzssangglass @tokers Please help re start ci .
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhixiongdu027 commented on pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
zhixiongdu027 commented on PR #7506:
URL: https://github.com/apache/apisix/pull/7506#issuecomment-1192200692
@tzssangglass @tokers
Please help re start ci .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7506:
URL: https://github.com/apache/apisix/pull/7506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #7506:
URL: https://github.com/apache/apisix/pull/7506#issuecomment-1191261888
I just re-ran the failed CI jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a diff in pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #7506:
URL: https://github.com/apache/apisix/pull/7506#discussion_r926462922
##########
apisix/discovery/kubernetes/informer_factory.lua:
##########
@@ -263,6 +263,9 @@ local function list_watch(informer, apiserver)
local reason, message
local httpc = http.new()
+ informer.continue = ""
+ informer.version = ""
Review Comment:
Understand it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a diff in pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #7506:
URL: https://github.com/apache/apisix/pull/7506#discussion_r926176293
##########
apisix/discovery/kubernetes/informer_factory.lua:
##########
@@ -263,6 +263,9 @@ local function list_watch(informer, apiserver)
local reason, message
local httpc = http.new()
+ informer.continue = ""
+ informer.version = ""
Review Comment:
Is it possible to add some cases to verify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhixiongdu027 commented on a diff in pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
zhixiongdu027 commented on code in PR #7506:
URL: https://github.com/apache/apisix/pull/7506#discussion_r926177829
##########
apisix/discovery/kubernetes/informer_factory.lua:
##########
@@ -263,6 +263,9 @@ local function list_watch(informer, apiserver)
local reason, message
local httpc = http.new()
+ informer.continue = ""
+ informer.version = ""
Review Comment:
I've thought about it too, but it's difficult.
Unless we are able to modify the value of "continue" at runtime in some way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] crazyMonkey1995 commented on a diff in pull request #7506: fix: cleanup variable before re list and watch
Posted by GitBox <gi...@apache.org>.
crazyMonkey1995 commented on code in PR #7506:
URL: https://github.com/apache/apisix/pull/7506#discussion_r926249213
##########
apisix/discovery/kubernetes/informer_factory.lua:
##########
@@ -263,6 +263,9 @@ local function list_watch(informer, apiserver)
local reason, message
local httpc = http.new()
+ informer.continue = ""
+ informer.version = ""
Review Comment:
There is really no simpler way to reproduce. This unit test case is probably not easy to write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org