You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/09 09:37:33 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #10257: Improve "Before you begin" section in google-cloud-secret-manager-backend.rst

mik-laj commented on a change in pull request #10257:
URL: https://github.com/apache/airflow/pull/10257#discussion_r467560711



##########
File path: docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst
##########
@@ -26,7 +26,15 @@ a secret backend and how to manage secrets.
 Before you begin
 """"""""""""""""
 
-`Configure Secret Manager and your local environment <https://cloud.google.com/secret-manager/docs/configuring-secret-manager>`__, once per project.
+Before you start, make sure you have performed the following tasks:
+
+1.  Include sendgrid subpackage as part of your Airflow installation
+
+    .. code-block:: bash
+
+        pip install airflow[google]

Review comment:
       It should be 
   ```
   airflow`[sengrid]`
   ```
   but pre-commit is sad.
   
   > ```
   > rst ``code`` is two backticks.....................................................................................................Failed
   > - hook id: rst-backticks
   > - exit code: 1
   > 
   > docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst:35:        pip install `airflow[google]`
   > 
   > ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org