[GitHub] [rocketmq] ni-ze commented on pull request #4218: delete useless code

[GitBox <gi...@apache.org>]

ni-ze commented on PR #4218:
URL: https://github.com/apache/rocketmq/pull/4218#issuecomment-1112820525

   It does look repeated.
   If this.brokerController.getBrokerConfig().isSlaveReadEnable() equals false, suggest broker is always master.
   
   ```java
             if (getMessageResult.isSuggestPullingFromSlave()) {
                   responseHeader.setSuggestWhichBrokerId(subscriptionGroupConfig.getWhichBrokerWhenConsumeSlowly());
               } else {
                   responseHeader.setSuggestWhichBrokerId(MixAll.MASTER_ID);
               }
   ```
   Result of the above code is covered.
   
   If slaveReadEnable equals true, the result of latter code part has also cover the above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org