You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Ning Zhang <nz...@fb.com> on 2011/05/10 01:05:58 UTC

Review Request: HIVE-2153. Stats JDBC LIKE queries should escape '_' and '%'

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/702/
-----------------------------------------------------------

Review request for hive.


Summary
-------

Escape '_' and '%' in the LIKE operands. 


This addresses bug HIVE-2153.
    https://issues.apache.org/jira/browse/HIVE-2153


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1101220 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java 1101220 

Diff: https://reviews.apache.org/r/702/diff


Testing
-------

passed the stats test suite, also tested it manually on mysql in addition to derby. 


Thanks,

Ning

Re: Review Request: HIVE-2153. Stats JDBC LIKE queries should escape '_' and '%'

Posted by Ning Zhang <nz...@fb.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/702/
-----------------------------------------------------------

(Updated 2011-05-09 23:25:51.497027)


Review request for hive.


Summary
-------

Escape '_' and '%' in the LIKE operands. 


This addresses bug HIVE-2153.
    https://issues.apache.org/jira/browse/HIVE-2153


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1101220 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java 1101220 

Diff: https://reviews.apache.org/r/702/diff


Testing
-------

passed the stats test suite, also tested it manually on mysql in addition to derby. 


Thanks,

Ning